Compare commits

..
Author SHA1 Message Date
CanbiZ (MickLesk) eebd70c119 ref
Removed outdated comments regarding Browserless and SockPuppetBrowser.
2026-11-21 15:46:23 +01:00
MickLesk 30cdbc6b3a Change Detection: create the SockPuppetBrowser unit whenever it is missing
The update wrote sockpuppetbrowser.service only while replacing Browserless,
then restarted it unconditionally. A container without browserless.service
(installs before 2023-05, or a lost unit) had SockPuppetBrowser deployed and
the update stopped with "Unit sockpuppetbrowser.service not found" (exit 5).
2026-11-21 15:34:48 +01:00
2 changed files with 11 additions and 10 deletions

No files matched your search

+10 -5
View File
@@ -93,6 +93,15 @@ function update_script() {
rm -rf /opt/browserless /root/.cache/ms-playwright
$STD apt purge -y microsoft-edge-stable
rm -f /etc/apt/sources.list.d/microsoft-edge-stable.list
sed -i 's/browserless\.service/sockpuppetbrowser.service/g' "$SERVICE_FILE"
sed -i -e '/^WEBDRIVER_URL=/d' \
-e 's|^PLAYWRIGHT_DRIVER_URL=ws://localhost:3000/chrome.*|PLAYWRIGHT_DRIVER_URL=ws://127.0.0.1:3000/?headful=true\&--window-size=1920,1080|' \
/opt/changedetection/.env
msg_ok "Replaced Browserless with SockPuppetBrowser"
fi
if [[ ! -f /etc/systemd/system/sockpuppetbrowser.service ]]; then
msg_info "Creating SockPuppetBrowser Service"
cat <<EOF >/etc/systemd/system/sockpuppetbrowser.service
[Unit]
Description=SockPuppetBrowser
@@ -110,13 +119,9 @@ Restart=on-failure
[Install]
WantedBy=multi-user.target
EOF
sed -i 's/browserless\.service/sockpuppetbrowser.service/g' "$SERVICE_FILE"
sed -i -e '/^WEBDRIVER_URL=/d' \
-e 's|^PLAYWRIGHT_DRIVER_URL=ws://localhost:3000/chrome.*|PLAYWRIGHT_DRIVER_URL=ws://127.0.0.1:3000/?headful=true\&--window-size=1920,1080|' \
/opt/changedetection/.env
systemctl daemon-reload
systemctl enable -q sockpuppetbrowser
msg_ok "Replaced Browserless with SockPuppetBrowser"
msg_ok "Created SockPuppetBrowser Service"
fi
systemctl daemon-reload
+1 -5
View File
@@ -108,11 +108,7 @@ function trim_container() {
echo -e "${BL}[Info]${GN} Trimming ${BL}$container${CL} \n"
local before_trim after_trim
# A restored or moved container's root is not always disk-0; the volume comes
# from its config file, which needs no pct call.
local lv_name
lv_name="$(awk -F'[:,]' '/^rootfs:/ {print $3; exit}' "/etc/pve/lxc/${container}.conf" 2>/dev/null)"
[[ -n "$lv_name" ]] || lv_name="vm-${container}-disk-0"
local lv_name="vm-${container}-disk-0"
if lvs --noheadings -o lv_name 2>/dev/null | grep -qw "$lv_name"; then
before_trim=$(lvs --noheadings -o lv_name,data_percent 2>/dev/null | awk -v ctid="$lv_name" '$1 == ctid {gsub(/%/, "", $2); print $2}')
[[ -n "$before_trim" ]] && echo -e "${RD}Data before trim $before_trim%${CL}" || echo -e "${RD}Data before trim: not available${CL}"