Compare commits

..
Author SHA1 Message Date
CanbiZ (MickLesk) eebd70c119 ref
Removed outdated comments regarding Browserless and SockPuppetBrowser.
2026-11-21 15:46:23 +01:00
MickLesk 30cdbc6b3a Change Detection: create the SockPuppetBrowser unit whenever it is missing
The update wrote sockpuppetbrowser.service only while replacing Browserless,
then restarted it unconditionally. A container without browserless.service
(installs before 2023-05, or a lost unit) had SockPuppetBrowser deployed and
the update stopped with "Unit sockpuppetbrowser.service not found" (exit 5).
2026-11-21 15:34:48 +01:00
3 changed files with 19 additions and 31 deletions

No files matched your search

+10 -5
View File
@@ -93,6 +93,15 @@ function update_script() {
rm -rf /opt/browserless /root/.cache/ms-playwright
$STD apt purge -y microsoft-edge-stable
rm -f /etc/apt/sources.list.d/microsoft-edge-stable.list
sed -i 's/browserless\.service/sockpuppetbrowser.service/g' "$SERVICE_FILE"
sed -i -e '/^WEBDRIVER_URL=/d' \
-e 's|^PLAYWRIGHT_DRIVER_URL=ws://localhost:3000/chrome.*|PLAYWRIGHT_DRIVER_URL=ws://127.0.0.1:3000/?headful=true\&--window-size=1920,1080|' \
/opt/changedetection/.env
msg_ok "Replaced Browserless with SockPuppetBrowser"
fi
if [[ ! -f /etc/systemd/system/sockpuppetbrowser.service ]]; then
msg_info "Creating SockPuppetBrowser Service"
cat <<EOF >/etc/systemd/system/sockpuppetbrowser.service
[Unit]
Description=SockPuppetBrowser
@@ -110,13 +119,9 @@ Restart=on-failure
[Install]
WantedBy=multi-user.target
EOF
sed -i 's/browserless\.service/sockpuppetbrowser.service/g' "$SERVICE_FILE"
sed -i -e '/^WEBDRIVER_URL=/d' \
-e 's|^PLAYWRIGHT_DRIVER_URL=ws://localhost:3000/chrome.*|PLAYWRIGHT_DRIVER_URL=ws://127.0.0.1:3000/?headful=true\&--window-size=1920,1080|' \
/opt/changedetection/.env
systemctl daemon-reload
systemctl enable -q sockpuppetbrowser
msg_ok "Replaced Browserless with SockPuppetBrowser"
msg_ok "Created SockPuppetBrowser Service"
fi
systemctl daemon-reload
+5 -22
View File
@@ -4,7 +4,7 @@ source "$_cs_boot" 2>/dev/null || source <(curl -fsSL "${COMMUNITY_SCRIPTS_CORE_
# Copyright (c) 2021-2026 community-scripts ORG
# Author: nnsense
# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
# Source: https://github.com/TheBadFella/Pinchflat-NGX
# Source: https://github.com/kieraneglin/pinchflat
APP="Pinchflat"
var_tags="${var_tags:-media;youtube;downloader}"
@@ -32,27 +32,17 @@ function update_script() {
exit 1
fi
if check_for_gh_release "pinchflat" "TheBadFella/Pinchflat-NGX"; then
if check_for_gh_release "pinchflat" "kieraneglin/pinchflat"; then
msg_info "Stopping Service"
systemctl stop pinchflat
msg_ok "Stopped Service"
if [[ ! -f /opt/pinchflat-src/lib/pinchflat/legacy_migration.ex && ! -f /opt/pinchflat-pre-ngx.tar.gz ]]; then
NGX_SWITCH=1
msg_info "Backing up Pinchflat before the switch to Pinchflat-NGX"
tar -czf /opt/pinchflat-pre-ngx.tar.gz.part -C /opt/pinchflat --exclude=config/metadata --exclude=config/logs .env app config
mv /opt/pinchflat-pre-ngx.tar.gz.part /opt/pinchflat-pre-ngx.tar.gz
msg_ok "Backed up to /opt/pinchflat-pre-ngx.tar.gz"
fi
CLEAN_INSTALL=1 fetch_and_deploy_gh_release "pinchflat" "kieraneglin/pinchflat" "tarball" "latest" "/opt/pinchflat-src"
CLEAN_INSTALL=1 fetch_and_deploy_gh_release "pinchflat" "TheBadFella/Pinchflat-NGX" "tarball" "latest" "/opt/pinchflat-src"
msg_info "Building Pinchflat-NGX"
msg_info "Building Pinchflat"
cd /opt/pinchflat-src
export MIX_ENV=prod
export ERL_FLAGS="+JPperf true"
$STD mix local.hex --force
$STD mix local.rebar --force
$STD mix deps.get --only prod
$STD mix deps.compile
$STD yarn --cwd assets install
@@ -61,18 +51,11 @@ function update_script() {
$STD mix release --overwrite
rm -rf /opt/pinchflat/app
cp -r _build/prod/rel/pinchflat /opt/pinchflat/app
msg_ok "Built Pinchflat-NGX"
msg_info "Migrating Database"
$STD systemd-run --wait --pipe --quiet --collect -p EnvironmentFile=/opt/pinchflat/.env -p WorkingDirectory=/opt/pinchflat/app /opt/pinchflat/app/bin/migrate
msg_ok "Migrated Database"
msg_ok "Built Pinchflat"
msg_info "Starting Service"
systemctl start pinchflat
msg_ok "Started Service"
if [[ -n "${NGX_SWITCH:-}" ]]; then
msg_warn "Open the web UI and confirm the migration review, downloads stay on hold until then"
fi
msg_ok "Updated successfully!"
fi
exit
+4 -4
View File
@@ -3,7 +3,7 @@
# Copyright (c) 2021-2026 community-scripts ORG
# Author: nnsense
# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
# Source: https://github.com/TheBadFella/Pinchflat-NGX
# Source: https://github.com/kieraneglin/pinchflat
source /dev/stdin <<<"$FUNCTIONS_FILE_PATH"
@@ -48,7 +48,7 @@ export PIPX_BIN_DIR=/usr/local/bin
$STD pipx install apprise
msg_ok "Installed Apprise"
fetch_and_deploy_gh_release "pinchflat" "TheBadFella/Pinchflat-NGX" "tarball" "latest" "/opt/pinchflat-src"
fetch_and_deploy_gh_release "pinchflat" "kieraneglin/pinchflat" "tarball" "latest" "/opt/pinchflat-src"
msg_info "Configuring Pinchflat"
CONFIG_PATH="/opt/pinchflat/config"
@@ -81,7 +81,7 @@ SECRET_KEY_BASE=$(openssl rand -base64 48)
EOF
msg_ok "Configured Pinchflat"
msg_info "Building Pinchflat-NGX"
msg_info "Building Pinchflat"
cd /opt/pinchflat-src
export MIX_ENV=prod
export ERL_FLAGS="+JPperf true"
@@ -95,7 +95,7 @@ $STD mix compile
$STD mix release --overwrite
rm -rf /opt/pinchflat/app
cp -r _build/prod/rel/pinchflat /opt/pinchflat/app
msg_ok "Built Pinchflat-NGX"
msg_ok "Built Pinchflat"
msg_info "Creating Service"
cat <<EOF >/etc/systemd/system/pinchflat.service