Proxmox/ProxmoxVE
1
0
Fork 1
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-02-26 15:05:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(build): show telemetry status only in verbose mode

Browse Source 
Telemetry reporting is an implementation detail that doesn't help
the user during failure recovery. Wrap echo statements with
VERBOSE check so they only appear when verbose mode is enabled.
This commit is contained in:
CanbiZ (MickLesk)
2026-02-25 14:01:31 +01:00
parent 6731001360
commit cfc1fc3c6b
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
misc/build.func
View File

@@ -4181,9 +4181,9 @@ EOF'
# NOTE: Do NOT use msg_info/spinner here — the background spinner process
# causes SIGTSTP in non-interactive shells (bash -c "$(curl ...)"), which
# stops the entire process group and prevents the recovery dialog from appearing.
echo -e "${TAB}⏳ Reporting failure to telemetry..." >&2
$STD echo -e "${TAB}⏳ Reporting failure to telemetry..."
post_update_to_api "failed" "$install_exit_code"
echo -e "${TAB}${CM:-✔} Failure reported" >&2
$STD echo -e "${TAB}${CM:-✔} Failure reported"
# Defense-in-depth: Ensure error handling stays disabled during recovery.
# Some functions (e.g. silent/$STD) unconditionally re-enable set -Eeuo pipefail
@@ -4547,9 +4547,9 @@ EOF'
# Force one final status update attempt after cleanup
# This ensures status is updated even if the first attempt failed (e.g., HTTP 400)
echo -e "${TAB}⏳ Finalizing telemetry report..." >&2
$STD echo -e "${TAB}⏳ Finalizing telemetry report..."
post_update_to_api "failed" "$install_exit_code" "force"
echo -e "${TAB}${CM:-✔} Telemetry finalized" >&2
$STD echo -e "${TAB}${CM:-✔} Telemetry finalized"
# Restore default SIGTSTP handling before exit
trap - TSTP