From cfc1fc3c6b2ff2ec5f14566caf6f963ca7378132 Mon Sep 17 00:00:00 2001 From: "CanbiZ (MickLesk)" <47820557+MickLesk@users.noreply.github.com> Date: Wed, 25 Feb 2026 14:01:31 +0100 Subject: [PATCH] fix(build): show telemetry status only in verbose mode Telemetry reporting is an implementation detail that doesn't help the user during failure recovery. Wrap echo statements with VERBOSE check so they only appear when verbose mode is enabled. --- misc/build.func | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/misc/build.func b/misc/build.func index d5ead1890..2b4b41f26 100644 --- a/misc/build.func +++ b/misc/build.func @@ -4181,9 +4181,9 @@ EOF' # NOTE: Do NOT use msg_info/spinner here — the background spinner process # causes SIGTSTP in non-interactive shells (bash -c "$(curl ...)"), which # stops the entire process group and prevents the recovery dialog from appearing. - echo -e "${TAB}⏳ Reporting failure to telemetry..." >&2 + $STD echo -e "${TAB}⏳ Reporting failure to telemetry..." post_update_to_api "failed" "$install_exit_code" - echo -e "${TAB}${CM:-✔} Failure reported" >&2 + $STD echo -e "${TAB}${CM:-✔} Failure reported" # Defense-in-depth: Ensure error handling stays disabled during recovery. # Some functions (e.g. silent/$STD) unconditionally re-enable set -Eeuo pipefail @@ -4547,9 +4547,9 @@ EOF' # Force one final status update attempt after cleanup # This ensures status is updated even if the first attempt failed (e.g., HTTP 400) - echo -e "${TAB}⏳ Finalizing telemetry report..." >&2 + $STD echo -e "${TAB}⏳ Finalizing telemetry report..." post_update_to_api "failed" "$install_exit_code" "force" - echo -e "${TAB}${CM:-✔} Telemetry finalized" >&2 + $STD echo -e "${TAB}${CM:-✔} Telemetry finalized" # Restore default SIGTSTP handling before exit trap - TSTP