mirror of
https://github.com/community-scripts/ProxmoxVE.git
synced 2026-02-16 18:23:27 +01:00
* Enhance setup-fork.sh with --full mode and misc/ targeting Added a new --full flag to setup-fork.sh to allow updating all files, not just those in misc/. Updated documentation and usage examples to clarify the new behavior. Improved file search and replacement logic for broader compatibility and flexibility. * add AI.md * fix links in AI.md * Update contribution docs and templates for best practices Refreshed AI.md with new reference scripts, expanded checklist, and improved AI assistant tips. Updated container and install script templates for modern defaults (Debian 13, larger disk, two tags), clarified helper function usage, and improved update/backup patterns. Enhanced JSON template with realistic metadata, new fields, and example notes. * Update fetch_and_deploy_gh_release usage in docs and templates Standardize the usage of fetch_and_deploy_gh_release by specifying all arguments, including mode, version, and target directory, in AI.md and template scripts. This clarifies the function's usage and ensures consistency across documentation and install/update templates. * Revise contribution docs and update CT template Expanded and clarified contribution documentation for forking, local development, cherry-picking, and AI-assisted code generation. Improved explanations for setup-fork.sh, local testing, and PR submission. Enhanced the container script template with detailed comments, clearer update_script structure, and step-by-step guidance for maintainers and contributors. * Update fork and release instructions in contribution docs Replaced placeholder GitHub repo references with 'YourUsername/YourRepo' throughout documentation for clarity. Expanded explanations in FORK_SETUP.md and README.md to clarify the difference between development and production script execution, and emphasized the importance of cherry-picking only relevant files for PRs. Updated install script template examples to use the new repo placeholder. * Update GitHub repo placeholders in docs and templates Replaced 'YourUsername/YourRepo' with 'owner/repo' in documentation and template scripts for consistency and clarity. This change standardizes example usage and reduces confusion for contributors. * Move user submitted guides to guides directory Renamed USER_SUBMITTED_GUIDES.md from docs/contribution to docs/guides for improved documentation organization. * Update contribution docs for improved workflow and clarity Revised multiple documentation files to clarify the recommended development workflow: contributors must test scripts via curl from their GitHub fork (not local bash), use setup-fork.sh for URL rewriting, and submit only new files using cherry-pick. Expanded and modernized install and JSON metadata template guides, emphasizing use of helper functions, resource requirements, and the JSON generator tool. Added detailed step-by-step instructions, best practices, and updated examples throughout. * Update contribution docs for new file structure Updated documentation to reflect the migration of install scripts from install_scripts/ to install/, and JSON metadata from config/ to frontend/public/json/. Adjusted all relevant paths, instructions, and examples to match the new directory structure for improved clarity and consistency. * Update contribution docs for fork setup and metadata Revised documentation to standardize use of 'bash docs/contribution/setup-fork.sh --full' for fork configuration, clarified install script execution flow, and updated JSON metadata template and field references. Improved helper function docs, resource requirements, and category lists. Updated references and instructions throughout for consistency and accuracy. * Docs: add GPU/TUN, update endpoints & tool refs Documentation updates across guides and function references: - Added var_gpu and var_tun configuration entries to CONFIGURATION_REFERENCE (GPU passthrough and TUN/TAP support), including features and prerequisites. - Fixed repository URLs throughout UNATTENDED_DEPLOYMENTS and examples: replaced community-scripts/ProxmoxVED with community-scripts/ProxmoxVE and updated curl usage to the new paths. - Added an "Advanced Configuration Variables" table and examples (var_os, var_version, var_gpu, var_tun, var_nesting) to UNATTENDED_DEPLOYMENTS; adjusted sample apps, hostnames, and container mappings in batch examples. - Switched API endpoints in API_FUNCTIONS_REFERENCE and API_USAGE_EXAMPLES from http://api.community-scripts.org to https://api.community-scripts.org. - Expanded BUILD_FUNC_FUNCTIONS_REFERENCE with container resource/ID management helper descriptions (validate_container_id, get_valid_container_id, maxkeys_check, get_current_ip, update_motd_ip). - Large edits to TOOLS_FUNC_FUNCTIONS_REFERENCE: renamed/refactored helper signatures and docs (pkg_install -> install_packages_with_retry, pkg_update -> upgrade_packages_with_retry), added new tooling functions (fetch_and_deploy_gh_release, check_for_gh_release, prepare_repository_setup, verify_tool_version) and updated examples and feature notes. - Updated vm/README.md to list additional VM scripts (new and reorganized examples). These are documentation-only changes to clarify configuration options, correct links and endpoints, and expand the reference material for tooling and build helpers. * Docs: expand developer/debugging and tools references Add extensive documentation and examples across contribution, guides, templates and tools references. Key changes: - Introduce a Developer Mode & Debugging section (dev_mode flags: trace, keep, pause, breakpoint, logs, dryrun, motd) in CONTRIBUTING.md with usage example. - Provide a standard update_script() pattern and BookStack example in GUIDE.md to clarify update flow (stop services, backup, deploy, restore, migrate, restart). - Add new helper entries (BookLore, KaraKeep) and advanced repository helpers (setup_deb822_repo, prepare_repository_setup, cleanup_tool_keyrings) plus utilities (setup_meilisearch, verify_tool_version) in HELPER_FUNCTIONS.md. - Update install template to suggest PNPM, Java 21 and Meilisearch; update example DB setup notes in AppName-install.sh. - Add var_diagnostics option and switch var_fuse to boolean/toggle wording in CONFIGURATION_REFERENCE.md; clarify privacy and defaults. - Adjust example container definitions in UNATTENDED_DEPLOYMENTS.md (container entries and resource values). - Change storage and flag variables and examples in BUILD_FUNC_USAGE_EXAMPLES.md (ssd-storage, var_fuse/var_tun, etc.). - Expand TOOLS_FUNC_FUNCTIONS_REFERENCE.md with many setup_* function signatures, environment vars, clarified fetch_and_deploy_gh_release modes/parameters, and additional tool docs (nodejs, php, mariadb_db, postgresql_db, java, uv, yq, meilisearch, composer, build tools). These updates improve onboarding, debugging guidance, and operational clarity for contributors and maintainers.
279 lines
6.9 KiB
Markdown
279 lines
6.9 KiB
Markdown
# CT Container Scripts - Quick Reference
|
|
|
|
> [!WARNING]
|
|
> **This is legacy documentation.** Refer to the **modern template** at [templates_ct/AppName.sh](AppName.sh) for best practices.
|
|
>
|
|
> Current templates use:
|
|
>
|
|
> - `tools.func` helpers instead of manual patterns
|
|
> - `check_for_gh_release` and `fetch_and_deploy_gh_release` from build.func
|
|
> - Automatic setup-fork.sh configuration
|
|
|
|
---
|
|
|
|
## Before Creating a Script
|
|
|
|
1. **Fork & Clone:**
|
|
|
|
```bash
|
|
git clone https://github.com/YOUR_USERNAME/ProxmoxVE.git
|
|
cd ProxmoxVE
|
|
```
|
|
|
|
2. **Run setup-fork.sh** (updates all curl URLs to your fork):
|
|
|
|
```bash
|
|
bash docs/contribution/setup-fork.sh
|
|
```
|
|
|
|
3. **Copy the Modern Template:**
|
|
|
|
```bash
|
|
cp templates_ct/AppName.sh ct/MyApp.sh
|
|
# Edit ct/MyApp.sh with your app details
|
|
```
|
|
|
|
4. **Test Your Script (via GitHub):**
|
|
|
|
⚠️ **Important:** You must push to GitHub and test via curl, not `bash ct/MyApp.sh`!
|
|
|
|
```bash
|
|
# Push your changes to your fork first
|
|
git push origin feature/my-awesome-app
|
|
|
|
# Then test via curl (this loads from YOUR fork, not local files)
|
|
bash -c "$(curl -fsSL https://raw.githubusercontent.com/YOUR_USERNAME/ProxmoxVE/main/ct/MyApp.sh)"
|
|
```
|
|
|
|
> 💡 **Why?** The script's curl commands are modified by setup-fork.sh, but local execution uses local files, not the updated GitHub URLs. Testing via curl ensures your script actually works.
|
|
>
|
|
> ⏱️ **Note:** GitHub sometimes takes 10-30 seconds to update files. If you don't see your changes, wait and try again.
|
|
|
|
5. **Cherry-Pick for PR** (submit ONLY your 3-4 files):
|
|
- See [Cherry-Pick Guide](../README.md) for step-by-step git commands
|
|
|
|
---
|
|
|
|
## Template Structure
|
|
|
|
The modern template includes:
|
|
|
|
### Header
|
|
|
|
```bash
|
|
#!/usr/bin/env bash
|
|
source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func)
|
|
# (Note: setup-fork.sh changes this URL to point to YOUR fork during development)
|
|
```
|
|
|
|
### Metadata
|
|
|
|
```bash
|
|
# Copyright (c) 2021-2026 community-scripts ORG
|
|
# Author: YourUsername
|
|
# License: MIT
|
|
APP="MyApp"
|
|
var_tags="app-category;foss"
|
|
var_cpu="2"
|
|
var_ram="2048"
|
|
var_disk="4"
|
|
var_os="alpine"
|
|
var_version="3.20"
|
|
var_unprivileged="1"
|
|
```
|
|
|
|
### Core Setup
|
|
|
|
```bash
|
|
header_info "$APP"
|
|
variables
|
|
color
|
|
catch_errors
|
|
```
|
|
|
|
### Update Function
|
|
|
|
The modern template provides a standard update pattern:
|
|
|
|
```bash
|
|
function update_script() {
|
|
header_info
|
|
check_container_storage
|
|
check_container_resources
|
|
|
|
# Use tools.func helpers:
|
|
check_for_gh_release "myapp" "owner/repo"
|
|
fetch_and_deploy_gh_release "myapp" "owner/repo" "tarball" "latest" "/opt/myapp"
|
|
}
|
|
```
|
|
|
|
---
|
|
|
|
## Key Patterns
|
|
|
|
### Check for Updates (App Repository)
|
|
|
|
Use `check_for_gh_release` with the **app repo**:
|
|
|
|
```bash
|
|
check_for_gh_release "myapp" "owner/repo"
|
|
```
|
|
|
|
### Deploy External App
|
|
|
|
Use `fetch_and_deploy_gh_release` with the **app repo**:
|
|
|
|
```bash
|
|
fetch_and_deploy_gh_release "myapp" "owner/repo"
|
|
```
|
|
|
|
### Avoid Manual Version Checking
|
|
|
|
❌ OLD (manual):
|
|
|
|
```bash
|
|
RELEASE=$(curl -fsSL https://api.github.com/repos/myapp/myapp/releases/latest | grep tag_name)
|
|
```
|
|
|
|
✅ NEW (use tools.func):
|
|
|
|
```bash
|
|
fetch_and_deploy_gh_release "myapp" "owner/repo"
|
|
```
|
|
|
|
---
|
|
|
|
## Best Practices
|
|
|
|
1. **Use tools.func helpers** - Don't manually curl for versions
|
|
2. **Only add app-specific dependencies** - Don't add ca-certificates, curl, gnupg (handled by build.func)
|
|
3. **Test via curl from your fork** - Push first, then: `bash -c "$(curl -fsSL https://raw.githubusercontent.com/YOUR_USERNAME/ProxmoxVE/main/ct/MyApp.sh)"`
|
|
4. **Wait for GitHub to update** - Takes 10-30 seconds after git push
|
|
5. **Cherry-pick only YOUR files** - Submit only ct/MyApp.sh, install/MyApp-install.sh, frontend/public/json/myapp.json (3 files)
|
|
6. **Verify before PR** - Run `git diff upstream/main --name-only` to confirm only your files changed
|
|
|
|
---
|
|
|
|
## Common Update Patterns
|
|
|
|
See the [modern template](AppName.sh) and [AI.md](../AI.md) for complete working examples.
|
|
|
|
Recent reference scripts with good update functions:
|
|
|
|
- [Trip](https://github.com/community-scripts/ProxmoxVE/blob/main/ct/trip.sh)
|
|
- [Thingsboard](https://github.com/community-scripts/ProxmoxVE/blob/main/ct/thingsboard.sh)
|
|
- [UniFi](https://github.com/community-scripts/ProxmoxVE/blob/main/ct/unifi.sh)
|
|
|
|
---
|
|
|
|
## Need Help?
|
|
|
|
- **[README.md](../README.md)** - Full contribution workflow
|
|
- **[AI.md](../AI.md)** - AI-generated script guidelines
|
|
- **[FORK_SETUP.md](../FORK_SETUP.md)** - Why setup-fork.sh is important
|
|
- **[Slack Community](https://discord.gg/your-link)** - Ask questions
|
|
|
|
````
|
|
|
|
### 3.4 **Verbosity**
|
|
|
|
- Use the appropriate flag (**-q** in the examples) for a command to suppress its output.
|
|
Example:
|
|
|
|
```bash
|
|
curl -fsSL
|
|
unzip -q
|
|
````
|
|
|
|
- If a command does not come with this functionality use `$STD` to suppress it's output.
|
|
|
|
Example:
|
|
|
|
```bash
|
|
$STD php artisan migrate --force
|
|
$STD php artisan config:clear
|
|
```
|
|
|
|
### 3.5 **Backups**
|
|
|
|
- Backup user data if necessary.
|
|
- Move all user data back in the directory when the update is finished.
|
|
|
|
> [!NOTE]
|
|
> This is not meant to be a permanent backup
|
|
|
|
Example backup:
|
|
|
|
```bash
|
|
mv /opt/snipe-it /opt/snipe-it-backup
|
|
```
|
|
|
|
Example config restore:
|
|
|
|
```bash
|
|
cp /opt/snipe-it-backup/.env /opt/snipe-it/.env
|
|
cp -r /opt/snipe-it-backup/public/uploads/ /opt/snipe-it/public/uploads/
|
|
cp -r /opt/snipe-it-backup/storage/private_uploads /opt/snipe-it/storage/private_uploads
|
|
```
|
|
|
|
### 3.6 **Cleanup**
|
|
|
|
- Do not forget to remove any temporary files/folders such as zip-files or temporary backups.
|
|
Example:
|
|
|
|
```bash
|
|
rm -rf /opt/v${RELEASE}.zip
|
|
rm -rf /opt/snipe-it-backup
|
|
```
|
|
|
|
### 3.7 **No update function**
|
|
|
|
- In case you can not provide an update function use the following code to provide user feedback.
|
|
|
|
```bash
|
|
function update_script() {
|
|
header_info
|
|
check_container_storage
|
|
check_container_resources
|
|
if [[ ! -d /opt/snipeit ]]; then
|
|
msg_error "No ${APP} Installation Found!"
|
|
exit
|
|
fi
|
|
msg_error "Currently we don't provide an update function for this ${APP}."
|
|
exit
|
|
}
|
|
```
|
|
|
|
---
|
|
|
|
## 4 **End of the script**
|
|
|
|
- `start`: Launches Whiptail dialogue
|
|
- `build_container`: Collects and integrates user settings
|
|
- `description`: Sets LXC container description
|
|
- With `echo -e "${TAB}${GATEWAY}${BGN}http://${IP}${CL}"` you can point the user to the IP:PORT/folder needed to access the app.
|
|
|
|
```bash
|
|
start
|
|
build_container
|
|
description
|
|
|
|
msg_ok "Completed successfully!\n"
|
|
echo -e "${CREATING}${GN}${APP} setup has been successfully initialized!${CL}"
|
|
echo -e "${INFO}${YW} Access it using the following URL:${CL}"
|
|
echo -e "${TAB}${GATEWAY}${BGN}http://${IP}${CL}"
|
|
```
|
|
|
|
---
|
|
|
|
## 5. **Contribution checklist**
|
|
|
|
- [ ] Shebang is correctly set (`#!/usr/bin/env bash`).
|
|
- [ ] Correct link to _build.func_
|
|
- [ ] Metadata (author, license) is included at the top.
|
|
- [ ] Variables follow naming conventions.
|
|
- [ ] Update function exists.
|
|
- [ ] Update functions checks if app is installed and for new version.
|
|
- [ ] Update function cleans up temporary files.
|
|
- [ ] Script ends with a helpful message for the user to reach the application.
|