fix(vm): fix LVM/LVM-thin storage and error reporting for all VM scripts

- Add catch-all (*) case to storage type detection in all VM scripts that were missing it (debian-vm, debian-13-vm, ubuntu2204/2404/2504, nextcloud-vm, owncloud-vm, opnsense-vm, pimox-haos-vm) - Add catch-all to mikrotik-routeros (had zfspool but not lvm/lvmthin) - Fix error_handler in ALL 14 VM scripts to send numeric exit_code to post_update_to_api instead of bash command text, which caused 'Unknown error' in telemetry because the API expects a number
fix(archlinux-vm): fix LVM/LVM-thin storage and improve error reporting
2026-02-13 08:43:25 +01:00 · 2026-02-12 17:12:48 +01:00 · 2026-02-12 17:04:39 +01:00
12 changed files with 44 additions and 148 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -401,48 +401,26 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit

 </details>

-## 2026-02-13
-
-### 🚀 Updated Scripts
-
-  - #### 🐞 Bug Fixes
-
-    - [Hotfix] Jotty: Copy contents of config backup into /opt/jotty/config [@vhsdream](https://github.com/vhsdream) ([#11864](https://github.com/community-scripts/ProxmoxVE/pull/11864))
-
 ## 2026-02-12

 ### 🚀 Updated Scripts

  - #### 🐞 Bug Fixes

-    - EMQX: increase disk to 6GB and add optional MQ disable prompt [@MickLesk](https://github.com/MickLesk) ([#11844](https://github.com/community-scripts/ProxmoxVE/pull/11844))
-    - Increased the Grafana container default disk size. [@shtefko](https://github.com/shtefko) ([#11840](https://github.com/community-scripts/ProxmoxVE/pull/11840))
-    - Pangolin: Update database generation command in install script [@tremor021](https://github.com/tremor021) ([#11825](https://github.com/community-scripts/ProxmoxVE/pull/11825))
    - Deluge: add python3-setuptools as dep [@MickLesk](https://github.com/MickLesk) ([#11833](https://github.com/community-scripts/ProxmoxVE/pull/11833))
    - Dispatcharr: migrate to uv sync [@MickLesk](https://github.com/MickLesk) ([#11831](https://github.com/community-scripts/ProxmoxVE/pull/11831))
+    - Pangolin: Update database generation command in install script [@tremor021](https://github.com/tremor021) ([#11825](https://github.com/community-scripts/ProxmoxVE/pull/11825))

  - #### ✨ New Features

-    - Archlinux-VM: fix LVM/LVM-thin storage and improve error reporting | VM's add correct exit_code for analytics [@MickLesk](https://github.com/MickLesk) ([#11842](https://github.com/community-scripts/ProxmoxVE/pull/11842))
    - Debian13-VM: Optimize First Boot & add noCloud/Cloud Selection [@MickLesk](https://github.com/MickLesk) ([#11810](https://github.com/community-scripts/ProxmoxVE/pull/11810))

 ### 💾 Core

  - #### ✨ New Features

-    - tools.func: auto-detect binary vs armored GPG keys in setup_deb822_repo [@MickLesk](https://github.com/MickLesk) ([#11841](https://github.com/community-scripts/ProxmoxVE/pull/11841))
    - core: remove old Go API and extend misc/api.func with new backend [@MickLesk](https://github.com/MickLesk) ([#11822](https://github.com/community-scripts/ProxmoxVE/pull/11822))

-  - #### 🔧 Refactor
-
-    - error_handler: prevent stuck 'installing' status [@MickLesk](https://github.com/MickLesk) ([#11845](https://github.com/community-scripts/ProxmoxVE/pull/11845))
-
-### 🧰 Tools
-
-  - #### 🐞 Bug Fixes
-
-    - Tailscale: fix DNS check and keyrings directory issues [@MickLesk](https://github.com/MickLesk) ([#11837](https://github.com/community-scripts/ProxmoxVE/pull/11837))
-
 ## 2026-02-11

 ### 🆕 New Scripts
--- a/ct/alpine-grafana.sh
+++ b/ct/alpine-grafana.sh
@@ -9,7 +9,7 @@ APP="Alpine-Grafana"
 var_tags="${var_tags:-alpine;monitoring}"
 var_cpu="${var_cpu:-1}"
 var_ram="${var_ram:-256}"
-var_disk="${var_disk:-2}"
+var_disk="${var_disk:-1}"
 var_os="${var_os:-alpine}"
 var_version="${var_version:-3.23}"
 var_unprivileged="${var_unprivileged:-1}"
--- a/ct/emqx.sh
+++ b/ct/emqx.sh
@@ -9,7 +9,7 @@ APP="EMQX"
 var_tags="${var_tags:-mqtt}"
 var_cpu="${var_cpu:-2}"
 var_ram="${var_ram:-1024}"
-var_disk="${var_disk:-6}"
+var_disk="${var_disk:-4}"
 var_os="${var_os:-debian}"
 var_version="${var_version:-13}"
 var_unprivileged="${var_unprivileged:-1}"
--- a/ct/grafana.sh
+++ b/ct/grafana.sh
@@ -9,7 +9,7 @@ APP="Grafana"
 var_tags="${var_tags:-monitoring;visualization}"
 var_cpu="${var_cpu:-1}"
 var_ram="${var_ram:-512}"
-var_disk="${var_disk:-4}"
+var_disk="${var_disk:-2}"
 var_os="${var_os:-debian}"
 var_version="${var_version:-13}"
 var_unprivileged="${var_unprivileged:-1}"
--- a/ct/jotty.sh
+++ b/ct/jotty.sh
@@ -46,7 +46,7 @@ function update_script() {
    msg_info "Restoring configuration & data"
    mv /opt/app.env /opt/jotty/.env
    [[ -d /opt/data ]] && mv /opt/data /opt/jotty/data
-    [[ -d /opt/jotty/config ]] && cp -a /opt/config/* /opt/jotty/config && rm -rf /opt/config
+    [[ -d /opt/jotty/config ]] && mv /opt/config/* /opt/jotty/config
    msg_ok "Restored configuration & data"

    msg_info "Starting Service"
--- a/frontend/public/json/emqx.json
+++ b/frontend/public/json/emqx.json
@@ -21,7 +21,7 @@
      "resources": {
        "cpu": 2,
        "ram": 1024,
-        "hdd": 6,
+        "hdd": 4,
        "os": "debian",
        "version": "13"
      }
--- a/frontend/public/json/github-versions.json
+++ b/frontend/public/json/github-versions.json
@@ -1,5 +1,5 @@
 {
-  "generated": "2026-02-13T06:23:00Z",
+  "generated": "2026-02-12T12:15:15Z",
  "versions": [
    {
      "slug": "2fauth",
@@ -193,9 +193,9 @@
    {
      "slug": "cleanuparr",
      "repo": "Cleanuparr/Cleanuparr",
-      "version": "v2.6.0",
+      "version": "v2.5.1",
      "pinned": false,
-      "date": "2026-02-13T00:14:21Z"
+      "date": "2026-01-11T00:46:17Z"
    },
    {
      "slug": "cloudreve",
@@ -298,9 +298,9 @@
    {
      "slug": "donetick",
      "repo": "donetick/donetick",
-      "version": "v0.1.73",
+      "version": "v0.1.71",
      "pinned": false,
-      "date": "2026-02-12T23:42:30Z"
+      "date": "2026-02-11T06:01:13Z"
    },
    {
      "slug": "drawio",
@@ -403,9 +403,9 @@
    {
      "slug": "ghostfolio",
      "repo": "ghostfolio/ghostfolio",
-      "version": "2.238.0",
+      "version": "2.237.0",
      "pinned": false,
-      "date": "2026-02-12T18:28:55Z"
+      "date": "2026-02-08T13:59:53Z"
    },
    {
      "slug": "gitea",
@@ -543,9 +543,9 @@
    {
      "slug": "huntarr",
      "repo": "plexguide/Huntarr.io",
-      "version": "9.2.4.1",
+      "version": "9.2.4",
      "pinned": false,
-      "date": "2026-02-12T22:17:47Z"
+      "date": "2026-02-12T08:31:23Z"
    },
    {
      "slug": "immich-public-proxy",
@@ -571,16 +571,16 @@
    {
      "slug": "invoiceninja",
      "repo": "invoiceninja/invoiceninja",
-      "version": "v5.12.59",
+      "version": "v5.12.57",
      "pinned": false,
-      "date": "2026-02-13T02:26:13Z"
+      "date": "2026-02-11T23:08:56Z"
    },
    {
      "slug": "jackett",
      "repo": "Jackett/Jackett",
-      "version": "v0.24.1103",
+      "version": "v0.24.1098",
      "pinned": false,
-      "date": "2026-02-13T05:53:23Z"
+      "date": "2026-02-12T05:56:25Z"
    },
    {
      "slug": "jellystat",
@@ -823,9 +823,9 @@
    {
      "slug": "metube",
      "repo": "alexta69/metube",
-      "version": "2026.02.12",
+      "version": "2026.02.08",
      "pinned": false,
-      "date": "2026-02-12T21:05:49Z"
+      "date": "2026-02-08T17:01:37Z"
    },
    {
      "slug": "miniflux",
@@ -998,9 +998,9 @@
    {
      "slug": "pangolin",
      "repo": "fosrl/pangolin",
-      "version": "1.15.4",
+      "version": "1.15.3",
      "pinned": false,
-      "date": "2026-02-13T00:54:02Z"
+      "date": "2026-02-12T06:10:19Z"
    },
    {
      "slug": "paperless-ai",
@@ -1292,9 +1292,9 @@
    {
      "slug": "scraparr",
      "repo": "thecfu/scraparr",
-      "version": "v3.0.3",
+      "version": "v3.0.1",
      "pinned": false,
-      "date": "2026-02-12T14:20:56Z"
+      "date": "2026-02-11T17:42:23Z"
    },
    {
      "slug": "seelf",
@@ -1432,9 +1432,9 @@
    {
      "slug": "termix",
      "repo": "Termix-SSH/Termix",
-      "version": "release-1.11.1-tag",
+      "version": "release-1.11.0-tag",
      "pinned": false,
-      "date": "2026-02-13T04:49:16Z"
+      "date": "2026-01-25T02:09:52Z"
    },
    {
      "slug": "the-lounge",
@@ -1460,9 +1460,9 @@
    {
      "slug": "tianji",
      "repo": "msgbyte/tianji",
-      "version": "v1.31.12",
+      "version": "v1.31.10",
      "pinned": false,
-      "date": "2026-02-12T19:06:14Z"
+      "date": "2026-02-04T17:21:04Z"
    },
    {
      "slug": "traccar",
@@ -1551,9 +1551,9 @@
    {
      "slug": "upsnap",
      "repo": "seriousm4x/UpSnap",
-      "version": "5.2.8",
+      "version": "5.2.7",
      "pinned": false,
-      "date": "2026-02-13T00:02:37Z"
+      "date": "2026-01-07T23:48:00Z"
    },
    {
      "slug": "uptimekuma",
--- a/frontend/public/json/grafana.json
+++ b/frontend/public/json/grafana.json
@@ -21,7 +21,7 @@
            "resources": {
                "cpu": 1,
                "ram": 512,
-                "hdd": 4,
+                "hdd": 2,
                "os": "debian",
                "version": "13"
            }
@@ -32,7 +32,7 @@
            "resources": {
                "cpu": 1,
                "ram": 256,
-                "hdd": 2,
+                "hdd": 1,
                "os": "alpine",
                "version": "3.23"
            }
--- a/install/emqx-install.sh
+++ b/install/emqx-install.sh
@@ -38,18 +38,6 @@ rm -f "$DEB_FILE"
 echo "$LATEST_VERSION" >~/.emqx
 msg_ok "Installed EMQX"

-read -r -p "${TAB3}Would you like to disable the EMQX MQ feature? (reduces disk/CPU usage) <y/N> " prompt
-if [[ ${prompt,,} =~ ^(y|yes)$ ]]; then
-  msg_info "Disabling EMQX MQ feature"
-  mkdir -p /etc/emqx
-  if ! grep -q "^mq.enable" /etc/emqx/emqx.conf 2>/dev/null; then
-    echo "mq.enable = false" >>/etc/emqx/emqx.conf
-  else
-    sed -i 's/^mq.enable.*/mq.enable = false/' /etc/emqx/emqx.conf
-  fi
-  msg_ok "Disabled EMQX MQ feature"
-fi
-
 msg_info "Starting EMQX service"
 $STD systemctl enable -q --now emqx
 msg_ok "Enabled EMQX service"
--- a/misc/error_handler.func
+++ b/misc/error_handler.func
@@ -243,18 +243,6 @@ error_handler() {
 # ------------------------------------------------------------------------------
 on_exit() {
  local exit_code=$?
-  # Report orphaned "installing" records to telemetry API
-  # Catches ALL exit paths: errors (non-zero), signals, AND clean exits where
-  # post_to_api was called ("installing" sent) but post_update_to_api was never called
-  if [[ "${POST_TO_API_DONE:-}" == "true" && "${POST_UPDATE_DONE:-}" != "true" ]]; then
-    if declare -f post_update_to_api >/dev/null 2>&1; then
-      if [[ $exit_code -ne 0 ]]; then
-        post_update_to_api "failed" "$exit_code"
-      else
-        post_update_to_api "failed" "1"
-      fi
-    fi
-  fi
  [[ -n "${lockfile:-}" && -e "$lockfile" ]] && rm -f "$lockfile"
  exit "$exit_code"
 }
@@ -267,10 +255,6 @@ on_exit() {
 # - Exits with code 130 (128 + SIGINT=2)
 # ------------------------------------------------------------------------------
 on_interrupt() {
-  # Report interruption to telemetry API (prevents stuck "installing" records)
-  if declare -f post_update_to_api >/dev/null 2>&1; then
-    post_update_to_api "failed" "130"
-  fi
  if declare -f msg_error >/dev/null 2>&1; then
    msg_error "Interrupted by user (SIGINT)"
  else
@@ -288,10 +272,6 @@ on_interrupt() {
 # - Triggered by external process termination
 # ------------------------------------------------------------------------------
 on_terminate() {
-  # Report termination to telemetry API (prevents stuck "installing" records)
-  if declare -f post_update_to_api >/dev/null 2>&1; then
-    post_update_to_api "failed" "143"
-  fi
  if declare -f msg_error >/dev/null 2>&1; then
    msg_error "Terminated by signal (SIGTERM)"
  else
--- a/misc/tools.func
+++ b/misc/tools.func
@@ -465,7 +465,6 @@ manage_tool_repository() {
      msg_error "Failed to download MongoDB GPG key"
      return 1
    fi
-    chmod 644 "/etc/apt/keyrings/mongodb-server-${version}.gpg"

    # Setup repository
    local distro_codename
@@ -1295,33 +1294,12 @@ setup_deb822_repo() {
    return 1
  }

-  # Import GPG key (auto-detect binary vs ASCII-armored format)
-  local tmp_gpg
-  tmp_gpg=$(mktemp) || return 1
-  curl -fsSL "$gpg_url" -o "$tmp_gpg" || {
-    msg_error "Failed to download GPG key for ${name}"
-    rm -f "$tmp_gpg"
+  # Import GPG
+  curl -fsSL "$gpg_url" | gpg --dearmor --yes -o "/etc/apt/keyrings/${name}.gpg" || {
+    msg_error "Failed to import GPG key for ${name}"
    return 1
  }

-  if grep -q "BEGIN PGP" "$tmp_gpg" 2>/dev/null; then
-    # ASCII-armored — dearmor to binary
-    gpg --dearmor --yes -o "/etc/apt/keyrings/${name}.gpg" < "$tmp_gpg" || {
-      msg_error "Failed to dearmor GPG key for ${name}"
-      rm -f "$tmp_gpg"
-      return 1
-    }
-  else
-    # Already in binary GPG format — copy directly
-    cp "$tmp_gpg" "/etc/apt/keyrings/${name}.gpg" || {
-      msg_error "Failed to install GPG key for ${name}"
-      rm -f "$tmp_gpg"
-      return 1
-    }
-  fi
-  rm -f "$tmp_gpg"
-  chmod 644 "/etc/apt/keyrings/${name}.gpg"
-
  # Write deb822
  {
    echo "Types: deb"
--- a/tools/addon/add-tailscale-lxc.sh
+++ b/tools/addon/add-tailscale-lxc.sh
@@ -75,37 +75,14 @@ pct exec "$CTID" -- bash -c '
 set -e
 export DEBIAN_FRONTEND=noninteractive

-# Source os-release properly (handles quoted values)
-source /etc/os-release
+ID=$(grep "^ID=" /etc/os-release | cut -d"=" -f2)
+VER=$(grep "^VERSION_CODENAME=" /etc/os-release | cut -d"=" -f2)

-# Fallback if DNS is poisoned or blocked
+# fallback if DNS is poisoned or blocked
 ORIG_RESOLV="/etc/resolv.conf"
 BACKUP_RESOLV="/tmp/resolv.conf.backup"

-# Check DNS resolution using multiple methods (dig may not be installed)
-dns_check_failed=true
-if command -v dig &>/dev/null; then
-  if dig +short pkgs.tailscale.com 2>/dev/null | grep -qvE "^127\.|^0\.0\.0\.0$|^$"; then
-    dns_check_failed=false
-  fi
-elif command -v host &>/dev/null; then
-  if host pkgs.tailscale.com 2>/dev/null | grep -q "has address"; then
-    dns_check_failed=false
-  fi
-elif command -v nslookup &>/dev/null; then
-  if nslookup pkgs.tailscale.com 2>/dev/null | grep -q "Address:"; then
-    dns_check_failed=false
-  fi
-elif command -v getent &>/dev/null; then
-  if getent hosts pkgs.tailscale.com &>/dev/null; then
-    dns_check_failed=false
-  fi
-else
-  # No DNS tools available, try curl directly and assume DNS works
-  dns_check_failed=false
-fi
-
-if $dns_check_failed; then
+if ! dig +short pkgs.tailscale.com | grep -qvE "^127\.|^0\.0\.0\.0$"; then
  echo "[INFO] DNS resolution for pkgs.tailscale.com failed (blocked or redirected)."
  echo "[INFO] Temporarily overriding /etc/resolv.conf with Cloudflare DNS (1.1.1.1)"
  cp "$ORIG_RESOLV" "$BACKUP_RESOLV"
@@ -115,22 +92,17 @@ fi
 if ! command -v curl &>/dev/null; then
  echo "[INFO] curl not found, installing..."
  apt-get update -qq
- apt update -qq
- apt install -y curl >/dev/null
+  apt-get install -y curl >/dev/null
 fi

-# Ensure keyrings directory exists
-mkdir -p /usr/share/keyrings
-
-curl -fsSL "https://pkgs.tailscale.com/stable/${ID}/${VERSION_CODENAME}.noarmor.gpg" \
+curl -fsSL https://pkgs.tailscale.com/stable/${ID}/${VER}.noarmor.gpg \
  | tee /usr/share/keyrings/tailscale-archive-keyring.gpg >/dev/null

-echo "deb [signed-by=/usr/share/keyrings/tailscale-archive-keyring.gpg] https://pkgs.tailscale.com/stable/${ID} ${VERSION_CODENAME} main" \
+echo "deb [signed-by=/usr/share/keyrings/tailscale-archive-keyring.gpg] https://pkgs.tailscale.com/stable/${ID} ${VER} main" \
  >/etc/apt/sources.list.d/tailscale.list

 apt-get update -qq
-apt update -qq
-apt install -y tailscale >/dev/null
+apt-get install -y tailscale >/dev/null

 if [[ -f /tmp/resolv.conf.backup ]]; then
  echo "[INFO] Restoring original /etc/resolv.conf"