fix(build): App Defaults force mode and prevent unbound variables

- load_vars_file() now supports force parameter to override existing variables
- App Defaults uses force=yes to properly apply saved user preferences
- Added safety check for SSH_KEYS_FILE in install_ssh_keys_into_ct()
- Initialize ENABLE_GPU, ENABLE_NESTING, ENABLE_KEYCTL, ENABLE_MKNOD, PROTECT_CT, CT_TIMEZONE in base_settings()
- Added fallback defaults in echo_default() to prevent unbound variable errors when advanced_settings is skipped

CHANGELOG.md

@@ -12,22 +12,12 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit
 
 ## 2025-12-15
 
-### 🚀 Updated Scripts
-
-  - #### 🔧 Refactor
-
-    - Refactor: Heimdall Dashboard [@tremor021](https://github.com/tremor021) ([#9959](https://github.com/community-scripts/ProxmoxVE/pull/9959))
-
 ### 💾 Core
 
   - #### 🐞 Bug Fixes
 
     - core: load app defaults before applying base_settings / fix composer cleanup after install/update [@MickLesk](https://github.com/MickLesk) ([#9965](https://github.com/community-scripts/ProxmoxVE/pull/9965))
 
-### 📚 Documentation
-
-  - README; add project statistics / formatting [@MickLesk](https://github.com/MickLesk) ([#9967](https://github.com/community-scripts/ProxmoxVE/pull/9967))
-
 ## 2025-12-14
 
 ### 🚀 Updated Scripts

README.md

@@ -30,8 +30,8 @@
 
   <br />
 
- **Simplify your Proxmox VE setup with community-driven automation scripts**  
- Originally created by tteck, now maintained and expanded by the community
+> **Simplify your Proxmox VE setup with community-driven automation scripts**  
+> Originally created by tteck, now maintained and expanded by the community
 
 </div>
 
@@ -239,34 +239,17 @@ This project is maintained by volunteers in memory of tteck. Your support helps
 
 ---
 
-## 📈 Project Statistics
-<p align="center">
-  <img
-    src="https://repobeats.axiom.co/api/embed/57edde03e00f88d739bdb5b844ff7d07dd079375.svg"
-    alt="Repobeats analytics"
-    width="650"
-  />
-</p>
+## 📈 Project Growth
 
-<p align="center">
+<div align="center">
   <a href="https://star-history.com/#community-scripts/ProxmoxVE&Date">
     <picture>
-      <source
-        media="(prefers-color-scheme: dark)"
-        srcset="https://api.star-history.com/svg?repos=community-scripts/ProxmoxVE&type=Date&theme=dark"
-      />
-      <source
-        media="(prefers-color-scheme: light)"
-        srcset="https://api.star-history.com/svg?repos=community-scripts/ProxmoxVE&type=Date"
-      />
-      <img
-        alt="Star History Chart"
-        src="https://api.star-history.com/svg?repos=community-scripts/ProxmoxVE&type=Date"
-        width="650"
-      />
+      <source media="(prefers-color-scheme: dark)" srcset="https://api.star-history.com/svg?repos=community-scripts/ProxmoxVE&type=Date&theme=dark" />
+      <source media="(prefers-color-scheme: light)" srcset="https://api.star-history.com/svg?repos=community-scripts/ProxmoxVE&type=Date" />
+      <img alt="Star History Chart" src="https://api.star-history.com/svg?repos=community-scripts/ProxmoxVE&type=Date" />
     </picture>
   </a>
-</p>
+</div>
 
 ---
 

ct/heimdall-dashboard.sh

@@ -11,7 +11,7 @@ var_cpu="${var_cpu:-1}"
 var_ram="${var_ram:-512}"
 var_disk="${var_disk:-2}"
 var_os="${var_os:-debian}"
-var_version="${var_version:-13}"
+var_version="${var_version:-12}"
 var_unprivileged="${var_unprivileged:-1}"
 
 header_info "$APP"
@@ -27,45 +27,45 @@ function update_script() {
     msg_error "No ${APP} Installation Found!"
     exit
   fi
-
-  if check_for_gh_release "Heimdall" "linuxserver/Heimdall"; then
+  RELEASE=$(curl -fsSL "https://api.github.com/repos/linuxserver/Heimdall/releases/latest" | awk '/tag_name/{print $4;exit}' FS='[""]')
+  if [[ "${RELEASE}" != "$(cat /opt/${APP}_version.txt)" ]] || [[ ! -f /opt/${APP}_version.txt ]]; then
     msg_info "Stopping Service"
     systemctl stop heimdall
     sleep 1
     msg_ok "Stopped Service"
-
     msg_info "Backing up Data"
     cp -R /opt/Heimdall/database database-backup
     cp -R /opt/Heimdall/public public-backup
     sleep 1
     msg_ok "Backed up Data"
-
-    setup_composer
-    fetch_and_deploy_gh_release "Heimdall" "linuxserver/Heimdall" "tarball"
-
-    msg_info "Updating Heimdall-Dashboard"
+    msg_info "Updating Heimdall Dashboard to ${RELEASE}"
+    curl -fsSL "https://github.com/linuxserver/Heimdall/archive/${RELEASE}.tar.gz" -o $(basename "https://github.com/linuxserver/Heimdall/archive/${RELEASE}.tar.gz")
+    tar xzf "${RELEASE}".tar.gz
+    VER=$(curl -fsSL https://api.github.com/repos/linuxserver/Heimdall/releases/latest | grep "tag_name" | awk '{print substr($2, 3, length($2)-4) }')
+    cp -R Heimdall-"${VER}"/* /opt/Heimdall
     cd /opt/Heimdall
+    $STD apt-get install -y composer
     export COMPOSER_ALLOW_SUPERUSER=1
     $STD composer dump-autoload
-    msg_ok "Updated Heimdall-Dashboard"
-
+    echo "${RELEASE}" >/opt/${APP}_version.txt
+    msg_ok "Updated Heimdall Dashboard to ${RELEASE}"
     msg_info "Restoring Data"
     cd ~
     cp -R database-backup/* /opt/Heimdall/database
     cp -R public-backup/* /opt/Heimdall/public
     sleep 1
     msg_ok "Restored Data"
-
-    msg_info "Cleaning Up"
-    rm -rf {public-backup,database-backup}
+    msg_info "Cleanup"
+    rm -rf {"${RELEASE}".tar.gz,Heimdall-"${VER}",public-backup,database-backup,Heimdall}
     sleep 1
-    msg_ok "Cleaned Up"
-
+    msg_ok "Cleaned"
     msg_info "Starting Service"
     systemctl start heimdall.service
     sleep 2
     msg_ok "Started Service"
     msg_ok "Updated successfully!"
+  else
+    msg_ok "No update required.  ${APP} is already at ${RELEASE}."
   fi
   exit
 }

frontend/public/json/heimdall-dashboard.json

@@ -23,7 +23,7 @@
         "ram": 512,
         "hdd": 2,
         "os": "debian",
-        "version": "13"
+        "version": "12"
       }
     }
   ],

install/heimdall-dashboard-install.sh

@@ -14,22 +14,27 @@ network_check
 update_os
 
 msg_info "Installing Dependencies"
-$STD apt install -y apt-transport-https
+$STD apt-get install -y apt-transport-https
+$STD apt-get install -y composer
+$STD apt-get install -y php8.2-{bz2,curl,sqlite3,zip,xml}
 msg_ok "Installed Dependencies"
 
-PHP_VERSION="8.4" PHP_MODULE="bz2,sqlite3" PHP_FPM="YES" setup_php
-setup_composer
-fetch_and_deploy_gh_release "Heimdall" "linuxserver/Heimdall" "tarball"
-
-msg_info "Setting up Heimdall-Dashboard"
+RELEASE=$(curl -fsSL "https://api.github.com/repos/linuxserver/Heimdall/releases/latest" | awk '/tag_name/{print $4;exit}' FS='[""]')
+echo "${RELEASE}" >/opt/"${APPLICATION}"_version.txt
+msg_info "Installing Heimdall Dashboard ${RELEASE}"
+curl -fsSL "https://github.com/linuxserver/Heimdall/archive/${RELEASE}.tar.gz" -o "${RELEASE}".tar.gz
+tar xzf "${RELEASE}".tar.gz
+VER=$(curl -fsSL https://api.github.com/repos/linuxserver/Heimdall/releases/latest | grep "tag_name" | awk '{print substr($2, 3, length($2)-4) }')
+rm -rf "${RELEASE}".tar.gz
+mv Heimdall-"${VER}" /opt/Heimdall
 cd /opt/Heimdall
 cp .env.example .env
 $STD php artisan key:generate
-msg_ok "Setup Heimdall-Dashboard"
+msg_ok "Installed Heimdall Dashboard ${RELEASE}"
 
 msg_info "Creating Service"
-cat <<EOF >/etc/systemd/system/heimdall.service
-[Unit]
+service_path="/etc/systemd/system/heimdall.service"
+echo "[Unit]
 Description=Heimdall
 After=network.target
 
@@ -39,16 +44,14 @@ RestartSec=5
 Type=simple
 User=root
 WorkingDirectory=/opt/Heimdall
-ExecStart=/usr/bin/php artisan serve --port 7990 --host 0.0.0.0
+ExecStart="/usr/bin/php" artisan serve --port 7990 --host 0.0.0.0
 TimeoutStopSec=30
 
 [Install]
-WantedBy=multi-user.target"
-EOF
+WantedBy=multi-user.target" >$service_path
 systemctl enable -q --now heimdall
 cd /opt/Heimdall
-export COMPOSER_ALLOW_SUPERUSER=1
-$STD composer dump-autoload
+COMPOSER_ALLOW_SUPERUSER=1 composer dump-autoload &>/dev/null
 systemctl restart heimdall.service
 msg_ok "Created Service"
 

misc/build.func

@@ -205,7 +205,10 @@ update_motd_ip() {
 # - Falls back to warning if no keys provided
 # ------------------------------------------------------------------------------
 install_ssh_keys_into_ct() {
-  [[ "$SSH" != "yes" ]] && return 0
+  [[ "${SSH:-no}" != "yes" ]] && return 0
+
+  # Ensure SSH_KEYS_FILE is defined (may not be set if advanced_settings was skipped)
+  : "${SSH_KEYS_FILE:=}"
 
   if [[ -n "$SSH_KEYS_FILE" && -s "$SSH_KEYS_FILE" ]]; then
     msg_info "Installing selected SSH keys into CT ${CTID}"
@@ -430,6 +433,14 @@ base_settings() {
   ENABLE_FUSE=${var_fuse:-"${1:-no}"}
   ENABLE_TUN=${var_tun:-"${1:-no}"}
 
+  # Additional settings that may be skipped if advanced_settings is not run (e.g., App Defaults)
+  ENABLE_GPU=${var_gpu:-"no"}
+  ENABLE_NESTING=${var_nesting:-"1"}
+  ENABLE_KEYCTL=${var_keyctl:-"0"}
+  ENABLE_MKNOD=${var_mknod:-"0"}
+  PROTECT_CT=${var_protection:-"no"}
+  CT_TIMEZONE=${var_timezone:-"$timezone"}
+
   # Since these 2 are only defined outside of default_settings function, we add a temporary fallback. TODO: To align everything, we should add these as constant variables (e.g. OSTYPE and OSVERSION), but that would currently require updating the default_settings function for all existing scripts
   if [ -z "$var_os" ]; then
     var_os="debian"
@@ -1898,13 +1909,13 @@ Advanced:
   echo -e "${BRIDGE}${BOLD}${DGN}Bridge: ${BGN}$BRG${CL}"
   echo -e "${NETWORK}${BOLD}${DGN}IPv4: ${BGN}$NET${CL}"
   echo -e "${NETWORK}${BOLD}${DGN}IPv6: ${BGN}$IPV6_METHOD${CL}"
-  echo -e "${FUSE}${BOLD}${DGN}FUSE Support: ${BGN}$ENABLE_FUSE${CL}"
-  [[ "$ENABLE_TUN" == "yes" ]] && echo -e "${NETWORK}${BOLD}${DGN}TUN/TAP Support: ${BGN}$ENABLE_TUN${CL}"
-  echo -e "${CONTAINERTYPE}${BOLD}${DGN}Nesting: ${BGN}$([ "$ENABLE_NESTING" == "1" ] && echo "Enabled" || echo "Disabled")${CL}"
-  [[ "$ENABLE_KEYCTL" == "1" ]] && echo -e "${CONTAINERTYPE}${BOLD}${DGN}Keyctl: ${BGN}Enabled${CL}"
-  echo -e "${GPU}${BOLD}${DGN}GPU Passthrough: ${BGN}$ENABLE_GPU${CL}"
-  [[ "$PROTECT_CT" == "yes" || "$PROTECT_CT" == "1" ]] && echo -e "${CONTAINERTYPE}${BOLD}${DGN}Protection: ${BGN}Enabled${CL}"
-  [[ -n "$CT_TIMEZONE" ]] && echo -e "${INFO}${BOLD}${DGN}Timezone: ${BGN}$CT_TIMEZONE${CL}"
+  echo -e "${FUSE}${BOLD}${DGN}FUSE Support: ${BGN}${ENABLE_FUSE:-no}${CL}"
+  [[ "${ENABLE_TUN:-no}" == "yes" ]] && echo -e "${NETWORK}${BOLD}${DGN}TUN/TAP Support: ${BGN}$ENABLE_TUN${CL}"
+  echo -e "${CONTAINERTYPE}${BOLD}${DGN}Nesting: ${BGN}$([ "${ENABLE_NESTING:-1}" == "1" ] && echo "Enabled" || echo "Disabled")${CL}"
+  [[ "${ENABLE_KEYCTL:-0}" == "1" ]] && echo -e "${CONTAINERTYPE}${BOLD}${DGN}Keyctl: ${BGN}Enabled${CL}"
+  echo -e "${GPU}${BOLD}${DGN}GPU Passthrough: ${BGN}${ENABLE_GPU:-no}${CL}"
+  [[ "${PROTECT_CT:-no}" == "yes" || "${PROTECT_CT:-no}" == "1" ]] && echo -e "${CONTAINERTYPE}${BOLD}${DGN}Protection: ${BGN}Enabled${CL}"
+  [[ -n "${CT_TIMEZONE:-}" ]] && echo -e "${INFO}${BOLD}${DGN}Timezone: ${BGN}$CT_TIMEZONE${CL}"
   [[ "$APT_CACHER" == "yes" ]] && echo -e "${INFO}${BOLD}${DGN}APT Cacher: ${BGN}$APT_CACHER_IP${CL}"
   echo -e "${SEARCH}${BOLD}${DGN}Verbose Mode: ${BGN}$VERBOSE${CL}"
   echo -e "${CREATING}${BOLD}${RD}Creating a ${APP} LXC using the above advanced settings${CL}"