fix: remove duplicate error handler from alpine-install.func

- Remove legacy error_handler(), on_exit(), on_interrupt(), on_terminate() and set/trap definitions from alpine-install.func (already provided by error_handler.func which is sourced on line 10)

- The local error_handler() expected positional args as required, but catch_errors() sets trap as 'error_handler' (without args), causing unbound variable error with set -u (nounset)

- error_handler.func uses default values which is set -u safe

- Also align legacy trap in install.func network_check() to standard format

Fixes #11929

misc/alpine-install.func

@@ -34,42 +34,6 @@ EOF
   fi
 }
 
-set -Eeuo pipefail
-trap 'error_handler $? $LINENO "$BASH_COMMAND"' ERR
-trap on_exit EXIT
-trap on_interrupt INT
-trap on_terminate TERM
-
-error_handler() {
-  local exit_code="$1"
-  local line_number="$2"
-  local command="$3"
-
-  if [[ "$exit_code" -eq 0 ]]; then
-    return 0
-  fi
-
-  printf "\e[?25h"
-  echo -e "\n${RD}[ERROR]${CL} in line ${RD}$line_number${CL}: exit code ${RD}$exit_code${CL}: while executing command ${YW}$command${CL}\n"
-  exit "$exit_code"
-}
-
-on_exit() {
-  local exit_code="$?"
-  [[ -n "${lockfile:-}" && -e "$lockfile" ]] && rm -f "$lockfile"
-  exit "$exit_code"
-}
-
-on_interrupt() {
-  echo -e "\n${RD}Interrupted by user (SIGINT)${CL}"
-  exit 130
-}
-
-on_terminate() {
-  echo -e "\n${RD}Terminated by signal (SIGTERM)${CL}"
-  exit 143
-}
-
 # This function sets up the Container OS by generating the locale, setting the timezone, and checking the network connection
 setting_up_container() {
   msg_info "Setting up Container OS"

misc/alpine-tools.func

@@ -34,19 +34,11 @@ net_resolves() {
 }
 
 ensure_usr_local_bin_persist() {
-  # Login shells: /etc/profile.d/
   local PROFILE_FILE="/etc/profile.d/10-localbin.sh"
   if [ ! -f "$PROFILE_FILE" ]; then
     echo 'case ":$PATH:" in *:/usr/local/bin:*) ;; *) export PATH="/usr/local/bin:$PATH";; esac' >"$PROFILE_FILE"
     chmod +x "$PROFILE_FILE"
   fi
-
-  # Non-login shells (pct enter): /root/.profile and /root/.bashrc
-  for rc_file in /root/.profile /root/.bashrc; do
-    if [ -f "$rc_file" ] && ! grep -q '/usr/local/bin' "$rc_file"; then
-      echo 'export PATH="/usr/local/bin:$PATH"' >>"$rc_file"
-    fi
-  done
 }
 
 download_with_progress() {

misc/install.func

@@ -172,7 +172,7 @@ network_check() {
   fi
 
   set -e
-  trap 'error_handler $LINENO "$BASH_COMMAND"' ERR
+  trap 'error_handler' ERR
 }
 
 # ==============================================================================

misc/tools.func

@@ -1851,26 +1851,16 @@ function download_with_progress() {
 # Ensures /usr/local/bin is permanently in system PATH.
 #
 # Description:
-#   - Adds to /etc/profile.d for login shells (SSH, noVNC)
-#   - Adds to /root/.bashrc for non-login shells (pct enter)
+#   - Adds to /etc/profile.d if not present
 # ------------------------------------------------------------------------------
 
 function ensure_usr_local_bin_persist() {
-  # Skip on Proxmox host
-  command -v pveversion &>/dev/null && return
-
-  # Login shells: /etc/profile.d/
   local PROFILE_FILE="/etc/profile.d/custom_path.sh"
-  if [[ ! -f "$PROFILE_FILE" ]]; then
+
+  if [[ ! -f "$PROFILE_FILE" ]] && ! command -v pveversion &>/dev/null; then
     echo 'export PATH="/usr/local/bin:$PATH"' >"$PROFILE_FILE"
     chmod +x "$PROFILE_FILE"
   fi
-
-  # Non-login shells (pct enter): /root/.bashrc
-  local BASHRC="/root/.bashrc"
-  if [[ -f "$BASHRC" ]] && ! grep -q '/usr/local/bin' "$BASHRC"; then
-    echo 'export PATH="/usr/local/bin:$PATH"' >>"$BASHRC"
-  fi
 }
 
 # ------------------------------------------------------------------------------