Fix Zabbix 7.0 repository URL structure

- Zabbix 7.0 uses different repository layout without release/ directory - Package name includes version suffix for 7.0: zabbix-release_latest_7.0+debian13_all.deb - Zabbix 7.4+ uses release/ directory with no version suffix - Applied fix to both ct/zabbix.sh and install/zabbix-install.sh
2025-12-18 21:16:24 +01:00 · 2025-12-18 09:14:45 +01:00
9 changed files with 117 additions and 153 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@ -17,24 +17,6 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit
  - #### 🐞 Bug Fixes

    - [HOTFIX] Fix Scanopy release check [@vhsdream](https://github.com/vhsdream) ([#10097](https://github.com/community-scripts/ProxmoxVE/pull/10097))
-    - Fix cleanup issues in npm cache and rustup toolchain [@MickLesk](https://github.com/MickLesk) ([#10107](https://github.com/community-scripts/ProxmoxVE/pull/10107))
-    - Fix Zabbix 7.0 repository URL structure [@MickLesk](https://github.com/MickLesk) ([#10106](https://github.com/community-scripts/ProxmoxVE/pull/10106))
-
-  - #### ✨ New Features
-
-    - Immich: v2.4.0 [@vhsdream](https://github.com/vhsdream) ([#10095](https://github.com/community-scripts/ProxmoxVE/pull/10095))
-
-### 💾 Core
-
-  - #### 🔧 Refactor
-
-    - tools.func: hardening/Improve error handling and cleanup in shell functions [@MickLesk](https://github.com/MickLesk) ([#10116](https://github.com/community-scripts/ProxmoxVE/pull/10116))
-
-### 🧰 Tools
-
-  - #### 🐞 Bug Fixes
-
-    - Improved error handling when a command does not exist [@wolle604](https://github.com/wolle604) ([#10089](https://github.com/community-scripts/ProxmoxVE/pull/10089))

 ## 2025-12-17

--- a/ct/immich.sh
+++ b/ct/immich.sh
@ -74,28 +74,23 @@ EOF
  STAGING_DIR=/opt/staging
  BASE_DIR=${STAGING_DIR}/base-images
  SOURCE_DIR=${STAGING_DIR}/image-source
-  cd /tmp
+  cd /root
  if [[ -f ~/.intel_version ]]; then
-    curl -fsSLO https://raw.githubusercontent.com/immich-app/base-images/refs/heads/main/server/Dockerfile
-    readarray -t INTEL_URLS < <(
-      sed -n "/intel-[igc|opencl]/p" ./Dockerfile | awk '{print $2}'
-      sed -n "/libigdgmm12/p" ./Dockerfile | awk '{print $3}'
-    )
-    INTEL_RELEASE="$(grep "intel-opencl-icd_" ./Dockerfile | awk -F '_' '{print $2}')"
+    curl -fsSLO https://raw.githubusercontent.com/immich-app/immich/refs/heads/main/machine-learning/Dockerfile
+    readarray -t INTEL_URLS < <(sed -n "/intel/p" ./Dockerfile | awk '{print $3}')
+    INTEL_RELEASE="$(grep "intel-opencl-icd" ./Dockerfile | awk -F '_' '{print $2}')"
    if [[ "$INTEL_RELEASE" != "$(cat ~/.intel_version)" ]]; then
      msg_info "Updating Intel iGPU dependencies"
      for url in "${INTEL_URLS[@]}"; do
        curl -fsSLO "$url"
      done
      $STD apt-mark unhold libigdgmm12
-      $STD apt install -y ./libigdgmm12*.deb
-      rm ./libigdgmm12*.deb
      $STD apt install -y ./*.deb
      rm ./*.deb
      $STD apt-mark hold libigdgmm12
      msg_ok "Intel iGPU dependencies updated"
    fi
-    rm ./Dockerfile
+    rm ~/Dockerfile
  fi
  if [[ -f ~/.immich_library_revisions ]]; then
    libraries=("libjxl" "libheif" "libraw" "imagemagick" "libvips")
@ -108,7 +103,7 @@ EOF
    msg_ok "Image-processing libraries up to date"
  fi

-  RELEASE="2.4.0"
+  RELEASE="2.3.1"
  if check_for_gh_release "immich" "immich-app/immich" "${RELEASE}"; then
    msg_info "Stopping Services"
    systemctl stop immich-web
--- a/ct/linkwarden.sh
+++ b/ct/linkwarden.sh
@ -52,7 +52,7 @@ function update_script() {
    $STD yarn web:build
    $STD yarn prisma:deploy
    [ -d /opt/data.bak ] && mv /opt/data.bak /opt/linkwarden/data
-    rm -rf ~/.cargo/registry ~/.cargo/git ~/.cargo/.package-cache
+    rm -rf ~/.cargo/registry ~/.cargo/git ~/.cargo/.package-cache ~/.rustup
    rm -rf /root/.cache/yarn
    rm -rf /opt/linkwarden/.next/cache
    msg_ok "Updated ${APP}"
--- a/frontend/public/json/versions.json
+++ b/frontend/public/json/versions.json
@ -1,88 +1,13 @@
 [
-  {
-    "name": "juanfont/headscale",
-    "version": "v0.27.1",
-    "date": "2025-11-11T19:32:29Z"
-  },
-  {
-    "name": "docker/compose",
-    "version": "v5.0.1",
-    "date": "2025-12-18T10:35:33Z"
-  },
-  {
-    "name": "tailscale/tailscale",
-    "version": "v1.92.4",
-    "date": "2025-12-18T10:32:44Z"
-  },
-  {
-    "name": "TuroYT/snowshare",
-    "version": "v1.2.3",
-    "date": "2025-12-18T10:06:45Z"
-  },
-  {
-    "name": "coollabsio/coolify",
-    "version": "v4.0.0-beta.456",
-    "date": "2025-12-18T08:59:27Z"
-  },
-  {
-    "name": "Kozea/Radicale",
-    "version": "v3.5.10",
-    "date": "2025-12-18T07:14:13Z"
-  },
-  {
-    "name": "zabbix/zabbix",
-    "version": "7.4.6",
-    "date": "2025-12-18T07:00:26Z"
-  },
-  {
-    "name": "Jackett/Jackett",
-    "version": "v0.24.478",
-    "date": "2025-12-18T05:55:21Z"
-  },
-  {
-    "name": "chrisvel/tududi",
-    "version": "v0.88.1",
-    "date": "2025-12-18T05:01:07Z"
-  },
-  {
-    "name": "comfyanonymous/ComfyUI",
-    "version": "v0.5.1",
-    "date": "2025-12-18T03:08:43Z"
-  },
-  {
-    "name": "scanopy/scanopy",
-    "version": "v0.12.3",
-    "date": "2025-12-18T02:48:06Z"
-  },
-  {
-    "name": "openobserve/openobserve",
-    "version": "v0.30.1",
-    "date": "2025-12-18T02:41:34Z"
-  },
-  {
-    "name": "chrisbenincasa/tunarr",
-    "version": "v1.0.6",
-    "date": "2025-12-18T01:28:04Z"
-  },
-  {
-    "name": "jeedom/core",
-    "version": "4.5.1",
-    "date": "2025-12-18T00:27:07Z"
-  },
-  {
-    "name": "steveiliop56/tinyauth",
-    "version": "v4.1.0",
-    "date": "2025-11-23T12:13:34Z"
-  },
-  {
-    "name": "goauthentik/authentik",
-    "version": "version/2025.10.3",
-    "date": "2025-12-16T18:00:53Z"
-  },
  {
    "name": "javedh-dev/tracktor",
    "version": "1.0.1",
-    "date": "2025-12-17T11:31:03Z"
+    "date": "2025-12-17T23:14:39Z"
+  },
+  {
+    "name": "goauthentik/authentik",
+    "version": "version/2025.12.0-rc2",
+    "date": "2025-12-17T22:03:04Z"
  },
  {
    "name": "ollama/ollama",
@ -114,11 +39,6 @@
    "version": "v4.107.0",
    "date": "2025-12-17T18:59:21Z"
  },
-  {
-    "name": "neo4j/neo4j",
-    "version": "5.26.19",
-    "date": "2025-12-17T18:17:55Z"
-  },
  {
    "name": "metabase/metabase",
    "version": "v0.57.7",
@ -135,9 +55,19 @@
    "date": "2025-12-17T17:43:28Z"
  },
  {
-    "name": "keycloak/keycloak",
-    "version": "26.4.7",
-    "date": "2025-12-01T08:14:11Z"
+    "name": "openobserve/openobserve",
+    "version": "v0.30.1",
+    "date": "2025-12-17T17:34:52Z"
+  },
+  {
+    "name": "comfyanonymous/ComfyUI",
+    "version": "v0.5.0",
+    "date": "2025-12-17T16:48:33Z"
+  },
+  {
+    "name": "scanopy/scanopy",
+    "version": "v0.12.2",
+    "date": "2025-12-17T16:01:43Z"
  },
  {
    "name": "semaphoreui/semaphore",
@ -154,6 +84,16 @@
    "version": "n8n@1.123.7",
    "date": "2025-12-17T14:01:25Z"
  },
+  {
+    "name": "zabbix/zabbix",
+    "version": "7.2.15",
+    "date": "2025-12-17T13:25:42Z"
+  },
+  {
+    "name": "chrisbenincasa/tunarr",
+    "version": "v1.0.5",
+    "date": "2025-12-17T12:48:30Z"
+  },
  {
    "name": "bunkerity/bunkerweb",
    "version": "testing",
@ -169,6 +109,16 @@
    "version": "v11.1.2",
    "date": "2025-12-17T09:26:24Z"
  },
+  {
+    "name": "coollabsio/coolify",
+    "version": "v4.0.0-beta.455",
+    "date": "2025-12-17T09:24:10Z"
+  },
+  {
+    "name": "TuroYT/snowshare",
+    "version": "v1.2.2",
+    "date": "2025-12-17T09:07:12Z"
+  },
  {
    "name": "zitadel/zitadel",
    "version": "v4.7.6",
@ -209,6 +159,11 @@
    "version": "v25.4",
    "date": "2025-10-09T10:27:01Z"
  },
+  {
+    "name": "Jackett/Jackett",
+    "version": "v0.24.468",
+    "date": "2025-12-17T05:55:30Z"
+  },
  {
    "name": "nickheyer/discopanel",
    "version": "v1.0.16",
@ -219,6 +174,16 @@
    "version": "v1.19.23",
    "date": "2025-12-17T00:51:11Z"
  },
+  {
+    "name": "jeedom/core",
+    "version": "4.5",
+    "date": "2025-12-17T00:27:05Z"
+  },
+  {
+    "name": "steveiliop56/tinyauth",
+    "version": "v4.1.0",
+    "date": "2025-11-23T12:13:34Z"
+  },
  {
    "name": "esphome/esphome",
    "version": "2025.12.0",
@ -234,6 +199,16 @@
    "version": "1.1.7",
    "date": "2025-12-16T21:44:58Z"
  },
+  {
+    "name": "tailscale/tailscale",
+    "version": "v1.92.3",
+    "date": "2025-12-16T21:19:10Z"
+  },
+  {
+    "name": "keycloak/keycloak",
+    "version": "26.4.7",
+    "date": "2025-12-01T08:14:11Z"
+  },
  {
    "name": "prometheus-pve/prometheus-pve-exporter",
    "version": "v3.7.0",
@ -474,6 +449,11 @@
    "version": "cli/v0.29.1",
    "date": "2025-12-13T13:55:51Z"
  },
+  {
+    "name": "chrisvel/tududi",
+    "version": "v0.88.0",
+    "date": "2025-12-13T09:36:24Z"
+  },
  {
    "name": "Dokploy/dokploy",
    "version": "v0.26.2",
@ -482,7 +462,7 @@
  {
    "name": "mealie-recipes/mealie",
    "version": "v3.7.0",
-    "date": "2025-12-13T01:20:58Z"
+    "date": "2025-12-13T01:21:07Z"
  },
  {
    "name": "paperless-ngx/paperless-ngx",
@ -834,6 +814,16 @@
    "version": "v6.2.4",
    "date": "2025-12-02T17:47:52Z"
  },
+  {
+    "name": "docker/compose",
+    "version": "v5.0.0",
+    "date": "2025-12-02T10:33:31Z"
+  },
+  {
+    "name": "neo4j/neo4j",
+    "version": "5.26.18",
+    "date": "2025-12-02T09:25:19Z"
+  },
  {
    "name": "syncthing/syncthing",
    "version": "v2.0.12",
@ -874,6 +864,11 @@
    "version": "v2.4.7",
    "date": "2025-11-30T20:59:51Z"
  },
+  {
+    "name": "juanfont/headscale",
+    "version": "v0.27.1",
+    "date": "2025-11-11T19:32:29Z"
+  },
  {
    "name": "hargata/lubelog",
    "version": "v1.5.5",
@ -899,6 +894,11 @@
    "version": "v25.9.0",
    "date": "2025-11-29T16:37:28Z"
  },
+  {
+    "name": "Kozea/Radicale",
+    "version": "v3.5.9",
+    "date": "2025-11-29T14:35:45Z"
+  },
  {
    "name": "authelia/authelia",
    "version": "v4.39.15",
--- a/install/immich-install.sh
+++ b/install/immich-install.sh
@ -99,15 +99,10 @@ if [[ ${prompt,,} =~ ^(y|yes)$ ]]; then
  $STD apt install -y --no-install-recommends patchelf
  tmp_dir=$(mktemp -d)
  $STD pushd "$tmp_dir"
-  curl -fsSLZ -O "https://github.com/intel/intel-graphics-compiler/releases/download/igc-1.0.17537.24/intel-igc-core_1.0.17537.24_amd64.deb" \
-    -O "https://github.com/intel/intel-graphics-compiler/releases/download/igc-1.0.17537.24/intel-igc-opencl_1.0.17537.24_amd64.deb" \
-    -O "https://github.com/intel/compute-runtime/releases/download/24.35.30872.36/intel-opencl-icd-legacy1_24.35.30872.36_amd64.deb" \
-    -O "https://github.com/intel/intel-graphics-compiler/releases/download/v2.22.2/intel-igc-core-2_2.22.2+20121_amd64.deb" \
-    -O "https://github.com/intel/intel-graphics-compiler/releases/download/v2.22.2/intel-igc-opencl-2_2.22.2+20121_amd64.deb" \
-    -O "https://github.com/intel/compute-runtime/releases/download/25.44.36015.5/intel-opencl-icd_25.44.36015.5-0_amd64.deb" \
-    -O "https://github.com/intel/compute-runtime/releases/download/25.44.36015.5/libigdgmm12_22.8.2_amd64.deb"
-  $STD apt install -y ./libigdgmm12*.deb
-  rm ./libigdgmm12*.deb
+  curl -fsSLO https://github.com/intel/intel-graphics-compiler/releases/download/igc-1.0.17384.11/intel-igc-core_1.0.17384.11_amd64.deb
+  curl -fsSLO https://github.com/intel/intel-graphics-compiler/releases/download/igc-1.0.17384.11/intel-igc-opencl_1.0.17384.11_amd64.deb
+  curl -fsSLO https://github.com/intel/compute-runtime/releases/download/24.31.30508.7/intel-opencl-icd_24.31.30508.7_amd64.deb
+  curl -fsSLO https://github.com/intel/compute-runtime/releases/download/24.31.30508.7/libigdgmm12_22.4.1_amd64.deb
  $STD apt install -y ./*.deb
  $STD apt-mark hold libigdgmm12
  $STD popd
@ -296,7 +291,7 @@ GEO_DIR="${INSTALL_DIR}/geodata"
 mkdir -p "$INSTALL_DIR"
 mkdir -p {"${APP_DIR}","${UPLOAD_DIR}","${GEO_DIR}","${INSTALL_DIR}"/cache}

-fetch_and_deploy_gh_release "immich" "immich-app/immich" "tarball" "v2.4.0" "$SRC_DIR"
+fetch_and_deploy_gh_release "immich" "immich-app/immich" "tarball" "v2.3.1" "$SRC_DIR"

 msg_info "Installing ${APPLICATION} (patience)"

--- a/install/linkwarden-install.sh
+++ b/install/linkwarden-install.sh
@ -62,7 +62,7 @@ EOF
 $STD yarn prisma:generate
 $STD yarn web:build
 $STD yarn prisma:deploy
-rm -rf ~/.cargo/registry ~/.cargo/git ~/.cargo/.package-cache
+rm -rf ~/.cargo/registry ~/.cargo/git ~/.cargo/.package-cache ~/.rustup
 rm -rf /root/.cache/yarn
 rm -rf /opt/linkwarden/.next/cache
 msg_ok "Installed Linkwarden"
--- a/misc/core.func
+++ b/misc/core.func
@ -815,11 +815,8 @@ cleanup_lxc() {
      xargs -0 -n1 truncate -s 0 2>/dev/null || true
  fi

-  # Node.js npm - directly remove cache directory
-  # npm cache clean/verify can fail with ENOTEMPTY errors, so we skip them
-  if command -v npm &>/dev/null; then
-    rm -rf /root/.npm/_cacache /root/.npm/_logs 2>/dev/null || true
-  fi
+  # Node.js npm
+  if command -v npm &>/dev/null; then $STD npm cache clean --force || true; fi
  # Node.js yarn
  if command -v yarn &>/dev/null; then $STD yarn cache clean || true; fi
  # Node.js pnpm
--- a/misc/tools.func
+++ b/misc/tools.func
@ -334,9 +334,9 @@ remove_old_tool_version() {
    $STD apt purge -y nodejs npm >/dev/null 2>&1 || true
    # Clean up npm global modules
    if command -v npm >/dev/null 2>&1; then
-      npm list -g 2>/dev/null | grep -oE '^  \S+' | awk '{print $1}' 2>/dev/null | while read -r module; do
+      npm list -g 2>/dev/null | grep -oE '^  \S+' | awk '{print $1}' | while read -r module; do
        npm uninstall -g "$module" >/dev/null 2>&1 || true
-      done || true
+      done
    fi
    cleanup_legacy_install "nodejs"
    cleanup_tool_keyrings "nodesource"
@ -1167,7 +1167,7 @@ cleanup_orphaned_sources() {

    # Extract Signed-By path from .sources file
    local keyring_path
-    keyring_path=$(grep -E '^Signed-By:' "$sources_file" 2>/dev/null | awk '{print $2}' 2>/dev/null || true)
+    keyring_path=$(grep -E '^Signed-By:' "$sources_file" 2>/dev/null | awk '{print $2}')

    # If keyring doesn't exist, remove the .sources file
    if [[ -n "$keyring_path" ]] && [[ ! -f "$keyring_path" ]]; then
@ -2073,7 +2073,7 @@ function setup_adminer() {
      return 1
    }
    local VERSION
-    VERSION=$(dpkg -s adminer 2>/dev/null | grep '^Version:' | awk '{print $2}' 2>/dev/null || echo 'unknown')
+    VERSION=$(dpkg -s adminer 2>/dev/null | grep '^Version:' | awk '{print $2}')
    cache_installed_version "adminer" "${VERSION:-unknown}"
    msg_ok "Setup Adminer (Debian/Ubuntu)"
  fi
@ -2591,7 +2591,7 @@ function setup_hwaccel() {

  # Detect CPU vendor (relevant for AMD APUs)
  local cpu_vendor
-  cpu_vendor=$(lscpu 2>/dev/null | grep -i 'Vendor ID' | awk '{print $3}' 2>/dev/null || echo "")
+  cpu_vendor=$(lscpu 2>/dev/null | grep -i 'Vendor ID' | awk '{print $3}' || echo "")

  if [[ -z "$gpu_vendor" && -z "$cpu_vendor" ]]; then
    msg_warn "No GPU or CPU vendor detected - skipping hardware acceleration setup"
@ -3699,7 +3699,7 @@ function setup_nodejs() {

      # Check if the module is already installed
      if $STD npm list -g --depth=0 "$MODULE_NAME" 2>&1 | grep -q "$MODULE_NAME@"; then
-        MODULE_INSTALLED_VERSION="$(npm list -g --depth=0 "$MODULE_NAME" 2>&1 | grep "$MODULE_NAME@" | awk -F@ '{print $2}' 2>/dev/null | tr -d '[:space:]' || echo '')"
+        MODULE_INSTALLED_VERSION="$($STD npm list -g --depth=0 "$MODULE_NAME" 2>&1 | grep "$MODULE_NAME@" | awk -F@ '{print $2}' | tr -d '[:space:]')"
        if [[ "$MODULE_REQ_VERSION" != "latest" && "$MODULE_REQ_VERSION" != "$MODULE_INSTALLED_VERSION" ]]; then
          msg_info "Updating $MODULE_NAME from v$MODULE_INSTALLED_VERSION to v$MODULE_REQ_VERSION"
          if ! $STD npm install -g "${MODULE_NAME}@${MODULE_REQ_VERSION}" 2>/dev/null; then
@ -3818,7 +3818,7 @@ EOF

  # Get available PHP version from repository
  local AVAILABLE_PHP_VERSION=""
-  AVAILABLE_PHP_VERSION=$(apt-cache show "php${PHP_VERSION}" 2>/dev/null | grep -m1 "^Version:" | awk '{print $2}' 2>/dev/null | cut -d- -f1 || true)
+  AVAILABLE_PHP_VERSION=$(apt-cache show "php${PHP_VERSION}" 2>/dev/null | grep -m1 "^Version:" | awk '{print $2}' | cut -d- -f1) || true

  if [[ -z "$AVAILABLE_PHP_VERSION" ]]; then
    msg_error "PHP ${PHP_VERSION} not found in configured repositories"
@ -4620,7 +4620,7 @@ function setup_rust() {

      # Check if already installed
      if echo "$CRATE_LIST" | grep -q "^${NAME} "; then
-        INSTALLED_VER=$(echo "$CRATE_LIST" | grep "^${NAME} " | head -1 | awk '{print $2}' 2>/dev/null | tr -d 'v:' || echo '')
+        INSTALLED_VER=$(echo "$CRATE_LIST" | grep "^${NAME} " | head -1 | awk '{print $2}' | tr -d 'v:')

        if [[ -n "$VER" && "$VER" != "$INSTALLED_VER" ]]; then
          msg_info "Upgrading $NAME from v$INSTALLED_VER to v$VER"
@ -4635,7 +4635,7 @@ function setup_rust() {
            msg_error "Failed to upgrade $NAME"
            return 1
          }
-          local NEW_VER=$(cargo install --list 2>/dev/null | grep "^${NAME} " | head -1 | awk '{print $2}' 2>/dev/null | tr -d 'v:' || echo 'unknown')
+          local NEW_VER=$(cargo install --list 2>/dev/null | grep "^${NAME} " | head -1 | awk '{print $2}' | tr -d 'v:')
          msg_ok "Upgraded $NAME to v$NEW_VER"
        else
          msg_ok "$NAME v$INSTALLED_VER already installed"
@ -4653,7 +4653,7 @@ function setup_rust() {
            msg_error "Failed to install $NAME"
            return 1
          }
-          local NEW_VER=$(cargo install --list 2>/dev/null | grep "^${NAME} " | head -1 | awk '{print $2}' 2>/dev/null | tr -d 'v:' || echo 'unknown')
+          local NEW_VER=$(cargo install --list 2>/dev/null | grep "^${NAME} " | head -1 | awk '{print $2}' | tr -d 'v:')
          msg_ok "Installed $NAME v$NEW_VER"
        fi
      fi
@ -4975,7 +4975,7 @@ function setup_docker() {
  # Install or upgrade Docker
  if [ "$docker_installed" = true ]; then
    msg_info "Checking for Docker updates"
-    DOCKER_LATEST_VERSION=$(apt-cache policy docker-ce | grep Candidate | awk '{print $2}' 2>/dev/null | cut -d':' -f2 | cut -d'-' -f1 || echo '')
+    DOCKER_LATEST_VERSION=$(apt-cache policy docker-ce | grep Candidate | awk '{print $2}' | cut -d':' -f2 | cut -d'-' -f1)

    if [ "$DOCKER_CURRENT_VERSION" != "$DOCKER_LATEST_VERSION" ]; then
      msg_info "Updating Docker $DOCKER_CURRENT_VERSION → $DOCKER_LATEST_VERSION"
--- a/tools/pve/execute.sh
+++ b/tools/pve/execute.sh
@ -50,12 +50,7 @@ function execute_in() {
  container=$1
  name=$(pct exec "$container" hostname)
  echo -e "${BL}[Info]${GN} Execute inside${BL} ${name}${GN} with output: ${CL}"
-    if !   pct exec "$container" -- bash -c "command -v ${custom_command} >/dev/null 2>&1"
-      then
-        echo -e "${BL}[Info]${GN} Skipping ${name} ${RD}$container has no command: ${custom_command}"
-      else
-        pct exec "$container" -- bash -c "${custom_command}" | tee
-    fi
+  pct exec "$container" -- bash -c "${custom_command}" | tee
 }

 for container in $(pct list | awk '{if(NR>1) print $1}'); do