Compare commits

..

1 Commits

Author SHA1 Message Date
MickLesk
103497a361 fix(tools.func): fix meilisearch import-dump background process handling
When killing the background meilisearch process after dump import,
bash would print a 'Terminated' job notification and trigger
'pop_var_context: head of shell_variables not a function context'
errors (visible as /dev/fd/63 line errors), causing the rest of
the update_script to not execute. This left meilisearch stopped
after migration and caused subsequent update runs to skip it
(binary version already matched latest).

Two fixes:
- Redirect background process output to /dev/null to suppress
  meilisearch startup log noise in the update output
- Add 'wait $MEILI_PID' after 'kill $MEILI_PID' so bash properly
  reaps the child process without printing a job status notification

Fixes #14276
2026-05-08 21:29:37 +02:00
2 changed files with 3 additions and 2 deletions

View File

@@ -20,7 +20,7 @@ $STD apt install -y \
caddy
msg_ok "Installed dependencies"
NODE_VERSION="24" NODE_MODULE="pnpm@10" setup_nodejs
NODE_VERSION="24" NODE_MODULE="pnpm" setup_nodejs
fetch_and_deploy_gh_release "wishlist" "cmintey/wishlist" "tarball"
LATEST_APP_VERSION=$(get_latest_github_release "cmintey/wishlist")

View File

@@ -7588,7 +7588,7 @@ function setup_meilisearch() {
# Start meilisearch with --import-dump flag
# This is a one-time import that happens during startup
/usr/bin/meilisearch --config-file-path /etc/meilisearch.toml --import-dump "$DUMP_FILE" &
/usr/bin/meilisearch --config-file-path /etc/meilisearch.toml --import-dump "$DUMP_FILE" >/dev/null 2>&1 &
local MEILI_PID=$!
# Wait for meilisearch to become healthy (import happens during startup)
@@ -7611,6 +7611,7 @@ function setup_meilisearch() {
# Stop the manual process
kill $MEILI_PID 2>/dev/null || true
wait $MEILI_PID 2>/dev/null || true
sleep 2
# Start via systemd for proper management