mirror of
https://github.com/community-scripts/ProxmoxVE.git
synced 2026-05-16 21:44:56 +02:00
fix(tools.func): fix meilisearch import-dump background process handling
When killing the background meilisearch process after dump import, bash would print a 'Terminated' job notification and trigger 'pop_var_context: head of shell_variables not a function context' errors (visible as /dev/fd/63 line errors), causing the rest of the update_script to not execute. This left meilisearch stopped after migration and caused subsequent update runs to skip it (binary version already matched latest). Two fixes: - Redirect background process output to /dev/null to suppress meilisearch startup log noise in the update output - Add 'wait $MEILI_PID' after 'kill $MEILI_PID' so bash properly reaps the child process without printing a job status notification Fixes #14276
This commit is contained in:
@@ -7588,7 +7588,7 @@ function setup_meilisearch() {
|
||||
|
||||
# Start meilisearch with --import-dump flag
|
||||
# This is a one-time import that happens during startup
|
||||
/usr/bin/meilisearch --config-file-path /etc/meilisearch.toml --import-dump "$DUMP_FILE" &
|
||||
/usr/bin/meilisearch --config-file-path /etc/meilisearch.toml --import-dump "$DUMP_FILE" >/dev/null 2>&1 &
|
||||
local MEILI_PID=$!
|
||||
|
||||
# Wait for meilisearch to become healthy (import happens during startup)
|
||||
@@ -7611,6 +7611,7 @@ function setup_meilisearch() {
|
||||
|
||||
# Stop the manual process
|
||||
kill $MEILI_PID 2>/dev/null || true
|
||||
wait $MEILI_PID 2>/dev/null || true
|
||||
sleep 2
|
||||
|
||||
# Start via systemd for proper management
|
||||
|
||||
Reference in New Issue
Block a user