fix(isponsorblocktv): detect CPU capabilities to select compatible binary

Instead of hard-failing when AVX is not present, detect whether the host
CPU supports AVX + AVX2 + MOVBE (x86-64-v3 microarchitecture level) and
select the appropriate upstream binary accordingly:

- iSponsorBlockTV-x86_64-linux     → modern CPUs (AVX/AVX2/MOVBE)
- iSponsorBlockTV-x86_64-linux-v1  → any x86_64 CPU (fallback)

The same detection logic is applied in update_script() so updates
stay consistent with the initially installed binary type.

Fixes: https://github.com/community-scripts/ProxmoxVE/issues/14660
Upstream: dmunozv04/iSponsorBlockTV#463

ct/isponsorblocktv.sh

@@ -36,7 +36,11 @@ function update_script() {
     systemctl stop isponsorblocktv
     msg_ok "Stopped Service"
 
-    CLEAN_INSTALL=1 fetch_and_deploy_gh_release "isponsorblocktv" "dmunozv04/iSponsorBlockTV" "singlefile" "latest" "/opt/isponsorblocktv" "iSponsorBlockTV-x86_64-linux"
+    ISBTV_BINARY="iSponsorBlockTV-x86_64-linux-v1"
+    if grep -q ' avx ' /proc/cpuinfo 2>/dev/null && grep -q ' avx2 ' /proc/cpuinfo 2>/dev/null && grep -q ' movbe ' /proc/cpuinfo 2>/dev/null; then
+      ISBTV_BINARY="iSponsorBlockTV-x86_64-linux"
+    fi
+    CLEAN_INSTALL=1 fetch_and_deploy_gh_release "isponsorblocktv" "dmunozv04/iSponsorBlockTV" "singlefile" "latest" "/opt/isponsorblocktv" "${ISBTV_BINARY}"
 
     msg_info "Starting Service"
     systemctl start isponsorblocktv

install/isponsorblocktv-install.sh

@@ -13,12 +13,12 @@ setting_up_container
 network_check
 update_os
 
-if ! grep -q ' avx ' /proc/cpuinfo 2>/dev/null; then
-  msg_error "CPU does not support AVX instructions (required by iSponsorBlockTV/PyApp)"
-  exit 106
+ISBTV_BINARY="iSponsorBlockTV-x86_64-linux-v1"
+if grep -q ' avx ' /proc/cpuinfo 2>/dev/null && grep -q ' avx2 ' /proc/cpuinfo 2>/dev/null && grep -q ' movbe ' /proc/cpuinfo 2>/dev/null; then
+  ISBTV_BINARY="iSponsorBlockTV-x86_64-linux"
 fi
 
-fetch_and_deploy_gh_release "isponsorblocktv" "dmunozv04/iSponsorBlockTV" "singlefile" "latest" "/opt/isponsorblocktv" "iSponsorBlockTV-x86_64-linux"
+fetch_and_deploy_gh_release "isponsorblocktv" "dmunozv04/iSponsorBlockTV" "singlefile" "latest" "/opt/isponsorblocktv" "${ISBTV_BINARY}"
 
 msg_info "Setting up iSponsorBlockTV"
 install -d /var/lib/isponsorblocktv

misc/error_handler.func

@@ -358,55 +358,6 @@ error_handler() {
     fi
   fi
 
-  # ── Log-pattern analysis: detect common failure causes and emit actionable hints ──
-  if [[ -n "$active_log" && -s "$active_log" ]]; then
-    local _log_tail
-    _log_tail=$(tail -n 60 "$active_log" 2>/dev/null || true)
-
-    # 1. APT/dpkg dependency conflict
-    if echo "$_log_tail" | grep -qE "Depends:|depends on.*but.*not installed|broken packages|unmet dep|dependency problems"; then
-      # Check for PostgreSQL-specific version mismatch (most actionable)
-      local _pg_conflict
-      _pg_conflict=$(echo "$_log_tail" | grep -oE 'postgresql-[0-9]+ but.*installed' | head -1 || true)
-      if [[ -n "$_pg_conflict" ]]; then
-        if declare -f msg_warn >/dev/null 2>&1; then
-          msg_warn "PostgreSQL version conflict: ${_pg_conflict}"
-          msg_warn "Hint: A package requires a specific PostgreSQL version that is not installed. Your distribution may have installed a different PG version than expected."
-        fi
-      else
-        if declare -f msg_warn >/dev/null 2>&1; then
-          msg_warn "APT dependency conflict detected. A required package is not available or is the wrong version for this system."
-          msg_warn "Hint: Run 'apt-get install -f' inside the container or check that all required repositories are configured for your distribution."
-        fi
-      fi
-    # 2. APT/GPG signature verification failure
-    elif echo "$_log_tail" | grep -qE "sqv|KEYEXPIRED|NO_PUBKEY|key is not certified|signature verification failed|is not signed|Sub-process.*sqv"; then
-      if declare -f msg_warn >/dev/null 2>&1; then
-        msg_warn "APT repository signature error detected."
-        msg_warn "Hint: A repository GPG key may be missing, expired, or the keyring file is not yet present (/usr/share/postgresql-common/pgdg/apt.postgresql.org.asc etc.)."
-        msg_warn "Hint: Install the 'postgresql-common' package first, or re-add the repository with its correct signing key."
-      fi
-    # 3. Network / DNS failure during apt-get or curl
-    elif echo "$_log_tail" | grep -qE "Could not resolve|Failed to fetch|Unable to connect|Name or service not known|Network is unreachable|curl.*resolve"; then
-      if declare -f msg_warn >/dev/null 2>&1; then
-        msg_warn "Network or DNS failure detected."
-        msg_warn "Hint: Check the container's network connectivity, DNS settings, and whether any firewall or ad-blocker is intercepting traffic."
-      fi
-    # 4. APT lock held by another process
-    elif echo "$_log_tail" | grep -qE "Could not get lock|dpkg frontend lock|waiting for it to exit|E: Unable to lock"; then
-      if declare -f msg_warn >/dev/null 2>&1; then
-        msg_warn "APT or dpkg lock conflict detected."
-        msg_warn "Hint: Another package manager process may be running. Try 'rm /var/lib/dpkg/lock-frontend && dpkg --configure -a' inside the container."
-      fi
-    # 5. Disk space exhaustion
-    elif echo "$_log_tail" | grep -qE "No space left on device|disk quota exceeded|ENOSPC"; then
-      if declare -f msg_warn >/dev/null 2>&1; then
-        msg_warn "Disk space exhausted during installation."
-        msg_warn "Hint: Increase the container's disk size (pct resize <ctid> rootfs +2G) or clean up space first."
-      fi
-    fi
-  fi
-
   # Detect context: Container (INSTALL_LOG set + inside container /root) vs Host
   if [[ -n "${INSTALL_LOG:-}" && -f "${INSTALL_LOG:-}" && -d /root ]]; then
     # CONTAINER CONTEXT: Copy log and create flag file for host