tools.func: use safe variable expansion in check_for_gh_release RETURN trap

2026-07-02 04:02:13 +02:00 · 2026-07-01 21:53:51 +02:00
3 changed files with 3 additions and 13 deletions
@@ -38,11 +38,6 @@ function update_script() {
    PYTHON_VERSION="3.12" setup_uv
    JAVA_VERSION="25" setup_java

-    msg_info "Patching Native Libraries for LXC Compatibility"
-    ensure_dependencies patchelf
-    find /usr/lib -name "libicudata.so.*" -exec patchelf --clear-execstack {} \; || true
-    msg_ok "Patched Native Libraries"
-
    msg_info "Stopping Services"
    systemctl stop stirlingpdf libreoffice-listener unoserver
    msg_ok "Stopped Services"
@@ -27,8 +27,7 @@ $STD apt install -y \
  fonts-urw-base35 \
  qpdf \
  poppler-utils \
-  jbig2 \
-  patchelf
+  jbig2
 msg_ok "Installed Dependencies"

 PYTHON_VERSION="3.12" setup_uv
@@ -116,10 +115,6 @@ EOF
 fi
 msg_ok "Created Environment Variables"

-msg_info "Patching Native Libraries for LXC Compatibility"
-find /usr/lib -name "libicudata.so.*" -exec patchelf --clear-execstack {} \; || true
-msg_ok "Patched Native Libraries"
-
 msg_info "Refreshing Font Cache"
 $STD fc-cache -fv
 msg_ok "Font Cache Updated"
@@ -2647,9 +2647,9 @@ check_for_gh_release() {

  ensure_dependencies jq

-  local gh_check_json
+  local gh_check_json=""
  gh_check_json=$(mktemp /tmp/tools-gh-check-XXXXXX) || return 73
-  trap 'rm -f "$gh_check_json"' RETURN
+  trap 'rm -f "${gh_check_json:-}"' RETURN

  # Build auth header if token is available
  local header_args=()