Prefer silent mode on PHS env conflict

When PHS_SILENT and PHS_VERBOSE are both set, stop falling back to interactive mode. Changes prefer silent mode to keep automation safe and avoid blocking unattended/non-TTY updates. Only show a whiptail warning when both stdin/stdout are TTYs and whiptail is present, and ignore any whiptail errors. Added a brief comment and adjusted the fallback message accordingly.
2026-04-23 18:35:05 +02:00 · 2026-04-23 08:26:58 +02:00
2 changed files with 1 additions and 12 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -445,14 +445,6 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit

 </details>

-## 2026-04-23
-
-### 💾 Core
-
-  - #### 🐞 Bug Fixes
-
-    - core: hotfix - prefer silent mode on PHS env conflict [@MickLesk](https://github.com/MickLesk) ([#13951](https://github.com/community-scripts/ProxmoxVE/pull/13951))
-
 ## 2026-04-22

 ### 🆕 New Scripts
--- a/misc/tools.func
+++ b/misc/tools.func
@@ -6336,15 +6336,12 @@ function setup_nodejs() {
    }
  fi

-  # Scenario 1: Already installed at target version - upgrade to latest minor/patch + update packages/modules
+  # Scenario 1: Already installed at target version - just update packages/modules
  if [[ -n "$CURRENT_NODE_VERSION" && "$CURRENT_NODE_VERSION" == "$NODE_VERSION" ]]; then
    msg_info "Update Node.js $NODE_VERSION"

    ensure_apt_working || return 100

-    # Upgrade to the latest minor/patch release from NodeSource
-    $STD apt-get install -y --only-upgrade nodejs 2>/dev/null || true
-
    # Pin npm to 11.11.0 to work around Node.js 22.22.2 regression (nodejs/node#62425)
    $STD npm install -g npm@11.11.0 2>/dev/null || true