Safer tools.func load and improved error handling

Replace process-substitution sourcing of tools.func with an explicit curl -> variable -> source via /dev/stdin, adding failure messages and a check that expected functions (e.g. fetch_and_deploy_gh_release) are present (misc/alpine-install.func, misc/install.func). Add categorize_error mapping for exit code 10 -> "config" (misc/api.func). Tweak build.func: minor pipeline formatting and change the ERR trap to capture the actual exit code and only call ensure_log_on_host/post_update on non-zero exits, preventing erroneous failure reporting.

CHANGELOG.md

@@ -404,6 +404,8 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit
 
 </details>
 
+## 2026-02-17
+
 ## 2026-02-16
 
 ### 🆕 New Scripts
@@ -413,6 +415,8 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit
 
 ### 🚀 Updated Scripts
 
+  - Opencloud: Pin version to 5.1.0 [@vhsdream](https://github.com/vhsdream) ([#12004](https://github.com/community-scripts/ProxmoxVE/pull/12004))
+
   - #### 🐞 Bug Fixes
 
     - Tududi: Fix sed command for DB_FILE configuration [@tremor021](https://github.com/tremor021) ([#11988](https://github.com/community-scripts/ProxmoxVE/pull/11988))

ct/opencloud.sh

@@ -29,7 +29,7 @@ function update_script() {
     exit
   fi
 
-  RELEASE="v5.0.2"
+  RELEASE="v5.1.0"
   if check_for_gh_release "OpenCloud" "opencloud-eu/opencloud" "${RELEASE}"; then
     msg_info "Stopping services"
     systemctl stop opencloud opencloud-wopi

frontend/public/json/github-versions.json

@@ -1,5 +1,5 @@
 {
-  "generated": "2026-02-16T12:14:16Z",
+  "generated": "2026-02-17T06:22:06Z",
   "versions": [
     {
       "slug": "2fauth",
@@ -193,9 +193,9 @@
     {
       "slug": "cleanuparr",
       "repo": "Cleanuparr/Cleanuparr",
-      "version": "v2.6.2",
+      "version": "v2.6.3",
       "pinned": false,
-      "date": "2026-02-15T02:15:19Z"
+      "date": "2026-02-16T22:41:25Z"
     },
     {
       "slug": "cloudreve",
@@ -557,9 +557,9 @@
     {
       "slug": "immich-public-proxy",
       "repo": "alangrainger/immich-public-proxy",
-      "version": "v1.15.2",
+      "version": "v1.15.3",
       "pinned": false,
-      "date": "2026-02-16T08:54:59Z"
+      "date": "2026-02-16T22:54:27Z"
     },
     {
       "slug": "inspircd",
@@ -578,16 +578,16 @@
     {
       "slug": "invoiceninja",
       "repo": "invoiceninja/invoiceninja",
-      "version": "v5.12.60",
+      "version": "v5.12.62",
       "pinned": false,
-      "date": "2026-02-15T00:11:31Z"
+      "date": "2026-02-17T03:23:48Z"
     },
     {
       "slug": "jackett",
       "repo": "Jackett/Jackett",
-      "version": "v0.24.1127",
+      "version": "v0.24.1140",
       "pinned": false,
-      "date": "2026-02-16T08:43:41Z"
+      "date": "2026-02-17T05:54:25Z"
     },
     {
       "slug": "jellystat",
@@ -704,9 +704,9 @@
     {
       "slug": "librenms",
       "repo": "librenms/librenms",
-      "version": "26.1.1",
+      "version": "26.2.0",
       "pinned": false,
-      "date": "2026-01-12T23:26:02Z"
+      "date": "2026-02-16T12:15:13Z"
     },
     {
       "slug": "librespeed-rust",
@@ -739,9 +739,9 @@
     {
       "slug": "linkstack",
       "repo": "linkstackorg/linkstack",
-      "version": "v4.8.5",
+      "version": "v4.8.4",
       "pinned": false,
-      "date": "2026-01-26T18:46:52Z"
+      "date": "2024-12-10T15:14:34Z"
     },
     {
       "slug": "linkwarden",
@@ -802,9 +802,9 @@
     {
       "slug": "mealie",
       "repo": "mealie-recipes/mealie",
-      "version": "v3.10.2",
+      "version": "v3.11.0",
       "pinned": false,
-      "date": "2026-02-04T23:32:32Z"
+      "date": "2026-02-17T04:13:35Z"
     },
     {
       "slug": "mediamanager",
@@ -956,9 +956,9 @@
     {
       "slug": "opencloud",
       "repo": "opencloud-eu/opencloud",
-      "version": "v5.0.2",
+      "version": "v5.1.0",
       "pinned": true,
-      "date": "2026-02-05T16:29:01Z"
+      "date": "2026-02-16T15:04:28Z"
     },
     {
       "slug": "opengist",
@@ -1026,16 +1026,16 @@
     {
       "slug": "paperless-ngx",
       "repo": "paperless-ngx/paperless-ngx",
-      "version": "v2.20.6",
+      "version": "v2.20.7",
       "pinned": false,
-      "date": "2026-01-31T07:30:27Z"
+      "date": "2026-02-16T16:52:23Z"
     },
     {
       "slug": "patchmon",
       "repo": "PatchMon/PatchMon",
-      "version": "v1.4.0",
+      "version": "v1.4.1",
       "pinned": false,
-      "date": "2026-02-13T10:39:03Z"
+      "date": "2026-02-16T18:00:13Z"
     },
     {
       "slug": "paymenter",
@@ -1362,9 +1362,9 @@
     {
       "slug": "slskd",
       "repo": "slskd/slskd",
-      "version": "0.24.3",
+      "version": "0.24.4",
       "pinned": false,
-      "date": "2026-01-15T14:40:15Z"
+      "date": "2026-02-16T16:50:17Z"
     },
     {
       "slug": "snipeit",
@@ -1411,9 +1411,9 @@
     {
       "slug": "stirling-pdf",
       "repo": "Stirling-Tools/Stirling-PDF",
-      "version": "v2.4.6",
+      "version": "v2.5.0",
       "pinned": false,
-      "date": "2026-02-12T00:01:19Z"
+      "date": "2026-02-16T22:58:17Z"
     },
     {
       "slug": "streamlink-webui",
@@ -1544,9 +1544,9 @@
     {
       "slug": "tunarr",
       "repo": "chrisbenincasa/tunarr",
-      "version": "v1.1.12",
+      "version": "v1.1.13",
       "pinned": false,
-      "date": "2026-02-03T20:19:00Z"
+      "date": "2026-02-16T16:16:17Z"
     },
     {
       "slug": "uhf",
@@ -1628,9 +1628,9 @@
     {
       "slug": "wanderer",
       "repo": "meilisearch/meilisearch",
-      "version": "v1.35.0",
+      "version": "v1.35.1",
       "pinned": false,
-      "date": "2026-02-02T09:57:03Z"
+      "date": "2026-02-16T17:01:17Z"
     },
     {
       "slug": "warracker",

install/opencloud-install.sh

@@ -64,7 +64,7 @@ $STD sudo -u cool coolconfig set-admin-password --user=admin --password="$COOLPA
 echo "$COOLPASS" >~/.coolpass
 msg_ok "Installed Collabora Online"
 
-fetch_and_deploy_gh_release "opencloud" "opencloud-eu/opencloud" "singlefile" "v5.0.2" "/usr/bin" "opencloud-*-linux-amd64"
+fetch_and_deploy_gh_release "opencloud" "opencloud-eu/opencloud" "singlefile" "v5.1.0" "/usr/bin" "opencloud-*-linux-amd64"
 
 msg_info "Configuring OpenCloud"
 DATA_DIR="/var/lib/opencloud"

misc/alpine-install.func

@@ -14,6 +14,25 @@ catch_errors
 # Get LXC IP address (must be called INSIDE container, after network is up)
 get_lxc_ip
 
+# ------------------------------------------------------------------------------
+# post_progress_to_api()
+#
+# - Lightweight progress ping from inside the container
+# - Updates the existing telemetry record status from "installing" to "configuring"
+# - Signals that the installation is actively progressing (not stuck)
+# - Fire-and-forget: never blocks or fails the script
+# - Only executes if DIAGNOSTICS=yes and RANDOM_UUID is set
+# ------------------------------------------------------------------------------
+post_progress_to_api() {
+  command -v curl &>/dev/null || return 0
+  [[ "${DIAGNOSTICS:-no}" == "no" ]] && return 0
+  [[ -z "${RANDOM_UUID:-}" ]] && return 0
+
+  curl -fsS -m 5 -X POST "https://telemetry.community-scripts.org/telemetry" \
+    -H "Content-Type: application/json" \
+    -d "{\"random_id\":\"${RANDOM_UUID}\",\"type\":\"lxc\",\"nsapp\":\"${app:-unknown}\",\"status\":\"configuring\"}" &>/dev/null || true
+}
+
 # This function enables IPv6 if it's not disabled and sets verbose mode
 verb_ip6() {
   set_std_mode # Set STD mode based on VERBOSE
@@ -53,6 +72,7 @@ setting_up_container() {
   fi
   msg_ok "Set up Container OS"
   msg_ok "Network Connected: ${BL}$(ip addr show | grep 'inet ' | awk '{print $2}' | cut -d'/' -f1 | tail -n1)${CL}"
+  post_progress_to_api
 }
 
 # This function checks the network connection by pinging a known IP address and prompts the user to continue if the internet is not connected
@@ -85,8 +105,18 @@ network_check() {
 update_os() {
   msg_info "Updating Container OS"
   $STD apk -U upgrade
-  source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/tools.func)
+  local tools_content
+  tools_content=$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/tools.func) || {
+    msg_error "Failed to download tools.func"
+    exit 6
+  }
+  source /dev/stdin <<<"$tools_content"
+  if ! declare -f fetch_and_deploy_gh_release >/dev/null 2>&1; then
+    msg_error "tools.func loaded but incomplete — missing expected functions"
+    exit 6
+  fi
   msg_ok "Updated Container OS"
+  post_progress_to_api
 }
 
 # This function modifies the message of the day (motd) and SSH settings

misc/api.func

@@ -117,17 +117,16 @@ detect_repo_source
 # - Canonical source of truth for ALL exit code mappings
 # - Used by both api.func (telemetry) and error_handler.func (error display)
 # - Supports:
-#   * Generic/Shell errors (1-3, 10, 124-132, 134, 137, 139, 141, 143-146)
-#   * curl/wget errors (4-8, 16, 18, 22-28, 30, 32-36, 39, 44-48, 51-52, 55-57, 59, 61, 63, 75, 78-79, 92, 95)
+#   * Generic/Shell errors (1, 2, 124, 126-130, 134, 137, 139, 141, 143)
+#   * curl/wget errors (6, 7, 22, 28, 35)
 #   * Package manager errors (APT, DPKG: 100-102, 255)
-#   * BSD sysexits (64-78)
 #   * Systemd/Service errors (150-154)
 #   * Python/pip/uv errors (160-162)
 #   * PostgreSQL errors (170-173)
 #   * MySQL/MariaDB errors (180-183)
 #   * MongoDB errors (190-193)
 #   * Proxmox custom codes (200-231)
-#   * Node.js/npm errors (239, 243, 245-249)
+#   * Node.js/npm errors (243, 245-249)
 # - Returns description string for given exit code
 # ------------------------------------------------------------------------------
 explain_exit_code() {
@@ -136,7 +135,6 @@ explain_exit_code() {
   # --- Generic / Shell ---
   1) echo "General error / Operation not permitted" ;;
   2) echo "Misuse of shell builtins (e.g. syntax error)" ;;
-  3) echo "General syntax or argument error" ;;
   10) echo "Docker / privileged mode required (unsupported environment)" ;;
 
   # --- curl / wget errors (commonly seen in downloads) ---
@@ -144,41 +142,16 @@ explain_exit_code() {
   5) echo "curl: Could not resolve proxy" ;;
   6) echo "curl: DNS resolution failed (could not resolve host)" ;;
   7) echo "curl: Failed to connect (network unreachable / host down)" ;;
-  8) echo "curl: Server reply error (FTP/SFTP or apk untrusted key)" ;;
-  16) echo "curl: HTTP/2 framing layer error" ;;
-  18) echo "curl: Partial file (transfer not completed)" ;;
+  8) echo "curl: FTP server reply error" ;;
   22) echo "curl: HTTP error returned (404, 429, 500+)" ;;
   23) echo "curl: Write error (disk full or permissions)" ;;
-  24) echo "curl: Write to local file failed" ;;
   25) echo "curl: Upload failed" ;;
-  26) echo "curl: Read error on local file (I/O)" ;;
-  27) echo "curl: Out of memory (memory allocation failed)" ;;
   28) echo "curl: Operation timeout (network slow or server not responding)" ;;
   30) echo "curl: FTP port command failed" ;;
-  32) echo "curl: FTP SIZE command failed" ;;
-  33) echo "curl: HTTP range error" ;;
-  34) echo "curl: HTTP post error" ;;
   35) echo "curl: SSL/TLS handshake failed (certificate error)" ;;
-  36) echo "curl: FTP bad download resume" ;;
-  39) echo "curl: LDAP search failed" ;;
-  44) echo "curl: Internal error (bad function call order)" ;;
-  45) echo "curl: Interface error (failed to bind to specified interface)" ;;
-  46) echo "curl: Bad password entered" ;;
-  47) echo "curl: Too many redirects" ;;
-  48) echo "curl: Unknown command line option specified" ;;
-  51) echo "curl: SSL peer certificate or SSH host key verification failed" ;;
-  52) echo "curl: Empty reply from server (got nothing)" ;;
-  55) echo "curl: Failed sending network data" ;;
   56) echo "curl: Receive error (connection reset by peer)" ;;
-  57) echo "curl: Unrecoverable poll/select error (system I/O failure)" ;;
-  59) echo "curl: Couldn't use specified SSL cipher" ;;
-  61) echo "curl: Bad/unrecognized transfer encoding" ;;
-  63) echo "curl: Maximum file size exceeded" ;;
   75) echo "Temporary failure (retry later)" ;;
   78) echo "curl: Remote file not found (404 on FTP/file)" ;;
-  79) echo "curl: SSH session error (key exchange/auth failed)" ;;
-  92) echo "curl: HTTP/2 stream error (protocol violation)" ;;
-  95) echo "curl: HTTP/3 layer error" ;;
 
   # --- Package manager / APT / DPKG ---
   100) echo "APT: Package manager error (broken packages / dependency problems)" ;;
@@ -202,21 +175,15 @@ explain_exit_code() {
 
   # --- Common shell/system errors ---
   124) echo "Command timed out (timeout command)" ;;
-  125) echo "Command failed to start (Docker daemon or execution error)" ;;
   126) echo "Command invoked cannot execute (permission problem?)" ;;
   127) echo "Command not found" ;;
   128) echo "Invalid argument to exit" ;;
-  129) echo "Killed by SIGHUP (terminal closed / hangup)" ;;
   130) echo "Aborted by user (SIGINT)" ;;
-  131) echo "Killed by SIGQUIT (core dumped)" ;;
-  132) echo "Killed by SIGILL (illegal CPU instruction)" ;;
   134) echo "Process aborted (SIGABRT - possibly Node.js heap overflow)" ;;
   137) echo "Killed (SIGKILL / Out of memory?)" ;;
   139) echo "Segmentation fault (core dumped)" ;;
   141) echo "Broken pipe (SIGPIPE - output closed prematurely)" ;;
   143) echo "Terminated (SIGTERM)" ;;
-  144) echo "Killed by signal 16 (SIGUSR1 / SIGSTKFLT)" ;;
-  146) echo "Killed by signal 18 (SIGTSTP)" ;;
 
   # --- Systemd / Service errors (150-154) ---
   150) echo "Systemd: Service failed to start" ;;
@@ -224,6 +191,7 @@ explain_exit_code() {
   152) echo "Permission denied (EACCES)" ;;
   153) echo "Build/compile failed (make/gcc/cmake)" ;;
   154) echo "Node.js: Native addon build failed (node-gyp)" ;;
+
   # --- Python / pip / uv (160-162) ---
   160) echo "Python: Virtualenv / uv environment missing or broken" ;;
   161) echo "Python: Dependency resolution failed" ;;
@@ -274,8 +242,7 @@ explain_exit_code() {
   225) echo "Proxmox: No template available for OS/Version" ;;
   231) echo "Proxmox: LXC stack upgrade failed" ;;
 
-  # --- Node.js / npm / pnpm / yarn (239-249) ---
-  239) echo "npm/Node.js: Unexpected runtime error or dependency failure" ;;
+  # --- Node.js / npm / pnpm / yarn (243-249) ---
   243) echo "Node.js: Out of memory (JavaScript heap out of memory)" ;;
   245) echo "Node.js: Invalid command-line option" ;;
   246) echo "Node.js: Internal JavaScript Parse Error" ;;
@@ -908,6 +875,9 @@ categorize_error() {
   # Network errors (curl/wget)
   6 | 7 | 22 | 35) echo "network" ;;
 
+  # Docker / Privileged mode required
+  10) echo "config" ;;
+
   # Timeout errors
   28 | 124 | 211) echo "timeout" ;;
 

misc/build.func

@@ -4038,13 +4038,6 @@ EOF'
 
   msg_ok "Customized LXC Container"
 
-  # Optional DNS override for retry scenarios (inside LXC, never on host)
-  if [[ "${DNS_RETRY_OVERRIDE:-false}" == "true" ]]; then
-    msg_info "Applying DNS retry override in LXC (8.8.8.8, 1.1.1.1)"
-    pct exec "$CTID" -- bash -c "printf 'nameserver 8.8.8.8\nnameserver 1.1.1.1\n' >/etc/resolv.conf" >/dev/null 2>&1 || true
-    msg_ok "DNS override applied in LXC"
-  fi
-
   # Install SSH keys
   install_ssh_keys_into_ct
 
@@ -4157,322 +4150,32 @@ EOF'
 
     # Prompt user for cleanup with 60s timeout
     echo ""
-
-    # Detect error type for smart recovery options
-    local is_oom=false
-    local is_network_issue=false
-    local is_apt_issue=false
-    local is_cmd_not_found=false
-    local error_explanation=""
-    if declare -f explain_exit_code >/dev/null 2>&1; then
-      error_explanation="$(explain_exit_code "$install_exit_code")"
-    fi
-
-    # OOM detection: exit codes 134 (SIGABRT/heap), 137 (SIGKILL/OOM), 243 (Node.js heap)
-    if [[ $install_exit_code -eq 134 || $install_exit_code -eq 137 || $install_exit_code -eq 243 ]]; then
-      is_oom=true
-    fi
-
-    # APT/DPKG detection: exit codes 100-102 (APT), 255 (DPKG with log evidence)
-    case "$install_exit_code" in
-    100 | 101 | 102) is_apt_issue=true ;;
-    255)
-      if [[ -f "$combined_log" ]] && grep -qiE 'dpkg|apt-get|apt\.conf|broken packages|unmet dependencies|E: Sub-process|E: Failed' "$combined_log"; then
-        is_apt_issue=true
-      fi
-      ;;
-    esac
-
-    # Command not found detection
-    if [[ $install_exit_code -eq 127 ]]; then
-      is_cmd_not_found=true
-    fi
-
-    # Network-related detection (curl/apt/git fetch failures and transient network issues)
-    case "$install_exit_code" in
-    6 | 7 | 22 | 28 | 35 | 52 | 56 | 57 | 75 | 78) is_network_issue=true ;;
-    100)
-      # APT can fail due to network (Failed to fetch)
-      if [[ -f "$combined_log" ]] && grep -qiE 'Failed to fetch|Could not resolve|Connection failed|Network is unreachable|Temporary failure resolving' "$combined_log"; then
-        is_network_issue=true
-      fi
-      ;;
-    128)
-      if [[ -f "$combined_log" ]] && grep -qiE 'RPC failed|early EOF|fetch-pack|HTTP/2 stream|Could not resolve host|Temporary failure resolving|Failed to fetch|Connection reset|Network is unreachable' "$combined_log"; then
-        is_network_issue=true
-      fi
-      ;;
-    esac
-
-    # Exit 1 subclassification: analyze logs to identify actual root cause
-    # Many exit 1 errors are actually APT, OOM, network, or command-not-found issues
-    if [[ $install_exit_code -eq 1 && -f "$combined_log" ]]; then
-      if grep -qiE 'E: Unable to|E: Package|E: Failed to fetch|dpkg.*error|broken packages|unmet dependencies|dpkg --configure -a' "$combined_log"; then
-        is_apt_issue=true
-      fi
-      if grep -qiE 'Cannot allocate memory|Out of memory|oom-killer|Killed process|JavaScript heap' "$combined_log"; then
-        is_oom=true
-      fi
-      if grep -qiE 'Could not resolve|DNS|Connection refused|Network is unreachable|No route to host|Temporary failure resolving|Failed to fetch' "$combined_log"; then
-        is_network_issue=true
-      fi
-      if grep -qiE ': command not found|No such file or directory.*/s?bin/' "$combined_log"; then
-        is_cmd_not_found=true
-      fi
-    fi
-
-    # Show error explanation if available
-    if [[ -n "$error_explanation" ]]; then
-      echo -e "${TAB}${RD}Error: ${error_explanation}${CL}"
-      echo ""
-    fi
-
-    # Show specific hints for known error types
-    if [[ $install_exit_code -eq 10 ]]; then
-      echo -e "${TAB}${INFO} This error usually means the container needs ${GN}privileged${CL} mode or Docker/nesting support."
-      echo -e "${TAB}${INFO} Recreate with: Advanced Install → Container Type: ${GN}Privileged${CL}"
-      echo ""
-    fi
-
-    if [[ $install_exit_code -eq 125 || $install_exit_code -eq 126 ]]; then
-      echo -e "${TAB}${INFO} The command exists but cannot be executed. This may be a ${GN}permission${CL} issue."
-      echo -e "${TAB}${INFO} If using Docker, ensure the container is ${GN}privileged${CL} or has correct permissions."
-      echo ""
-    fi
-
-    if [[ "$is_cmd_not_found" == true ]]; then
-      local missing_cmd=""
-      if [[ -f "$combined_log" ]]; then
-        missing_cmd=$(grep -oiE '[a-zA-Z0-9_.-]+: command not found' "$combined_log" | tail -1 | sed 's/: command not found//')
-      fi
-      if [[ -n "$missing_cmd" ]]; then
-        echo -e "${TAB}${INFO} Missing command: ${GN}${missing_cmd}${CL}"
-      fi
-      echo ""
-    fi
-
-    # Build recovery menu based on error type
-    echo -e "${YW}What would you like to do?${CL}"
-    echo ""
-    echo -e "  ${GN}1)${CL} Remove container and exit"
-    echo -e "  ${GN}2)${CL} Keep container for debugging"
-    echo -e "  ${GN}3)${CL} Retry with verbose mode (full rebuild)"
-
-    local next_option=4
-    local APT_OPTION="" OOM_OPTION="" DNS_OPTION=""
-
-    if [[ "$is_apt_issue" == true ]]; then
-      if [[ "$var_os" == "alpine" ]]; then
-        echo -e "  ${GN}${next_option})${CL} Repair APK state and re-run install (in-place)"
-      else
-        echo -e "  ${GN}${next_option})${CL} Repair APT/DPKG state and re-run install (in-place)"
-      fi
-      APT_OPTION=$next_option
-      next_option=$((next_option + 1))
-    fi
-
-    if [[ "$is_oom" == true ]]; then
-      local recovery_attempt="${RECOVERY_ATTEMPT:-0}"
-      if [[ $recovery_attempt -lt 2 ]]; then
-        local new_ram=$((RAM_SIZE * 2))
-        local new_cpu=$((CORE_COUNT * 2))
-        echo -e "  ${GN}${next_option})${CL} Retry with more resources (RAM: ${RAM_SIZE}→${new_ram} MiB, CPU: ${CORE_COUNT}→${new_cpu} cores)"
-        OOM_OPTION=$next_option
-        next_option=$((next_option + 1))
-      else
-        echo -e "  ${DGN}-)${CL} ${DGN}OOM retry exhausted (already retried ${recovery_attempt}x)${CL}"
-      fi
-    fi
-
-    if [[ "$is_network_issue" == true ]]; then
-      echo -e "  ${GN}${next_option})${CL} Retry with DNS override in LXC (8.8.8.8 / 1.1.1.1)"
-      DNS_OPTION=$next_option
-      next_option=$((next_option + 1))
-    fi
-
-    local max_option=$((next_option - 1))
-
-    echo ""
-    echo -en "${YW}Select option [1-${max_option}] (default: 1, auto-remove in 60s): ${CL}"
+    echo -en "${TAB}❓${TAB}${YW}Remove broken container ${CTID}? (Y/n) [auto-remove in 60s]: ${CL}"
 
     if read -t 60 -r response; then
-      case "${response:-1}" in
-      1)
+      if [[ -z "$response" || "$response" =~ ^[Yy]$ ]]; then
         # Remove container
-        echo -e "\n${TAB}${HOLD}${YW}Removing container ${CTID}${CL}"
+        echo ""
+        msg_info "Removing container ${CTID}"
         pct stop "$CTID" &>/dev/null || true
         pct destroy "$CTID" &>/dev/null || true
-        echo -e "${BFR}${CM}${GN}Container ${CTID} removed${CL}"
-        ;;
-      2)
-        echo -e "\n${TAB}${YW}Container ${CTID} kept for debugging${CL}"
+        msg_ok "Container ${CTID} removed"
+      elif [[ "$response" =~ ^[Nn]$ ]]; then
+        echo ""
+        msg_warn "Container ${CTID} kept for debugging"
+
         # Dev mode: Setup MOTD/SSH for debugging access to broken container
         if [[ "${DEV_MODE_MOTD:-false}" == "true" ]]; then
           echo -e "${TAB}${HOLD}${DGN}Setting up MOTD and SSH for debugging...${CL}"
           if pct exec "$CTID" -- bash -c "
-              source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/install.func)
-              declare -f motd_ssh >/dev/null 2>&1 && motd_ssh || true
-            " >/dev/null 2>&1; then
+            source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/install.func)
+            declare -f motd_ssh >/dev/null 2>&1 && motd_ssh || true
+          " >/dev/null 2>&1; then
             local ct_ip=$(pct exec "$CTID" ip a s dev eth0 2>/dev/null | awk '/inet / {print $2}' | cut -d/ -f1)
             echo -e "${BFR}${CM}${GN}MOTD/SSH ready - SSH into container: ssh root@${ct_ip}${CL}"
           fi
         fi
-        exit $install_exit_code
-        ;;
-      3)
-        # Retry with verbose mode (full rebuild)
-        echo -e "\n${TAB}${HOLD}${YW}Removing container ${CTID} for rebuild...${CL}"
-        pct stop "$CTID" &>/dev/null || true
-        pct destroy "$CTID" &>/dev/null || true
-        echo -e "${BFR}${CM}${GN}Container ${CTID} removed${CL}"
-        echo ""
-        # Get new container ID
-        local old_ctid="$CTID"
-        export CTID=$(get_valid_container_id "$CTID")
-        export VERBOSE="yes"
-        export var_verbose="yes"
-
-        # Show rebuild summary
-        echo -e "${YW}Rebuilding with preserved settings:${CL}"
-        echo -e "  Container ID: ${old_ctid} → ${CTID}"
-        echo -e "  RAM: ${RAM_SIZE} MiB | CPU: ${CORE_COUNT} cores | Disk: ${DISK_SIZE} GB"
-        echo -e "  Network: ${NET:-dhcp} | Bridge: ${BRG:-vmbr0}"
-        echo -e "  Verbose: ${GN}enabled${CL}"
-        echo ""
-        msg_info "Restarting installation..."
-        # Re-run build_container
-        build_container
-        return $?
-        ;;
-      *)
-        # Handle dynamic smart recovery options via named option variables
-        local handled=false
-
-        if [[ -n "${APT_OPTION}" && "${response}" == "${APT_OPTION}" ]]; then
-          # Package manager in-place repair: fix broken state and re-run install script
-          handled=true
-          if [[ "$var_os" == "alpine" ]]; then
-            echo -e "\n${TAB}${HOLD}${YW}Repairing APK state in container ${CTID}...${CL}"
-            pct exec "$CTID" -- ash -c "
-              apk fix 2>/dev/null || true
-              apk cache clean 2>/dev/null || true
-              apk update 2>/dev/null || true
-            " >/dev/null 2>&1 || true
-            echo -e "${BFR}${CM}${GN}APK state repaired in container ${CTID}${CL}"
-          else
-            echo -e "\n${TAB}${HOLD}${YW}Repairing APT/DPKG state in container ${CTID}...${CL}"
-            pct exec "$CTID" -- bash -c "
-              DEBIAN_FRONTEND=noninteractive dpkg --configure -a 2>/dev/null || true
-              apt-get -f install -y 2>/dev/null || true
-              apt-get clean 2>/dev/null
-              apt-get update 2>/dev/null || true
-            " >/dev/null 2>&1 || true
-            echo -e "${BFR}${CM}${GN}APT/DPKG state repaired in container ${CTID}${CL}"
-          fi
-          echo ""
-          export VERBOSE="yes"
-          export var_verbose="yes"
-
-          echo -e "${YW}Re-running installation in existing container ${CTID}:${CL}"
-          echo -e "  RAM: ${RAM_SIZE} MiB | CPU: ${CORE_COUNT} cores | Disk: ${DISK_SIZE} GB"
-          echo -e "  Verbose: ${GN}enabled${CL}"
-          echo ""
-          msg_info "Re-running installation script..."
-
-          # Re-run install script in existing container (don't destroy/recreate)
-          set +Eeuo pipefail
-          trap - ERR
-          lxc-attach -n "$CTID" -- bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/install/${var_install}.sh)"
-          local apt_retry_exit=$?
-          set -Eeuo pipefail
-          trap 'error_handler' ERR
-
-          # Check for error flag from retry
-          local apt_retry_code=0
-          if [[ -n "${SESSION_ID:-}" ]]; then
-            local retry_error_flag="/root/.install-${SESSION_ID}.failed"
-            if pct exec "$CTID" -- test -f "$retry_error_flag" 2>/dev/null; then
-              apt_retry_code=$(pct exec "$CTID" -- cat "$retry_error_flag" 2>/dev/null || echo "1")
-              pct exec "$CTID" -- rm -f "$retry_error_flag" 2>/dev/null || true
-            fi
-          fi
-
-          if [[ $apt_retry_code -eq 0 && $apt_retry_exit -ne 0 ]]; then
-            apt_retry_code=$apt_retry_exit
-          fi
-
-          if [[ $apt_retry_code -eq 0 ]]; then
-            msg_ok "Installation completed successfully after APT repair!"
-            post_update_to_api "done" "0" "force"
-            return 0
-          else
-            msg_error "Installation still failed after APT repair (exit code: ${apt_retry_code})"
-            install_exit_code=$apt_retry_code
-          fi
-        fi
-
-        if [[ -n "${OOM_OPTION}" && "${response}" == "${OOM_OPTION}" ]]; then
-          # Retry with doubled resources
-          handled=true
-          echo -e "\n${TAB}${HOLD}${YW}Removing container ${CTID} for rebuild with more resources...${CL}"
-          pct stop "$CTID" &>/dev/null || true
-          pct destroy "$CTID" &>/dev/null || true
-          echo -e "${BFR}${CM}${GN}Container ${CTID} removed${CL}"
-          echo ""
-          local old_ctid="$CTID"
-          local old_ram="$RAM_SIZE"
-          local old_cpu="$CORE_COUNT"
-          export CTID=$(get_valid_container_id "$CTID")
-          export RAM_SIZE=$((RAM_SIZE * 2))
-          export CORE_COUNT=$((CORE_COUNT * 2))
-          export var_ram="$RAM_SIZE"
-          export var_cpu="$CORE_COUNT"
-          export VERBOSE="yes"
-          export var_verbose="yes"
-          export RECOVERY_ATTEMPT=$(( ${RECOVERY_ATTEMPT:-0} + 1 ))
-
-          echo -e "${YW}Rebuilding with increased resources (attempt ${RECOVERY_ATTEMPT}/2):${CL}"
-          echo -e "  Container ID: ${old_ctid} → ${CTID}"
-          echo -e "  RAM: ${old_ram} → ${GN}${RAM_SIZE}${CL} MiB (x2)"
-          echo -e "  CPU: ${old_cpu} → ${GN}${CORE_COUNT}${CL} cores (x2)"
-          echo -e "  Disk: ${DISK_SIZE} GB | Network: ${NET:-dhcp} | Bridge: ${BRG:-vmbr0}"
-          echo -e "  Verbose: ${GN}enabled${CL}"
-          echo ""
-          msg_info "Restarting installation..."
-          build_container
-          return $?
-        fi
-
-        if [[ -n "${DNS_OPTION}" && "${response}" == "${DNS_OPTION}" ]]; then
-          # Retry with DNS override in LXC
-          handled=true
-          echo -e "\n${TAB}${HOLD}${YW}Removing container ${CTID} for rebuild with DNS override...${CL}"
-          pct stop "$CTID" &>/dev/null || true
-          pct destroy "$CTID" &>/dev/null || true
-          echo -e "${BFR}${CM}${GN}Container ${CTID} removed${CL}"
-          echo ""
-          local old_ctid="$CTID"
-          export CTID=$(get_valid_container_id "$CTID")
-          export DNS_RETRY_OVERRIDE="true"
-          export VERBOSE="yes"
-          export var_verbose="yes"
-
-          echo -e "${YW}Rebuilding with DNS override in LXC:${CL}"
-          echo -e "  Container ID: ${old_ctid} → ${CTID}"
-          echo -e "  DNS: ${GN}8.8.8.8, 1.1.1.1${CL} (inside LXC only)"
-          echo -e "  Verbose: ${GN}enabled${CL}"
-          echo ""
-          msg_info "Restarting installation..."
-          build_container
-          return $?
-        fi
-
-        if [[ "$handled" == false ]]; then
-          echo -e "\n${TAB}${YW}Invalid option. Container ${CTID} kept.${CL}"
-          exit $install_exit_code
-        fi
-        ;;
-      esac
+      fi
     else
       # Timeout - auto-remove
       echo ""
@@ -5562,15 +5265,14 @@ api_exit_script() {
     post_update_to_api "failed" "$exit_code"
   elif [[ "${POST_TO_API_DONE:-}" == "true" && "${POST_UPDATE_DONE:-}" != "true" ]]; then
     # Script exited with 0 but never sent a completion status
-    # This catches edge cases like early returns after post_to_api()
-    post_update_to_api "failed" "1"
+    # exit_code=0 is never an error — report as success
+    post_update_to_api "done" "0"
   fi
 }
 
 if command -v pveversion >/dev/null 2>&1; then
   trap 'api_exit_script' EXIT
 fi
-trap '_ERR_CODE=$?; ensure_log_on_host; post_update_to_api "failed" "$_ERR_CODE"' ERR
-trap 'ensure_log_on_host; post_update_to_api "failed" "129"; exit 129' SIGHUP
+trap 'local _ec=$?; if [[ $_ec -ne 0 ]]; then ensure_log_on_host; post_update_to_api "failed" "$_ec"; fi' ERR
 trap 'ensure_log_on_host; post_update_to_api "failed" "130"; exit 130' SIGINT
 trap 'ensure_log_on_host; post_update_to_api "failed" "143"; exit 143' SIGTERM

misc/error_handler.func

@@ -37,47 +37,21 @@ if ! declare -f explain_exit_code &>/dev/null; then
     case "$code" in
     1) echo "General error / Operation not permitted" ;;
     2) echo "Misuse of shell builtins (e.g. syntax error)" ;;
-    3) echo "General syntax or argument error" ;;
     10) echo "Docker / privileged mode required (unsupported environment)" ;;
     4) echo "curl: Feature not supported or protocol error" ;;
     5) echo "curl: Could not resolve proxy" ;;
     6) echo "curl: DNS resolution failed (could not resolve host)" ;;
     7) echo "curl: Failed to connect (network unreachable / host down)" ;;
-    8) echo "curl: Server reply error (FTP/SFTP or apk untrusted key)" ;;
-    16) echo "curl: HTTP/2 framing layer error" ;;
-    18) echo "curl: Partial file (transfer not completed)" ;;
+    8) echo "curl: FTP server reply error" ;;
     22) echo "curl: HTTP error returned (404, 429, 500+)" ;;
     23) echo "curl: Write error (disk full or permissions)" ;;
-    24) echo "curl: Write to local file failed" ;;
     25) echo "curl: Upload failed" ;;
-    26) echo "curl: Read error on local file (I/O)" ;;
-    27) echo "curl: Out of memory (memory allocation failed)" ;;
     28) echo "curl: Operation timeout (network slow or server not responding)" ;;
     30) echo "curl: FTP port command failed" ;;
-    32) echo "curl: FTP SIZE command failed" ;;
-    33) echo "curl: HTTP range error" ;;
-    34) echo "curl: HTTP post error" ;;
     35) echo "curl: SSL/TLS handshake failed (certificate error)" ;;
-    36) echo "curl: FTP bad download resume" ;;
-    39) echo "curl: LDAP search failed" ;;
-    44) echo "curl: Internal error (bad function call order)" ;;
-    45) echo "curl: Interface error (failed to bind to specified interface)" ;;
-    46) echo "curl: Bad password entered" ;;
-    47) echo "curl: Too many redirects" ;;
-    48) echo "curl: Unknown command line option specified" ;;
-    51) echo "curl: SSL peer certificate or SSH host key verification failed" ;;
-    52) echo "curl: Empty reply from server (got nothing)" ;;
-    55) echo "curl: Failed sending network data" ;;
     56) echo "curl: Receive error (connection reset by peer)" ;;
-    57) echo "curl: Unrecoverable poll/select error (system I/O failure)" ;;
-    59) echo "curl: Couldn't use specified SSL cipher" ;;
-    61) echo "curl: Bad/unrecognized transfer encoding" ;;
-    63) echo "curl: Maximum file size exceeded" ;;
     75) echo "Temporary failure (retry later)" ;;
     78) echo "curl: Remote file not found (404 on FTP/file)" ;;
-    79) echo "curl: SSH session error (key exchange/auth failed)" ;;
-    92) echo "curl: HTTP/2 stream error (protocol violation)" ;;
-    95) echo "curl: HTTP/3 layer error" ;;
     64) echo "Usage error (wrong arguments)" ;;
     65) echo "Data format error (bad input data)" ;;
     66) echo "Input file not found (cannot open input)" ;;
@@ -95,21 +69,15 @@ if ! declare -f explain_exit_code &>/dev/null; then
     101) echo "APT: Configuration error (bad sources.list, malformed config)" ;;
     102) echo "APT: Lock held by another process (dpkg/apt still running)" ;;
     124) echo "Command timed out (timeout command)" ;;
-    125) echo "Command failed to start (Docker daemon or execution error)" ;;
     126) echo "Command invoked cannot execute (permission problem?)" ;;
     127) echo "Command not found" ;;
     128) echo "Invalid argument to exit" ;;
-    129) echo "Killed by SIGHUP (terminal closed / hangup)" ;;
-    130) echo "Aborted by user (SIGINT)" ;;
-    131) echo "Killed by SIGQUIT (core dumped)" ;;
-    132) echo "Killed by SIGILL (illegal CPU instruction)" ;;
+    130) echo "Terminated by Ctrl+C (SIGINT)" ;;
     134) echo "Process aborted (SIGABRT - possibly Node.js heap overflow)" ;;
     137) echo "Killed (SIGKILL / Out of memory?)" ;;
     139) echo "Segmentation fault (core dumped)" ;;
     141) echo "Broken pipe (SIGPIPE - output closed prematurely)" ;;
     143) echo "Terminated (SIGTERM)" ;;
-    144) echo "Killed by signal 16 (SIGUSR1 / SIGSTKFLT)" ;;
-    146) echo "Killed by signal 18 (SIGTSTP)" ;;
     150) echo "Systemd: Service failed to start" ;;
     151) echo "Systemd: Service unit not found" ;;
     152) echo "Permission denied (EACCES)" ;;
@@ -155,7 +123,6 @@ if ! declare -f explain_exit_code &>/dev/null; then
     224) echo "Proxmox: PBS storage is for backups only" ;;
     225) echo "Proxmox: No template available for OS/Version" ;;
     231) echo "Proxmox: LXC stack upgrade failed" ;;
-    239) echo "npm/Node.js: Unexpected runtime error or dependency failure" ;;
     243) echo "Node.js: Out of memory (JavaScript heap out of memory)" ;;
     245) echo "Node.js: Invalid command-line option" ;;
     246) echo "Node.js: Internal JavaScript Parse Error" ;;

misc/install.func

@@ -40,6 +40,25 @@ catch_errors
 # Get LXC IP address (must be called INSIDE container, after network is up)
 get_lxc_ip
 
+# ------------------------------------------------------------------------------
+# post_progress_to_api()
+#
+# - Lightweight progress ping from inside the container
+# - Updates the existing telemetry record status from "installing" to "configuring"
+# - Signals that the installation is actively progressing (not stuck)
+# - Fire-and-forget: never blocks or fails the script
+# - Only executes if DIAGNOSTICS=yes and RANDOM_UUID is set
+# ------------------------------------------------------------------------------
+post_progress_to_api() {
+  command -v curl &>/dev/null || return 0
+  [[ "${DIAGNOSTICS:-no}" == "no" ]] && return 0
+  [[ -z "${RANDOM_UUID:-}" ]] && return 0
+
+  curl -fsS -m 5 -X POST "https://telemetry.community-scripts.org/telemetry" \
+    -H "Content-Type: application/json" \
+    -d "{\"random_id\":\"${RANDOM_UUID}\",\"type\":\"lxc\",\"nsapp\":\"${app:-unknown}\",\"status\":\"configuring\"}" &>/dev/null || true
+}
+
 # ==============================================================================
 # SECTION 2: NETWORK & CONNECTIVITY
 # ==============================================================================
@@ -103,6 +122,7 @@ setting_up_container() {
   msg_ok "Set up Container OS"
   #msg_custom "${CM}" "${GN}" "Network Connected: ${BL}$(hostname -I)"
   msg_ok "Network Connected: ${BL}$(hostname -I)"
+  post_progress_to_api
 }
 
 # ------------------------------------------------------------------------------
@@ -206,8 +226,18 @@ EOF
   $STD apt-get -o Dpkg::Options::="--force-confold" -y dist-upgrade
   rm -rf /usr/lib/python3.*/EXTERNALLY-MANAGED
   msg_ok "Updated Container OS"
+  post_progress_to_api
 
-  source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/tools.func)
+  local tools_content
+  tools_content=$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/tools.func) || {
+    msg_error "Failed to download tools.func"
+    exit 6
+  }
+  source /dev/stdin <<<"$tools_content"
+  if ! declare -f fetch_and_deploy_gh_release >/dev/null 2>&1; then
+    msg_error "tools.func loaded but incomplete — missing expected functions"
+    exit 6
+  fi
 }
 
 # ==============================================================================