Use specific exit codes in VM scripts

Replace generic exit 1 with distinct exit codes across vm/*.sh to make failures more actionable for callers. Changes include: use 226 for missing imported-disk references, 237 for pv installation failures, 115 for download/extract/ISO-related failures, 214 for insufficient disk space during FreeBSD decompression, and 119 for missing storage detection. Updated scripts: archlinux-vm.sh, docker-vm.sh, haos-vm.sh, openwrt-vm.sh, opnsense-vm.sh, truenas-vm.sh, umbrel-os-vm.sh.
Use exit 105 for unsupported PVE versions
2026-03-03 17:35:55 +01:00 · 2026-03-02 10:18:44 +01:00 · 2026-03-02 10:16:58 +01:00 · 2026-03-02 10:02:41 +01:00 · 2026-03-02 10:01:09 +01:00 · 2026-03-02 09:59:23 +01:00
37 changed files with 131 additions and 379 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -412,10 +412,6 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit

 ## 2026-03-02

-### 🆕 New Scripts
-
-  - Profilarr ([#12441](https://github.com/community-scripts/ProxmoxVE/pull/12441))
-
 ### 🚀 Updated Scripts

  - #### 💥 Breaking Changes
@@ -428,10 +424,6 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit

    - tools.func: Improve stability with retry logic, caching, and debug mode [@MickLesk](https://github.com/MickLesk) ([#10351](https://github.com/community-scripts/ProxmoxVE/pull/10351))

-  - #### 🔧 Refactor
-
-    - core: standardize exit codes and add mappings [@MickLesk](https://github.com/MickLesk) ([#12467](https://github.com/community-scripts/ProxmoxVE/pull/12467))
-
 ### 🌐 Website

  - frontend: improve detail view badges, addon texts, and HTML title [@MickLesk](https://github.com/MickLesk) ([#12461](https://github.com/community-scripts/ProxmoxVE/pull/12461))
--- a/ct/alpine-komodo.sh
+++ b/ct/alpine-komodo.sh
@@ -39,7 +39,7 @@ function update_script() {
    COMPOSE_FILE=$(find /opt/komodo -maxdepth 1 -type f -name '*.compose.yaml' ! -name 'compose.env' | head -n1)
    if [[ -z "$COMPOSE_FILE" ]]; then
      msg_error "No valid compose file found in /opt/komodo!"
-      exit 252
+      exit 1
    fi
    $STD docker compose -p komodo -f "$COMPOSE_FILE" --env-file /opt/komodo/compose.env pull
    $STD docker compose -p komodo -f "$COMPOSE_FILE" --env-file /opt/komodo/compose.env up -d
--- a/ct/endurain.sh
+++ b/ct/endurain.sh
@@ -26,7 +26,7 @@ function update_script() {

  if [[ ! -d /opt/endurain ]]; then
    msg_error "No ${APP} installation found!"
-    exit 233
+    exit 1
  fi
  if check_for_gh_release "endurain" "endurain-project/endurain"; then
    msg_info "Stopping Service"
--- a/ct/evcc.sh
+++ b/ct/evcc.sh
@@ -25,7 +25,7 @@ function update_script() {
  check_container_resources
  if ! command -v evcc >/dev/null 2>&1; then
    msg_error "No ${APP} Installation Found!"
-    exit 233
+    exit 1
  fi

  if [[ -f /etc/apt/sources.list.d/evcc-stable.list ]]; then
--- a/ct/grafana.sh
+++ b/ct/grafana.sh
@@ -26,7 +26,7 @@ function update_script() {

  if ! dpkg -s grafana >/dev/null 2>&1; then
    msg_error "No ${APP} Installation Found!"
-    exit 233
+    exit 1
  fi

  if [[ -f /etc/apt/sources.list.d/grafana.list ]] || [[ ! -f /etc/apt/sources.list.d/grafana.sources ]]; then
--- a/ct/headers/profilarr
+++ b/ct/headers/profilarr
@@ -1,6 +0,0 @@
-    ____             _____ __               
-   / __ \_________  / __(_) /___ ___________
-  / /_/ / ___/ __ \/ /_/ / / __ `/ ___/ ___/
- / ____/ /  / /_/ / __/ / / /_/ / /  / /    
-/_/   /_/   \____/_/ /_/_/\__,_/_/  /_/     
-                                            
--- a/ct/itsm-ng.sh
+++ b/ct/itsm-ng.sh
@@ -26,7 +26,7 @@ function update_script() {

  if [[ ! -f /etc/itsm-ng/config_db.php ]]; then
    msg_error "No ${APP} Installation Found!"
-    exit 233
+    exit 1
  fi
  setup_mariadb

--- a/ct/kasm.sh
+++ b/ct/kasm.sh
@@ -45,7 +45,7 @@ function update_script() {
  
  if [[ -z "$KASM_URL" ]] || [[ -z "$KASM_VERSION" ]]; then
    msg_error "Unable to detect latest Kasm release URL."
-    exit 250
+    exit 1
  fi
  msg_info "Checked for new version"

--- a/ct/komodo.sh
+++ b/ct/komodo.sh
@@ -43,7 +43,7 @@ function update_script() {
    COMPOSE_FILE=$(find /opt/komodo -maxdepth 1 -type f -name '*.compose.yaml' ! -name 'compose.env' | head -n1)
    if [[ -z "$COMPOSE_FILE" ]]; then
      msg_error "No valid compose file found in /opt/komodo!"
-      exit 252
+      exit 1
    fi
    $STD docker compose -p komodo -f "$COMPOSE_FILE" --env-file /opt/komodo/compose.env pull
    $STD docker compose -p komodo -f "$COMPOSE_FILE" --env-file /opt/komodo/compose.env up -d
--- a/ct/loki.sh
+++ b/ct/loki.sh
@@ -26,7 +26,7 @@ function update_script() {

  if ! dpkg -s loki >/dev/null 2>&1; then
    msg_error "No ${APP} Installation Found!"
-    exit 233
+    exit 1
  fi

  CHOICE=$(msg_menu "Loki Update Options" \
--- a/ct/paperless-ngx.sh
+++ b/ct/paperless-ngx.sh
@@ -44,7 +44,7 @@ function update_script() {
      echo -e "${TAB}${GATEWAY}${BGN}https://github.com/community-scripts/ProxmoxVE/discussions/9223${CL}"
      echo -e ""
      msg_custom "⚠️" "Update aborted. Please migrate your data first."
-      exit 253
+      exit 1
    fi
  fi

--- a/ct/profilarr.sh
+++ b/ct/profilarr.sh
@@ -1,85 +0,0 @@
-#!/usr/bin/env bash
-source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func)
-# Copyright (c) 2021-2026 community-scripts ORG
-# Author: michelroegl-brunner
-# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
-# Source: https://github.com/Dictionarry-Hub/profilarr
-
-APP="Profilarr"
-var_tags="${var_tags:-arr;radarr;sonarr;config}"
-var_cpu="${var_cpu:-2}"
-var_ram="${var_ram:-2048}"
-var_disk="${var_disk:-8}"
-var_os="${var_os:-debian}"
-var_version="${var_version:-13}"
-var_unprivileged="${var_unprivileged:-1}"
-
-header_info "$APP"
-variables
-color
-catch_errors
-
-function update_script() {
-  header_info
-  check_container_storage
-  check_container_resources
-
-  if [[ ! -d /opt/profilarr ]]; then
-    msg_error "No ${APP} Installation Found!"
-    exit
-  fi
-
-  if check_for_gh_release "profilarr" "Dictionarry-Hub/profilarr"; then
-    msg_info "Stopping Service"
-    systemctl stop profilarr
-    msg_ok "Stopped Service"
-
-    msg_info "Backing up Data"
-    if [[ -d /config ]]; then
-      cp -r /config /opt/profilarr_config_backup
-    fi
-    msg_ok "Backed up Data"
-
-    CLEAN_INSTALL=1 fetch_and_deploy_gh_release "profilarr" "Dictionarry-Hub/profilarr" "tarball"
-
-    msg_info "Installing Python Dependencies"
-    cd /opt/profilarr/backend
-    $STD uv venv /opt/profilarr/backend/.venv
-    sed 's/==/>=/g' requirements.txt >requirements-relaxed.txt
-    $STD uv pip install --python /opt/profilarr/backend/.venv/bin/python -r requirements-relaxed.txt
-    rm -f requirements-relaxed.txt
-    msg_ok "Installed Python Dependencies"
-
-    msg_info "Building Frontend"
-    if [[ -d /opt/profilarr/frontend ]]; then
-      cd /opt/profilarr/frontend
-      $STD npm install
-      $STD npm run build
-      cp -r dist /opt/profilarr/backend/app/static
-    fi
-    msg_ok "Built Frontend"
-
-    msg_info "Restoring Data"
-    if [[ -d /opt/profilarr_config_backup ]]; then
-      mkdir -p /config
-      cp -r /opt/profilarr_config_backup/. /config/
-      rm -rf /opt/profilarr_config_backup
-    fi
-    msg_ok "Restored Data"
-
-    msg_info "Starting Service"
-    systemctl start profilarr
-    msg_ok "Started Service"
-    msg_ok "Updated successfully!"
-  fi
-  exit
-}
-
-start
-build_container
-description
-
-msg_ok "Completed Successfully!\n"
-echo -e "${CREATING}${GN}${APP} setup has been successfully initialized!${CL}"
-echo -e "${INFO}${YW} Access it using the following URL:${CL}"
-echo -e "${TAB}${GATEWAY}${BGN}http://${IP}:6868${CL}"
--- a/ct/vikunja.sh
+++ b/ct/vikunja.sh
@@ -34,14 +34,14 @@ function update_script() {
    msg_warn "This requires MANUAL config changes in /etc/vikunja/config.yml."
    msg_warn "See: https://vikunja.io/changelog/whats-new-in-vikunja-1.0.0/#config-changes"

-    read -rp "Continue with update? (y to proceed): " -t 30 CONFIRM1 || exit 254
+    read -rp "Continue with update? (y to proceed): " -t 30 CONFIRM1 || exit 1
    [[ "$CONFIRM1" =~ ^[yY]$ ]] || exit 0

    echo
    msg_warn "Vikunja may not start after the update until you manually adjust the config."
    msg_warn "Details: https://vikunja.io/changelog/whats-new-in-vikunja-1.0.0/#config-changes"

-    read -rp "Acknowledge and continue? (y): " -t 30 CONFIRM2 || exit 254
+    read -rp "Acknowledge and continue? (y): " -t 30 CONFIRM2 || exit 1
    [[ "$CONFIRM2" =~ ^[yY]$ ]] || exit 0
  fi

--- a/frontend/public/json/github-versions.json
+++ b/frontend/public/json/github-versions.json
@@ -1,5 +1,5 @@
 {
-  "generated": "2026-03-02T12:12:21Z",
+  "generated": "2026-03-02T06:20:15Z",
  "versions": [
    {
      "slug": "2fauth",
@@ -312,9 +312,9 @@
    {
      "slug": "domain-monitor",
      "repo": "Hosteroid/domain-monitor",
-      "version": "v1.1.4",
+      "version": "v1.1.3",
      "pinned": false,
-      "date": "2026-03-02T09:25:01Z"
+      "date": "2026-02-11T15:48:18Z"
    },
    {
      "slug": "donetick",
@@ -452,9 +452,9 @@
    {
      "slug": "gitea-mirror",
      "repo": "RayLabsHQ/gitea-mirror",
-      "version": "v3.11.0",
+      "version": "v3.10.1",
      "pinned": false,
-      "date": "2026-03-02T10:19:59Z"
+      "date": "2026-03-01T03:08:07Z"
    },
    {
      "slug": "glance",
@@ -634,9 +634,9 @@
    {
      "slug": "jotty",
      "repo": "fccview/jotty",
-      "version": "1.21.0",
+      "version": "1.20.0",
      "pinned": false,
-      "date": "2026-03-02T11:08:54Z"
+      "date": "2026-02-12T09:23:30Z"
    },
    {
      "slug": "kapowarr",
@@ -1156,13 +1156,6 @@
      "pinned": false,
      "date": "2025-11-12T07:10:14Z"
    },
-    {
-      "slug": "profilarr",
-      "repo": "Dictionarry-Hub/profilarr",
-      "version": "v1.1.4",
-      "pinned": false,
-      "date": "2026-01-29T14:57:25Z"
-    },
    {
      "slug": "projectsend",
      "repo": "projectsend/projectsend",
@@ -1425,9 +1418,9 @@
    {
      "slug": "snowshare",
      "repo": "TuroYT/snowshare",
-      "version": "v1.3.8",
+      "version": "v1.3.7",
      "pinned": false,
-      "date": "2026-03-02T07:43:42Z"
+      "date": "2026-02-23T15:51:39Z"
    },
    {
      "slug": "sonarr",
@@ -1663,9 +1656,9 @@
    {
      "slug": "victoriametrics",
      "repo": "VictoriaMetrics/VictoriaMetrics",
-      "version": "v1.137.0",
+      "version": "v1.136.0",
      "pinned": false,
-      "date": "2026-03-02T10:09:29Z"
+      "date": "2026-02-16T13:17:50Z"
    },
    {
      "slug": "vikunja",
@@ -1691,9 +1684,9 @@
    {
      "slug": "wanderer",
      "repo": "meilisearch/meilisearch",
-      "version": "v1.37.0",
+      "version": "v1.36.0",
      "pinned": false,
-      "date": "2026-03-02T09:16:36Z"
+      "date": "2026-02-23T08:13:32Z"
    },
    {
      "slug": "warracker",
@@ -1796,9 +1789,9 @@
    {
      "slug": "zigbee2mqtt",
      "repo": "Koenkk/zigbee2mqtt",
-      "version": "2.9.1",
+      "version": "2.9.0",
      "pinned": false,
-      "date": "2026-03-02T11:16:46Z"
+      "date": "2026-03-01T13:58:14Z"
    },
    {
      "slug": "zipline",
@@ -1810,9 +1803,9 @@
    {
      "slug": "zitadel",
      "repo": "zitadel/zitadel",
-      "version": "v4.12.0",
+      "version": "v4.11.1",
      "pinned": false,
-      "date": "2026-03-02T08:16:10Z"
+      "date": "2026-02-25T06:13:13Z"
    },
    {
      "slug": "zoraxy",
--- a/frontend/public/json/profilarr.json
+++ b/frontend/public/json/profilarr.json
@@ -1,35 +0,0 @@
-{
-  "name": "Profilarr",
-  "slug": "profilarr",
-  "categories": [
-    14
-  ],
-  "date_created": "2026-03-02",
-  "type": "ct",
-  "updateable": true,
-  "privileged": false,
-  "interface_port": 6868,
-  "documentation": "https://github.com/Dictionarry-Hub/profilarr#readme",
-  "website": "https://github.com/Dictionarry-Hub/profilarr",
-  "logo": "https://cdn.jsdelivr.net/gh/selfhst/icons@main/webp/profilarr.webp",
-  "config_path": "/config",
-  "description": "Profilarr is a configuration management platform for Radarr and Sonarr that simplifies importing, syncing, and managing quality profiles, custom formats, and release profiles.",
-  "install_methods": [
-    {
-      "type": "default",
-      "script": "ct/profilarr.sh",
-      "resources": {
-        "cpu": 2,
-        "ram": 2048,
-        "hdd": 8,
-        "os": "Debian",
-        "version": "13"
-      }
-    }
-  ],
-  "default_credentials": {
-    "username": null,
-    "password": null
-  },
-  "notes": []
-}
--- a/install/alpine-postgresql-install.sh
+++ b/install/alpine-postgresql-install.sh
@@ -14,7 +14,7 @@ network_check
 update_os

 read -r -p "${TAB3}Enter PostgreSQL version (15/16/17): " ver
-[[ $ver =~ ^(15|16|17)$ ]] || { echo "Invalid version"; exit 64; }
+[[ $ver =~ ^(15|16|17)$ ]] || { echo "Invalid version"; exit 1; }

 msg_info "Installing PostgreSQL ${ver}"
 $STD apk add --no-cache postgresql${ver} postgresql${ver}-contrib postgresql${ver}-openrc sudo
--- a/install/apache-tomcat-install.sh
+++ b/install/apache-tomcat-install.sh
@@ -25,7 +25,7 @@ case $version in
    ;;
  *)
    msg_error "Invalid JDK version selected. Please enter 8, 11, 17 or 21."
-    exit 64
+    exit 1
    ;;
  esac
  ;;
@@ -39,7 +39,7 @@ case $version in
    ;;
  *)
    msg_error "Invalid JDK version selected. Please enter 11, 17 or 21."
-    exit 64
+    exit 1
    ;;
  esac
  ;;
@@ -53,13 +53,13 @@ case $version in
    ;;
  *)
    msg_error "Invalid JDK version selected. Please enter 17 or 21."
-    exit 64
+    exit 1
    ;;
  esac
  ;;
 *)
  msg_error "Invalid Tomcat version selected. Please enter 9, 10.1 or 11."
-  exit 64
+  exit 1
  ;;
 esac

--- a/install/booklore-install.sh
+++ b/install/booklore-install.sh
@@ -59,7 +59,7 @@ mkdir -p /opt/booklore/dist
 JAR_PATH=$(find /opt/booklore/booklore-api/build/libs -maxdepth 1 -type f -name "booklore-api-*.jar" ! -name "*plain*" | head -n1)
 if [[ -z "$JAR_PATH" ]]; then
  msg_error "Backend JAR not found"
-  exit 153
+  exit 1
 fi
 cp "$JAR_PATH" /opt/booklore/dist/app.jar
 msg_ok "Built Backend"
--- a/install/docker-install.sh
+++ b/install/docker-install.sh
@@ -86,7 +86,7 @@ EOF
    msg_ok "Docker TCP socket available on $socket"
  else
    msg_error "Docker failed to restart. Check journalctl -xeu docker.service"
-    exit 150
+    exit 1
  fi
 fi

--- a/install/emqx-install.sh
+++ b/install/emqx-install.sh
@@ -21,7 +21,7 @@ msg_info "Fetching latest EMQX Enterprise version"
 LATEST_VERSION=$(curl -fsSL https://www.emqx.com/en/downloads/enterprise | grep -oP '/en/downloads/enterprise/v\K[0-9]+\.[0-9]+\.[0-9]+' | sort -V | tail -n1)
 if [[ -z "$LATEST_VERSION" ]]; then
  msg_error "Failed to determine latest EMQX version"
-  exit 250
+  exit 1
 fi
 msg_ok "Latest version: v$LATEST_VERSION"

--- a/install/frigate-install.sh
+++ b/install/frigate-install.sh
@@ -17,7 +17,7 @@ update_os
 source /etc/os-release
 if [[ "$VERSION_ID" != "12" ]]; then
  msg_error "Frigate requires Debian 12 (Bookworm) due to Python 3.11 dependencies"
-  exit 238
+  exit 1
 fi

 msg_info "Converting APT sources to DEB822 format"
--- a/install/kasm-install.sh
+++ b/install/kasm-install.sh
@@ -31,7 +31,7 @@ fi

 if [[ -z "$KASM_URL" ]] || [[ -z "$KASM_VERSION" ]]; then
  msg_error "Unable to detect latest Kasm release URL."
-  exit 250
+  exit 1
 fi
 msg_ok "Detected Kasm Workspaces version $KASM_VERSION"

--- a/install/mealie-install.sh
+++ b/install/mealie-install.sh
@@ -28,7 +28,7 @@ $STD apt install -y \
 msg_ok "Installed Dependencies"

 PYTHON_VERSION="3.12" setup_uv
-PG_VERSION="16" setup_postgresql
+POSTGRES_VERSION="16" setup_postgresql
 NODE_MODULE="yarn" NODE_VERSION="24" setup_nodejs
 fetch_and_deploy_gh_release "mealie" "mealie-recipes/mealie" "tarball" "latest" "/opt/mealie"
 PG_DB_NAME="mealie_db" PG_DB_USER="mealie_user" PG_DB_GRANT_SUPERUSER="true" setup_postgresql_db
--- a/install/npmplus-install.sh
+++ b/install/npmplus-install.sh
@@ -51,7 +51,7 @@ while true; do
  attempts=$((attempts + 1))
  if [[ "$attempts" -ge 3 ]]; then
    msg_error "Maximum attempts reached. Exiting."
-    exit 254
+    exit 1
  fi
 done

@@ -76,11 +76,11 @@ for i in {1..60}; do
    elif [[ "$STATUS" == "unhealthy" ]]; then
      msg_error "NPMplus container is unhealthy! Check logs."
      docker logs "$CONTAINER_ID"
-      exit 150
+      exit 1
    fi
  fi
  sleep 2
-  [[ $i -eq 60 ]] && msg_error "NPMplus container did not become healthy within 120s." && docker logs "$CONTAINER_ID" && exit 150
+  [[ $i -eq 60 ]] && msg_error "NPMplus container did not become healthy within 120s." && docker logs "$CONTAINER_ID" && exit 1
 done
 msg_ok "Builded and started NPMplus"

--- a/install/ollama-install.sh
+++ b/install/ollama-install.sh
@@ -78,11 +78,11 @@ if curl -fL# -C - -o "$TMP_TAR" "$OLLAMA_URL"; then
    msg_ok "Installed Ollama ${RELEASE}"
  else
    msg_error "Extraction failed – archive corrupt or incomplete"
-    exit 251
+    exit 1
  fi
 else
  msg_error "Download failed – $OLLAMA_URL not reachable"
-  exit 250
+  exit 1
 fi

 msg_info "Creating ollama User and Group"
--- a/install/onlyoffice-install.sh
+++ b/install/onlyoffice-install.sh
@@ -59,7 +59,7 @@ EOF
 else
  msg_error "Failed to download or verify GPG key from $KEY_URL"
  [[ -f "$TMP_KEY_CONTENT" ]] && rm -f "$TMP_KEY_CONTENT"
-  exit 250
+  exit 1
 fi
 rm -f "$TMP_KEY_CONTENT"

--- a/install/opencloud-install.sh
+++ b/install/opencloud-install.sh
@@ -34,7 +34,7 @@ for server in "${servers[@]}"; do
  done
  if ((attempt >= MAX_ATTEMPTS)); then
    msg_error "No more attempts - aborting script!"
-    exit 254
+    exit 1
  fi
 done

--- a/install/postgresql-install.sh
+++ b/install/postgresql-install.sh
@@ -16,7 +16,7 @@ update_os
 read -r -p "${TAB3}Enter PostgreSQL version (15/16/17/18): " ver
 [[ $ver =~ ^(15|16|17|18)$ ]] || {
  echo "Invalid version"
-  exit 64
+  exit 1
 }
 PG_VERSION=$ver setup_postgresql

--- a/install/profilarr-install.sh
+++ b/install/profilarr-install.sh
@@ -1,74 +0,0 @@
-#!/usr/bin/env bash
-
-# Copyright (c) 2021-2026 community-scripts ORG
-# Author: michelroegl-brunner
-# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
-# Source: https://github.com/Dictionarry-Hub/profilarr
-
-source /dev/stdin <<<"$FUNCTIONS_FILE_PATH"
-color
-verb_ip6
-catch_errors
-setting_up_container
-network_check
-update_os
-
-msg_info "Installing Dependencies"
-$STD apt install -y \
-  build-essential \
-  python3-dev \
-  libffi-dev \
-  libssl-dev \
-  git
-msg_ok "Installed Dependencies"
-
-PYTHON_VERSION="3.12" setup_uv
-NODE_VERSION="22" setup_nodejs
-
-msg_info "Creating directories"
-mkdir -p /opt/profilarr \
-  /config
-msg_ok "Created directories"
-
-fetch_and_deploy_gh_release "profilarr" "Dictionarry-Hub/profilarr" "tarball"
-
-msg_info "Installing Python Dependencies"
-cd /opt/profilarr/backend
-$STD uv venv /opt/profilarr/backend/.venv
-sed 's/==/>=/g' requirements.txt >requirements-relaxed.txt
-$STD uv pip install --python /opt/profilarr/backend/.venv/bin/python -r requirements-relaxed.txt
-rm -f requirements-relaxed.txt
-msg_ok "Installed Python Dependencies"
-
-msg_info "Building Frontend"
-cd /opt/profilarr/frontend
-$STD npm install
-$STD npm run build
-cp -r dist /opt/profilarr/backend/app/static
-msg_ok "Built Frontend"
-
-msg_info "Creating Service"
-cat <<EOF >/etc/systemd/system/profilarr.service
-[Unit]
-Description=Profilarr - Configuration Management Platform for Radarr/Sonarr
-After=network.target
-
-[Service]
-Type=simple
-User=root
-WorkingDirectory=/opt/profilarr/backend
-Environment="PATH=/opt/profilarr/backend/.venv/bin:/usr/local/bin:/usr/bin:/bin"
-Environment="PYTHONPATH=/opt/profilarr/backend"
-ExecStart=/opt/profilarr/backend/.venv/bin/gunicorn --bind 0.0.0.0:6868 --timeout 600 app.main:create_app()
-Restart=on-failure
-RestartSec=5
-
-[Install]
-WantedBy=multi-user.target
-EOF
-systemctl enable -q --now profilarr
-msg_ok "Created Service"
-
-motd_ssh
-customize
-cleanup_lxc
--- a/install/pulse-install.sh
+++ b/install/pulse-install.sh
@@ -25,7 +25,7 @@ if useradd -r -m -d /opt/pulse-home -s /usr/sbin/nologin pulse; then
  msg_ok "Created User"
 else
  msg_error "User creation failed"
-  exit 71
+  exit 1
 fi

 mkdir -p /etc/pulse
--- a/install/splunk-enterprise-install.sh
+++ b/install/splunk-enterprise-install.sh
@@ -34,7 +34,7 @@ while true; do
        [Nn]|[Nn][Oo]|"")
            msg_error "Terms not accepted. Installation cannot proceed."
            msg_error "Please review the terms and run the script again if you wish to proceed."
-            exit 254
+            exit 1
            ;;
        *)
            msg_error "Invalid response. Please enter 'y' for yes or 'n' for no."
@@ -47,7 +47,7 @@ DOWNLOAD_URL=$(curl -s "https://www.splunk.com/en_us/download/splunk-enterprise.
 RELEASE=$(echo "$DOWNLOAD_URL" | sed 's|.*/releases/\([^/]*\)/.*|\1|')
 $STD curl -fsSL -o "splunk-enterprise.tgz" "$DOWNLOAD_URL" || {
    msg_error "Failed to download Splunk Enterprise from the provided link."
-    exit 250
+    exit 1
 }
 $STD tar -xzf "splunk-enterprise.tgz" -C /opt
 rm -f "splunk-enterprise.tgz"
--- a/install/unifi-os-server-install.sh
+++ b/install/unifi-os-server-install.sh
@@ -16,13 +16,13 @@ update_os
 if [[ "${CTTYPE:-1}" != "0" ]]; then
  msg_error "UniFi OS Server requires a privileged LXC container."
  msg_error "Recreate the container with unprivileged=0."
-  exit 10
+  exit 1
 fi

 if [[ ! -e /dev/net/tun ]]; then
  msg_error "Missing /dev/net/tun in container."
  msg_error "Enable TUN/TAP (var_tun=yes) or add /dev/net/tun passthrough."
-  exit 236
+  exit 1
 fi

 msg_info "Installing dependencies"
@@ -48,7 +48,7 @@ TEMP_JSON="$(mktemp)"
 if ! curl -fsSL "$API_URL" -o "$TEMP_JSON"; then
  rm -f "$TEMP_JSON"
  msg_error "Failed to fetch data from Ubiquiti API"
-  exit 250
+  exit 1
 fi
 LATEST=$(jq -r '
  ._embedded.firmware
@@ -62,7 +62,7 @@ UOS_URL=$(echo "$LATEST" | jq -r '._links.data.href')
 rm -f "$TEMP_JSON"
 if [[ -z "$UOS_URL" || -z "$UOS_VERSION" || "$UOS_URL" == "null" ]]; then
  msg_error "Failed to parse UniFi OS Server version or download URL"
-  exit 250
+  exit 1
 fi
 msg_ok "Found UniFi OS Server ${UOS_VERSION}"

--- a/install/zerotier-one-install.sh
+++ b/install/zerotier-one-install.sh
@@ -31,7 +31,7 @@ if gpg --verify /tmp/zerotier-install.sh >/dev/null 2>&1; then
  $STD bash /tmp/zerotier-install.sh
 else
  msg_warn "Could not verify signature of Zerotier-One install script. Exiting..."
-  exit 250
+  exit 1
 fi
 msg_ok "Setup Zerotier-One"

--- a/misc/api.func
+++ b/misc/api.func
@@ -134,7 +134,6 @@ detect_repo_source
 #   * Proxmox custom codes (200-231)
 #   * Tools & Addon Scripts (232-238)
 #   * Node.js/npm errors (239, 243, 245-249)
-#   * Application Install/Update errors (250-254)
 # - Returns description string for given exit code
 # ------------------------------------------------------------------------------
 explain_exit_code() {
@@ -323,13 +322,6 @@ explain_exit_code() {
  248) echo "Node.js: Invalid C++ addon / N-API failure" ;;
  249) echo "npm/pnpm/yarn: Unknown fatal error" ;;

-  # --- Application Install/Update Errors (250-254) ---
-  250) echo "App: Download failed or version not determined" ;;
-  251) echo "App: File extraction failed (corrupt or incomplete archive)" ;;
-  252) echo "App: Required file or resource not found" ;;
-  253) echo "App: Data migration required — update aborted" ;;
-  254) echo "App: User declined prompt or input timed out" ;;
-
  # --- DPKG ---
  255) echo "DPKG: Fatal internal error" ;;

@@ -393,11 +385,6 @@ get_error_text() {
    logfile="$BUILD_LOG"
  fi

-  # Try SILENT_LOGFILE as last resort (captures $STD command output)
-  if [[ -z "$logfile" || ! -s "$logfile" ]] && [[ -n "${SILENT_LOGFILE:-}" && -s "${SILENT_LOGFILE}" ]]; then
-    logfile="$SILENT_LOGFILE"
-  fi
-
  if [[ -n "$logfile" && -s "$logfile" ]]; then
    tail -n 20 "$logfile" 2>/dev/null | sed 's/\r$//' | sed 's/\x1b\[[0-9;]*[a-zA-Z]//g'
  fi
@@ -443,13 +430,6 @@ get_full_log() {
    fi
  fi

-  # Fall back to SILENT_LOGFILE (captures $STD command output)
-  if [[ -z "$logfile" || ! -s "$logfile" ]]; then
-    if [[ -n "${SILENT_LOGFILE:-}" && -s "${SILENT_LOGFILE}" ]]; then
-      logfile="$SILENT_LOGFILE"
-    fi
-  fi
-
  if [[ -n "$logfile" && -s "$logfile" ]]; then
    # Strip ANSI codes, carriage returns, and anonymize IP addresses (GDPR)
    sed 's/\r$//' "$logfile" 2>/dev/null |
@@ -888,7 +868,7 @@ post_update_to_api() {
  esac

  # For failed/unknown status, resolve exit code and error description
-  local short_error="" medium_error=""
+  local short_error=""
  if [[ "$pb_status" == "failed" ]] || [[ "$pb_status" == "unknown" ]]; then
    if [[ "$raw_exit_code" =~ ^[0-9]+$ ]]; then
      exit_code="$raw_exit_code"
@@ -908,18 +888,6 @@ post_update_to_api() {
    short_error=$(json_escape "$(explain_exit_code "$exit_code")")
    error_category=$(categorize_error "$exit_code")
    [[ -z "$error" ]] && error="Unknown error"
-
-    # Build medium error for attempt 2: explanation + last 100 log lines (≤16KB)
-    # This is the critical middle ground between full 120KB log and generic-only description
-    local medium_log=""
-    medium_log=$(get_full_log 16384) || true # 16KB max
-    if [[ -z "$medium_log" ]]; then
-      medium_log=$(get_error_text) || true
-    fi
-    local medium_full
-    medium_full=$(build_error_string "$exit_code" "$medium_log")
-    medium_error=$(json_escape "$medium_full")
-    [[ -z "$medium_error" ]] && medium_error="$short_error"
  fi

  # Calculate duration if timer was started
@@ -978,7 +946,7 @@ EOF
    return 0
  fi

-  # ── Attempt 2: Medium error text (truncated log ≤16KB instead of full 120KB) ──
+  # ── Attempt 2: Short error text (no full log) ──
  sleep 1
  local RETRY_PAYLOAD
  RETRY_PAYLOAD=$(
@@ -998,7 +966,7 @@ EOF
    "pve_version": "${pve_version}",
    "method": "${METHOD:-default}",
    "exit_code": ${exit_code},
-    "error": "${medium_error}",
+    "error": "${short_error}",
    "error_category": "${error_category}",
    "install_duration": ${duration},
    "cpu_vendor": "${cpu_vendor}",
@@ -1021,7 +989,7 @@ EOF
    return 0
  fi

-  # ── Attempt 3: Minimal payload with medium error (bare minimum to set status) ──
+  # ── Attempt 3: Minimal payload (bare minimum to set status) ──
  sleep 2
  local MINIMAL_PAYLOAD
  MINIMAL_PAYLOAD=$(
@@ -1033,7 +1001,7 @@ EOF
    "nsapp": "${NSAPP:-unknown}",
    "status": "${pb_status}",
    "exit_code": ${exit_code},
-    "error": "${medium_error}",
+    "error": "${short_error}",
    "error_category": "${error_category}",
    "install_duration": ${duration}
 }
--- a/misc/build.func
+++ b/misc/build.func
@@ -4094,8 +4094,21 @@ EOF'
    # that sends "configuring" status AFTER the host already reported "failed"
    export CONTAINER_INSTALLING=true

-    lxc-attach -n "$CTID" -- bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/install/${var_install}.sh)"
-    local lxc_exit=$?
+    # Capture lxc-attach terminal output to host-side log via tee.
+    # This is the ONLY reliable way to get install output when:
+    #   - install.func fails to load (DNS error) → no container-side logging
+    #   - install script crashes before logging starts
+    #   - $STD/silent() not used for some commands
+    # PIPESTATUS[0] gets the real exit code from lxc-attach (not from tee).
+    # Note: stdin is redirected from /dev/null so the pipeline does not consume
+    # the host's stdin/tty. This keeps /dev/tty usable for the recovery menu
+    # after SIGINT or failure (prevents "read: read error: Input/output error").
+    local _LXC_CAPTURE_LOG="/tmp/.install-capture-${SESSION_ID}.log"
+    lxc-attach -n "$CTID" -- bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/install/${var_install}.sh)" </dev/null 2>&1 | tee "$_LXC_CAPTURE_LOG"
+    local lxc_exit=${PIPESTATUS[0]}
+
+    # Restore terminal state after pipeline (tee/lxc-attach may leave it broken)
+    stty sane 2>/dev/null || true

    unset CONTAINER_INSTALLING

@@ -4157,9 +4170,19 @@ EOF'
        build_log_copied=true
      fi

-      # Copy and append INSTALL_LOG from container
+      # Copy and append INSTALL_LOG from container (with timeout to prevent hangs)
      local temp_install_log="/tmp/.install-temp-${SESSION_ID}.log"
-      if pct pull "$CTID" "/root/.install-${SESSION_ID}.log" "$temp_install_log" 2>/dev/null; then
+      local container_log_ok=false
+      if timeout 8 pct pull "$CTID" "/root/.install-${SESSION_ID}.log" "$temp_install_log" 2>/dev/null; then
+        # Only use container log if it has meaningful content (>100 bytes)
+        if [[ -s "$temp_install_log" ]] && [[ $(stat -c%s "$temp_install_log" 2>/dev/null || echo 0) -gt 100 ]]; then
+          container_log_ok=true
+        fi
+      fi
+
+      # PHASE 2: Use container-side log if available, otherwise use host-captured tee output
+      local _LXC_CAPTURE_LOG="/tmp/.install-capture-${SESSION_ID}.log"
+      if [[ "$container_log_ok" == true ]]; then
        {
          echo "================================================================================"
          echo "PHASE 2: APPLICATION INSTALLATION (Container)"
@@ -4167,8 +4190,24 @@ EOF'
          cat "$temp_install_log"
          echo ""
        } >>"$combined_log"
-        rm -f "$temp_install_log"
        install_log_copied=true
+      elif [[ -s "$_LXC_CAPTURE_LOG" ]]; then
+        # Fallback: host-captured terminal output from lxc-attach
+        # This captures everything the user saw, including errors when install.func
+        # failed to load (DNS issues, etc.) and no container-side logging was set up.
+        {
+          echo "================================================================================"
+          echo "PHASE 2: APPLICATION INSTALLATION (Container - captured from terminal)"
+          echo "================================================================================"
+          # Strip ANSI escape codes from terminal capture
+          sed 's/\x1b\[[0-9;]*[a-zA-Z]//g' "$_LXC_CAPTURE_LOG" | sed 's/\r$//'
+          echo ""
+        } >>"$combined_log"
+        install_log_copied=true
+      fi
+      rm -f "$temp_install_log"
+
+      if [[ "$install_log_copied" == true ]]; then
        # Point INSTALL_LOG to combined log so get_full_log() finds it
        INSTALL_LOG="$combined_log"
      fi
@@ -4354,8 +4393,10 @@ EOF'
    echo ""
    echo -en "${YW}Select option [1-${max_option}] (default: 1, auto-remove in 60s): ${CL}"

-    local response=""
-    if read -t 60 -r response; then
+    # Ensure terminal is sane before reading input (lxc-attach|tee may corrupt tty state)
+    stty sane 2>/dev/null || true
+
+    if read -t 60 -r response </dev/tty; then
      case "${response:-1}" in
      1)
        # Remove container
@@ -4442,8 +4483,10 @@ EOF'
          # Re-run install script in existing container (don't destroy/recreate)
          set +Eeuo pipefail
          trap - ERR
-          lxc-attach -n "$CTID" -- bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/install/${var_install}.sh)"
-          local apt_retry_exit=$?
+          local _LXC_CAPTURE_LOG="/tmp/.install-capture-${SESSION_ID}.log"
+          lxc-attach -n "$CTID" -- bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/install/${var_install}.sh)" </dev/null 2>&1 | tee "$_LXC_CAPTURE_LOG"
+          local apt_retry_exit=${PIPESTATUS[0]}
+          stty sane 2>/dev/null || true
          set -Eeuo pipefail
          trap 'error_handler' ERR

@@ -4553,6 +4596,9 @@ EOF'
    exit $install_exit_code
  fi

+  # Clean up host-side capture log (not needed on success, already in combined_log on failure)
+  rm -f "/tmp/.install-capture-${SESSION_ID}.log" 2>/dev/null
+
  # Re-enable error handling after successful install or recovery menu completion
  set -Eeuo pipefail
  trap 'error_handler' ERR
--- a/misc/error_handler.func
+++ b/misc/error_handler.func
@@ -195,14 +195,6 @@ if ! declare -f explain_exit_code &>/dev/null; then
    247) echo "Node.js: Fatal internal error" ;;
    248) echo "Node.js: Invalid C++ addon / N-API failure" ;;
    249) echo "npm/pnpm/yarn: Unknown fatal error" ;;
-
-    # --- Application Install/Update Errors (250-254) ---
-    250) echo "App: Download failed or version not determined" ;;
-    251) echo "App: File extraction failed (corrupt or incomplete archive)" ;;
-    252) echo "App: Required file or resource not found" ;;
-    253) echo "App: Data migration required — update aborted" ;;
-    254) echo "App: User declined prompt or input timed out" ;;
-
    255) echo "DPKG: Fatal internal error" ;;
    *) echo "Unknown error" ;;
    esac
@@ -327,9 +319,7 @@ error_handler() {
        echo -en "${YW}Remove broken container ${CTID}? (Y/n) [auto-remove in 60s]: ${CL}"
      fi

-      # Read user response
-      local response=""
-      if read -t 60 -r response; then
+      if read -t 60 -r response </dev/tty; then
        if [[ -z "$response" || "$response" =~ ^[Yy]$ ]]; then
          echo ""
          if declare -f msg_info >/dev/null 2>&1; then
@@ -408,29 +398,10 @@ _send_abort_telemetry() {
  [[ "${DIAGNOSTICS:-no}" == "no" ]] && return 0
  [[ -z "${RANDOM_UUID:-}" ]] && return 0

-  # Collect last 200 log lines for error diagnosis (best-effort)
-  # Container context has no get_full_log(), so we gather as much as possible
+  # Collect last 20 log lines for error diagnosis (best-effort)
  local error_text=""
-  local logfile=""
  if [[ -n "${INSTALL_LOG:-}" && -s "${INSTALL_LOG}" ]]; then
-    logfile="${INSTALL_LOG}"
-  elif [[ -n "${SILENT_LOGFILE:-}" && -s "${SILENT_LOGFILE}" ]]; then
-    logfile="${SILENT_LOGFILE}"
-  fi
-
-  if [[ -n "$logfile" ]]; then
-    error_text=$(tail -n 200 "$logfile" 2>/dev/null | sed 's/\x1b\[[0-9;]*[a-zA-Z]//g; s/\\/\\\\/g; s/"/\\"/g; s/\r//g' | tr '\n' '|' | sed 's/|$//' | head -c 16384 | tr -d '\000-\010\013\014\016-\037\177') || true
-  fi
-
-  # Prepend exit code explanation header (like build_error_string does on host)
-  local explanation=""
-  if declare -f explain_exit_code &>/dev/null; then
-    explanation=$(explain_exit_code "$exit_code" 2>/dev/null) || true
-  fi
-  if [[ -n "$explanation" && -n "$error_text" ]]; then
-    error_text="exit_code=${exit_code} | ${explanation}|---|${error_text}"
-  elif [[ -n "$explanation" && -z "$error_text" ]]; then
-    error_text="exit_code=${exit_code} | ${explanation}"
+    error_text=$(tail -n 20 "$INSTALL_LOG" 2>/dev/null | sed 's/\x1b\[[0-9;]*[a-zA-Z]//g; s/\\/\\\\/g; s/"/\\"/g; s/\r//g' | tr '\n' '|' | sed 's/|$//' | tr -d '\000-\010\013\014\016-\037\177') || true
  fi

  # Calculate duration if start time is available
@@ -439,17 +410,10 @@ _send_abort_telemetry() {
    duration=$(($(date +%s) - DIAGNOSTICS_START_TIME))
  fi

-  # Categorize error if function is available (may not be in minimal container context)
-  local error_category=""
-  if declare -f categorize_error &>/dev/null; then
-    error_category=$(categorize_error "$exit_code" 2>/dev/null) || true
-  fi
-
  # Build JSON payload with error context
  local payload
  payload="{\"random_id\":\"${RANDOM_UUID}\",\"execution_id\":\"${EXECUTION_ID:-${RANDOM_UUID}}\",\"type\":\"${TELEMETRY_TYPE:-lxc}\",\"nsapp\":\"${NSAPP:-${app:-unknown}}\",\"status\":\"failed\",\"exit_code\":${exit_code}"
  [[ -n "$error_text" ]] && payload="${payload},\"error\":\"${error_text}\""
-  [[ -n "$error_category" ]] && payload="${payload},\"error_category\":\"${error_category}\""
  [[ -n "$duration" ]] && payload="${payload},\"duration\":${duration}"
  payload="${payload}}"

--- a/misc/tools.func
+++ b/misc/tools.func
@@ -934,11 +934,7 @@ upgrade_package() {
 # ------------------------------------------------------------------------------
 # Repository availability check with caching
 # ------------------------------------------------------------------------------
-# Note: Must use -gA (global) because tools.func is sourced inside update_os()
-# function scope. Plain 'declare -A' would create a local variable that gets
-# destroyed when update_os() returns, causing "unbound variable" errors later
-# when setup_postgresql/verify_repo_available tries to access the cache key.
-declare -gA _REPO_CACHE 2>/dev/null || declare -A _REPO_CACHE 2>/dev/null || true
+declare -A _REPO_CACHE 2>/dev/null || true

 verify_repo_available() {
  local repo_url="$1"
@@ -1736,13 +1732,6 @@ setup_deb822_repo() {
      rm -f "$tmp_gpg"
      return 1
    }
-  else
-    # Already binary — copy directly
-    cp -f "$tmp_gpg" "/etc/apt/keyrings/${name}.gpg" || {
-      msg_error "Failed to install GPG key for ${name}"
-      rm -f "$tmp_gpg"
-      return 1
-    }
  fi
  rm -f "$tmp_gpg"
  chmod 644 "/etc/apt/keyrings/${name}.gpg"
@@ -5654,20 +5643,20 @@ function setup_mongodb() {
 #   - Handles Debian Trixie libaio1t64 transition
 #
 # Variables:
-#   USE_MYSQL_REPO - Use official MySQL repository (default: true)
-#                    Set to "false" to use distro packages instead
+#   USE_MYSQL_REPO - Set to "true" to use official MySQL repository
+#                    (default: false, uses distro packages)
 #   MYSQL_VERSION  - MySQL version to install when using official repo
 #                    (e.g. 8.0, 8.4) (default: 8.0)
 #
 # Examples:
-#   setup_mysql                              # Uses official MySQL repo, 8.0
-#   MYSQL_VERSION="8.4" setup_mysql          # Specific version from MySQL repo
-#   USE_MYSQL_REPO=false setup_mysql         # Uses distro package instead
+#   setup_mysql                              # Uses distro package (recommended)
+#   USE_MYSQL_REPO=true setup_mysql          # Uses official MySQL repo
+#   USE_MYSQL_REPO=true MYSQL_VERSION="8.4" setup_mysql  # Specific version
 # ------------------------------------------------------------------------------

 function setup_mysql() {
  local MYSQL_VERSION="${MYSQL_VERSION:-8.0}"
-  local USE_MYSQL_REPO="${USE_MYSQL_REPO:-true}"
+  local USE_MYSQL_REPO="${USE_MYSQL_REPO:-false}"
  local DISTRO_ID DISTRO_CODENAME
  DISTRO_ID=$(awk -F= '/^ID=/{print $2}' /etc/os-release | tr -d '"')
  DISTRO_CODENAME=$(awk -F= '/^VERSION_CODENAME=/{print $2}' /etc/os-release)
@@ -6368,21 +6357,21 @@ EOF
 #   - Restores dumped data post-upgrade
 #
 # Variables:
-#   USE_PGDG_REPO  - Use official PGDG repository (default: true)
-#                    Set to "false" to use distro packages instead
+#   USE_PGDG_REPO  - Set to "true" to use official PGDG repository
+#                    (default: false, uses distro packages)
 #   PG_VERSION    - Major PostgreSQL version (e.g. 15, 16) (default: 16)
 #   PG_MODULES    - Comma-separated list of modules (e.g. "postgis,contrib")
 #
 # Examples:
-#   setup_postgresql                              # Uses PGDG repo, PG 16
-#   PG_VERSION="17" setup_postgresql               # Specific version from PGDG
-#   USE_PGDG_REPO=false setup_postgresql           # Uses distro package instead
+#   setup_postgresql                              # Uses distro package (recommended)
+#   USE_PGDG_REPO=true setup_postgresql           # Uses official PGDG repo
+#   USE_PGDG_REPO=true PG_VERSION="17" setup_postgresql  # Specific version from PGDG
 # ------------------------------------------------------------------------------

 function setup_postgresql() {
  local PG_VERSION="${PG_VERSION:-16}"
  local PG_MODULES="${PG_MODULES:-}"
-  local USE_PGDG_REPO="${USE_PGDG_REPO:-true}"
+  local USE_PGDG_REPO="${USE_PGDG_REPO:-false}"
  local DISTRO_ID DISTRO_CODENAME
  DISTRO_ID=$(awk -F= '/^ID=/{print $2}' /etc/os-release | tr -d '"')
  DISTRO_CODENAME=$(awk -F= '/^VERSION_CODENAME=/{print $2}' /etc/os-release)
Author	SHA1	Message	Date
CanbiZ (MickLesk)	55ebf5cd90	Use specific exit codes in VM scripts Replace generic exit 1 with distinct exit codes across vm/*.sh to make failures more actionable for callers. Changes include: use 226 for missing imported-disk references, 237 for pv installation failures, 115 for download/extract/ISO-related failures, 214 for insufficient disk space during FreeBSD decompression, and 119 for missing storage detection. Updated scripts: archlinux-vm.sh, docker-vm.sh, haos-vm.sh, openwrt-vm.sh, opnsense-vm.sh, truenas-vm.sh, umbrel-os-vm.sh.	2026-03-02 10:18:44 +01:00
CanbiZ (MickLesk)	592f0d1f53	Use exit 105 for unsupported PVE versions Standardize error handling by replacing generic exit 1 with exit 105 in pve_check() across multiple VM template scripts to indicate unsupported Proxmox VE versions. Also add API exit code 226 message for "Proxmox: VM disk import or post-creation setup failed" in misc/api.func. Affected files include misc/api.func and various vm/*-vm.sh scripts.	2026-03-02 10:16:58 +01:00
CanbiZ (MickLesk)	c06dab5339	Standardize exit codes and behaviors Adjust exit codes and abort handling across multiple PVE helper scripts to provide clearer outcomes for automation and interactive flows. Changes include: - container-restore-from-backup.sh, core-restore-from-backup.sh: return 235 when no backups found (was 1). - fstrim.sh: treat user cancellation of non-ext4 warning as non-error (exit 0 instead of 1). - kernel-clean.sh: treat no selection or user abort as non-error (exit 0 instead of 1). - lxc-delete.sh: return 234 when no containers are present; treat no selection as non-error (exit 0). - nic-offloading-fix.sh: use specific non-zero codes for root check and tool install failures (exit 104, 237) and 236 when no matching interfaces (was 1). - pbs_microcode.sh, post-pmg-install.sh, post-pbs-install.sh: use distinct exit codes (232 and 105) for detected VM/PVE/unsupported distro conditions instead of generic 1. These modifications make scripts return distinct codes for different failure modes and ensure user-initiated aborts or benign conditions exit with 0 where appropriate.	2026-03-02 10:02:41 +01:00
CanbiZ (MickLesk)	99d8a7eef3	Use specific exit codes in PVE scripts Replace generic exit 1 with distinct exit codes across tools/pve scripts to provide clearer failure signals for callers. post-pve-install.sh now returns 105 for unsupported Proxmox versions; pve-privilege-converter.sh uses 104 for non-root, 234 when no containers, and 235 for backup/conversion failures; update-apps.sh maps backup failures to 235, missing containers/selections to 234 (and UI cancellations to 0), missing backup storage to 119, and returns the actual container update exit code on failure. These changes improve diagnostics and allow external tooling to react to specific error conditions.	2026-03-02 10:01:09 +01:00
CanbiZ (MickLesk)	3aba5f3209	Use specific exit codes in addon scripts Replace generic exit 1 with specific exit codes across multiple addon scripts to improve error signaling and handling. Files updated: tools/addon/add-netbird-lxc.sh (exit 238 on unsupported distro), tools/addon/add-tailscale-lxc.sh (treat user cancel as exit 0), tools/addon/glances.sh (exit 233 when not installed), tools/addon/komodo.sh (distinct exits for missing compose, legacy DB, backup/download failures, docker checks), tools/addon/netdata.sh (distinct exits for unsupported PVE versions, OS/codename detection, repo lookups), and tools/addon/phpmyadmin.sh (distinct exits for unsupported OS, network/download issues, package install/start failures, and invalid input). These changes make failures easier to identify and automate recovery or reporting.	2026-03-02 09:59:23 +01:00
CanbiZ (MickLesk)	4f735a9a23	Use specific exit codes in addon scripts Replace generic exit 1 with distinct exit codes across multiple addon scripts to enable finer-grained error handling in automation. Exit codes introduced: 10 for Docker/Compose missing or user-declined Docker install, 233 for "nothing to update" cases, and 238 for unsupported OS cases. Affected files: tools/addon/arcane.sh, coolify.sh, dockge.sh, dokploy.sh, filebrowser-quantum.sh, filebrowser.sh, immich-public-proxy.sh, jellystat.sh, runtipi.sh.	2026-03-02 09:56:08 +01:00
CanbiZ (MickLesk)	c742d61de2	Standardize exit codes in exporter addons Unify exit codes across exporter addon scripts: return 238 for unsupported OS detections and 233 when an update is requested but the exporter is not installed. Applied to nextcloud-exporter.sh, pihole-exporter.sh, prometheus-paperless-ngx-exporter.sh, and qbittorrent-exporter.sh to make failure modes distinguishable for callers/automation.	2026-03-02 09:54:27 +01:00
CanbiZ (MickLesk)	bdf97e9499	Add tools/addon exit codes and use them Introduce exit codes 232-238 for Tools & Addon scripts in misc/api.func and misc/error_handler.func. Update addon scripts (tools/addon/adguardhome-sync.sh, tools/addon/copyparty.sh, tools/addon/cronmaster.sh) to return specific codes instead of generic exit 1: 238 for unsupported OS and 233 when the application is not installed/upgrade prerequisites are missing. This makes failures more descriptive and aligns scripts with the central error explanations.	2026-03-02 09:54:15 +01:00
CanbiZ (MickLesk)	4d3fc03961	Set exit code 115 for update_os errors Change exit status from 6 to 115 in misc/alpine-install.func's update_os() error handlers when failing to download tools.func or when the expected functions are missing. This gives a distinct exit code for these specific failure cases.	2026-03-02 09:41:44 +01:00
CanbiZ (MickLesk)	ce2a253053	Standardize exit codes and add mappings Replace generic exit 1 usages with specific numeric exit codes and add corresponding explanations to the error lookup. This commit updates multiple misc/* scripts to return distinct codes for validation, Proxmox/LXC, networking, download and curl errors (e.g. 103-123, 64, 107-120, 206, 0 for explicit user cancels). It also updates curl error handling to propagate the original curl exit code and adds new entries in explain_exit_code and the error handler to improve diagnostics.	2026-03-02 09:41:03 +01:00