Compare commits

..

3 Commits

Author SHA1 Message Date
MickLesk
2258cfb910 fix(build): add missing -searchdomain/-nameserver prefix in base_settings
base_settings() set SD and NS as raw values from var_searchdomain/var_ns,
but build_container() expects them with -searchdomain=/-nameserver= prefix.
When using MyDefaults or AppDefaults code paths (which skip
advanced_settings()), the values ended up as unprefixed positional
arguments in the pct create command, causing '400 too many arguments'.

advanced_settings() already added the prefix correctly, so only
default/saved-defaults paths were affected.

Ref #13135
2026-03-21 19:18:24 +01:00
community-scripts-pr-app[bot]
06c99d43a2 Update CHANGELOG.md (#13149)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2026-03-21 05:00:25 +00:00
Copilot
2854494dc5 Isponsorblocktv: use quoted heredoc to prevent unbound variable error during CLI wrapper creation (#13146)
* Initial plan

* fix: use quoted heredoc in isponsorblocktv CLI wrapper to prevent unbound variable error

Co-authored-by: MickLesk <47820557+MickLesk@users.noreply.github.com>
Agent-Logs-Url: https://github.com/community-scripts/ProxmoxVE/sessions/78e2f706-8a17-478d-aca5-c3550b0e37ca

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MickLesk <47820557+MickLesk@users.noreply.github.com>
2026-03-21 06:00:01 +01:00
2 changed files with 12 additions and 2 deletions

View File

@@ -423,6 +423,14 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit
</details>
## 2026-03-21
### 🚀 Updated Scripts
- #### 🐞 Bug Fixes
- Isponsorblocktv: use quoted heredoc to prevent unbound variable error during CLI wrapper creation [@Copilot](https://github.com/Copilot) ([#13146](https://github.com/community-scripts/ProxmoxVE/pull/13146))
## 2026-03-20
### 🆕 New Scripts

View File

@@ -985,8 +985,10 @@ base_settings() {
fi
MTU=${var_mtu:-""}
SD=${var_searchdomain:-""}
NS=${var_ns:-""}
_sd_val="${var_searchdomain:-""}"
[[ -n "$_sd_val" ]] && SD="-searchdomain=$_sd_val" || SD=""
_ns_val="${var_ns:-""}"
[[ -n "$_ns_val" ]] && NS="-nameserver=$_ns_val" || NS=""
MAC=${var_mac:-""}
VLAN=${var_vlan:-""}
SSH=${var_ssh:-"no"}