mirror of
https://github.com/community-scripts/ProxmoxVE.git
synced 2026-03-03 17:35:55 +01:00
* fix(error-handler): prevent silent() from re-enabling error handling during recovery Root cause: silent() (core.func) unconditionally calls set -Eeuo pipefail and trap 'error_handler' ERR after every command. When build_container() intentionally disables error handling for its recovery section, any intermediate call through silent()/ re-enables it. This causes the grep/sed pipeline for missing_cmd extraction to trigger error_handler (grep returns exit code 1 on no match + pipefail = fatal). Fixes: 1. silent(): Save errexit state before disabling, only restore if it was active. Callers that intentionally disabled error handling (e.g. build_container recovery) are no longer silently re-enabled. 2. build.func: Add || true to missing_cmd grep pipeline as defense-in-depth against pipeline failure propagation. 3. build.func: Add explicit set +Eeuo pipefail / trap - ERR after post_update_to_api() call, before error classification grep/sed section. 4. build.func: Remove stale global combined_log variable from variables() that used a different path format (/tmp/install-SESSION-combined.log) than the actual local variable (/tmp/NSAPP-CTID-SESSION.log). The global was never written to and caused confusion when error_handler displayed it. * Update build.func * chore(install): add Github source links to all setup_nodejs scripts 52 install scripts had a project website in '# Source:' but no GitHub link. Merged the GitHub repo URL into the Source header as: # Source: https://website.com/ | Github: https://github.com/OWNER/REPO Repos sourced from fetch_and_deploy_gh_release calls, get_latest_github_release calls, or known project repos for npm/pip installed apps. Two scripts (fumadocs, pve-scripts-local) had no Source line at all — added one. Shinobi skipped (GitLab-only, no GitHub repo). * chore(install): add Github source links to all fetch_and_deploy scripts 77 additional install scripts had fetch_and_deploy_gh_release calls but no GitHub link in the Source header. Merged the primary app repo into the Source header as: # Source: https://website.com/ | Github: https://github.com/OWNER/REPO Where multiple fetch_and_deploy calls existed (app + dependency), the primary app repo was selected: - ersatztv: ErsatzTV/ErsatzTV (not ffmpeg) - firefly: firefly-iii/firefly-iii (not data-importer) - komga: gotson/komga (not kepubify dep) - sabnzbd: sabnzbd/sabnzbd (not par2cmdline-turbo dep) - signoz: SigNoz/signoz (not otel-collector) - tunarr: chrisbenincasa/tunarr (not ffmpeg dep) Also fixed cosmos-install.sh double https:// in Source URL. Skipped: autocaliweb (source already on codeberg, GitHub repos are deps only) * revert: restore misc/build.func and misc/core.func to main state These error-handler fixes belong to fix/error-handler-recovery, not to this sources-only branch. * chore(ct,tools): sync Source headers with install/ and add Github links to addon scripts
208 lines
5.4 KiB
Bash
208 lines
5.4 KiB
Bash
#!/usr/bin/env bash
|
||
|
||
# Copyright (c) 2021-2026 tteck
|
||
# Author: tteck (tteckster) | MickLesk (CanbiZ)
|
||
# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
|
||
# Source: https://nicolargo.github.io/glances/ | Github: https://github.com/nicolargo/glances
|
||
|
||
function header_info {
|
||
clear
|
||
cat <<"EOF"
|
||
________
|
||
/ ____/ /___ _____ ________ _____
|
||
/ / __/ / __ `/ __ \/ ___/ _ \/ ___/
|
||
/ /_/ / / /_/ / / / / /__/ __(__ )
|
||
\____/_/\__,_/_/ /_/\___/\___/____/
|
||
|
||
EOF
|
||
}
|
||
|
||
APP="Glances"
|
||
YW=$(echo "\033[33m")
|
||
GN=$(echo "\033[1;92m")
|
||
RD=$(echo "\033[01;31m")
|
||
BL=$(echo "\033[36m")
|
||
CL=$(echo "\033[m")
|
||
CM="${GN}✔️${CL}"
|
||
CROSS="${RD}✖️${CL}"
|
||
INFO="${BL}ℹ️${CL}"
|
||
|
||
function msg_info() { echo -e "${INFO} ${YW}$1...${CL}"; }
|
||
function msg_ok() { echo -e "${CM} ${GN}$1${CL}"; }
|
||
function msg_error() { echo -e "${CROSS} ${RD}$1${CL}"; }
|
||
|
||
# Telemetry
|
||
source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/api.func) 2>/dev/null || true
|
||
declare -f init_tool_telemetry &>/dev/null && init_tool_telemetry "glances" "addon"
|
||
|
||
get_lxc_ip() {
|
||
if command -v hostname >/dev/null 2>&1 && hostname -I 2>/dev/null; then
|
||
hostname -I | awk '{print $1}'
|
||
elif command -v ip >/dev/null 2>&1; then
|
||
ip -4 addr show scope global | awk '/inet / {print $2}' | cut -d/ -f1 | head -n1
|
||
else
|
||
echo "127.0.0.1"
|
||
fi
|
||
}
|
||
IP=$(get_lxc_ip)
|
||
|
||
install_glances_debian() {
|
||
msg_info "Installing dependencies"
|
||
apt-get update >/dev/null 2>&1
|
||
apt-get install -y gcc lm-sensors wireless-tools curl >/dev/null 2>&1
|
||
msg_ok "Installed dependencies"
|
||
|
||
msg_info "Setting up Python + uv"
|
||
source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/tools.func)
|
||
setup_uv PYTHON_VERSION="3.12"
|
||
msg_ok "Setup Python + uv"
|
||
|
||
msg_info "Installing $APP (with web UI)"
|
||
cd /opt
|
||
mkdir -p glances
|
||
cd glances
|
||
uv venv --clear
|
||
source .venv/bin/activate >/dev/null 2>&1
|
||
uv pip install --upgrade pip wheel setuptools >/dev/null 2>&1
|
||
uv pip install "glances[web]" >/dev/null 2>&1
|
||
deactivate
|
||
msg_ok "Installed $APP"
|
||
|
||
msg_info "Creating systemd service"
|
||
cat <<EOF >/etc/systemd/system/glances.service
|
||
[Unit]
|
||
Description=Glances - An eye on your system
|
||
After=network.target
|
||
|
||
[Service]
|
||
Type=simple
|
||
ExecStart=/opt/glances/.venv/bin/glances -w
|
||
Restart=on-failure
|
||
WorkingDirectory=/opt/glances
|
||
|
||
[Install]
|
||
WantedBy=multi-user.target
|
||
EOF
|
||
systemctl enable -q --now glances
|
||
msg_ok "Created systemd service"
|
||
|
||
echo -e "\n$APP is now running at: http://$IP:61208\n"
|
||
}
|
||
|
||
# update on Debian/Ubuntu
|
||
update_glances_debian() {
|
||
if [[ ! -d /opt/glances/.venv ]]; then
|
||
msg_error "$APP is not installed"
|
||
exit 1
|
||
fi
|
||
msg_info "Updating $APP"
|
||
cd /opt/glances
|
||
source .venv/bin/activate
|
||
uv pip install --upgrade "glances[web]" >/dev/null 2>&1
|
||
deactivate
|
||
systemctl restart glances
|
||
msg_ok "Updated successfully!"
|
||
}
|
||
|
||
# uninstall on Debian/Ubuntu
|
||
uninstall_glances_debian() {
|
||
msg_info "Uninstalling $APP"
|
||
systemctl disable -q --now glances || true
|
||
rm -f /etc/systemd/system/glances.service
|
||
rm -rf /opt/glances
|
||
msg_ok "Removed $APP"
|
||
}
|
||
|
||
# install on Alpine
|
||
install_glances_alpine() {
|
||
msg_info "Installing dependencies"
|
||
apk update >/dev/null 2>&1
|
||
$STD apk add --no-cache \
|
||
gcc musl-dev linux-headers python3-dev \
|
||
python3 py3-pip py3-virtualenv lm-sensors wireless-tools curl >/dev/null 2>&1
|
||
msg_ok "Installed dependencies"
|
||
|
||
msg_info "Setting up Python + uv"
|
||
source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/tools.func)
|
||
setup_uv PYTHON_VERSION="3.12"
|
||
msg_ok "Setup Python + uv"
|
||
|
||
msg_info "Installing $APP (with web UI)"
|
||
cd /opt
|
||
mkdir -p glances
|
||
cd glances
|
||
uv venv --clear
|
||
source .venv/bin/activate
|
||
uv pip install --upgrade pip wheel setuptools >/dev/null 2>&1
|
||
uv pip install "glances[web]" >/dev/null 2>&1
|
||
deactivate
|
||
msg_ok "Installed $APP"
|
||
|
||
msg_info "Creating OpenRC service"
|
||
cat <<'EOF' >/etc/init.d/glances
|
||
#!/sbin/openrc-run
|
||
command="/opt/glances/.venv/bin/glances"
|
||
command_args="-w"
|
||
command_background="yes"
|
||
pidfile="/run/glances.pid"
|
||
name="glances"
|
||
description="Glances monitoring tool"
|
||
EOF
|
||
chmod +x /etc/init.d/glances
|
||
rc-update add glances default
|
||
rc-service glances start
|
||
msg_ok "Created OpenRC service"
|
||
|
||
echo -e "\n$APP is now running at: http://$IP:61208\n"
|
||
}
|
||
|
||
# update on Alpine
|
||
update_glances_alpine() {
|
||
if [[ ! -d /opt/glances/.venv ]]; then
|
||
msg_error "$APP is not installed"
|
||
exit 1
|
||
fi
|
||
msg_info "Updating $APP"
|
||
cd /opt/glances
|
||
source .venv/bin/activate
|
||
uv pip install --upgrade "glances[web]" >/dev/null 2>&1
|
||
deactivate
|
||
rc-service glances restart
|
||
msg_ok "Updated successfully!"
|
||
}
|
||
|
||
# uninstall on Alpine
|
||
uninstall_glances_alpine() {
|
||
msg_info "Uninstalling $APP"
|
||
rc-service glances stop || true
|
||
rc-update del glances || true
|
||
rm -f /etc/init.d/glances
|
||
rm -rf /opt/glances
|
||
msg_ok "Removed $APP"
|
||
}
|
||
|
||
# options menu
|
||
OPTIONS=(Install "Install $APP"
|
||
Update "Update $APP"
|
||
Uninstall "Uninstall $APP")
|
||
|
||
CHOICE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --title "$APP" --menu "Select an option:" 12 58 3 \
|
||
"${OPTIONS[@]}" 3>&1 1>&2 2>&3 || true)
|
||
|
||
# OS detection
|
||
if grep -qi "alpine" /etc/os-release; then
|
||
case "$CHOICE" in
|
||
Install) install_glances_alpine ;;
|
||
Update) update_glances_alpine ;;
|
||
Uninstall) uninstall_glances_alpine ;;
|
||
*) exit 0 ;;
|
||
esac
|
||
else
|
||
case "$CHOICE" in
|
||
Install) install_glances_debian ;;
|
||
Update) update_glances_debian ;;
|
||
Uninstall) uninstall_glances_debian ;;
|
||
*) exit 0 ;;
|
||
esac
|
||
fi
|