mirror of
https://github.com/community-scripts/ProxmoxVE.git
synced 2026-03-02 17:05:55 +01:00
5dc244a8c1
* Standardize exit codes and add mappings Replace generic exit 1 usages with specific numeric exit codes and add corresponding explanations to the error lookup. This commit updates multiple misc/* scripts to return distinct codes for validation, Proxmox/LXC, networking, download and curl errors (e.g. 103-123, 64, 107-120, 206, 0 for explicit user cancels). It also updates curl error handling to propagate the original curl exit code and adds new entries in explain_exit_code and the error handler to improve diagnostics. * Set exit code 115 for update_os errors Change exit status from 6 to 115 in misc/alpine-install.func's update_os() error handlers when failing to download tools.func or when the expected functions are missing. This gives a distinct exit code for these specific failure cases. * Add tools/addon exit codes and use them Introduce exit codes 232-238 for Tools & Addon scripts in misc/api.func and misc/error_handler.func. Update addon scripts (tools/addon/adguardhome-sync.sh, tools/addon/copyparty.sh, tools/addon/cronmaster.sh) to return specific codes instead of generic exit 1: 238 for unsupported OS and 233 when the application is not installed/upgrade prerequisites are missing. This makes failures more descriptive and aligns scripts with the central error explanations. * Standardize exit codes in exporter addons Unify exit codes across exporter addon scripts: return 238 for unsupported OS detections and 233 when an update is requested but the exporter is not installed. Applied to nextcloud-exporter.sh, pihole-exporter.sh, prometheus-paperless-ngx-exporter.sh, and qbittorrent-exporter.sh to make failure modes distinguishable for callers/automation. * Use specific exit codes in addon scripts Replace generic exit 1 with distinct exit codes across multiple addon scripts to enable finer-grained error handling in automation. Exit codes introduced: 10 for Docker/Compose missing or user-declined Docker install, 233 for "nothing to update" cases, and 238 for unsupported OS cases. Affected files: tools/addon/arcane.sh, coolify.sh, dockge.sh, dokploy.sh, filebrowser-quantum.sh, filebrowser.sh, immich-public-proxy.sh, jellystat.sh, runtipi.sh. * Use specific exit codes in addon scripts Replace generic exit 1 with specific exit codes across multiple addon scripts to improve error signaling and handling. Files updated: tools/addon/add-netbird-lxc.sh (exit 238 on unsupported distro), tools/addon/add-tailscale-lxc.sh (treat user cancel as exit 0), tools/addon/glances.sh (exit 233 when not installed), tools/addon/komodo.sh (distinct exits for missing compose, legacy DB, backup/download failures, docker checks), tools/addon/netdata.sh (distinct exits for unsupported PVE versions, OS/codename detection, repo lookups), and tools/addon/phpmyadmin.sh (distinct exits for unsupported OS, network/download issues, package install/start failures, and invalid input). These changes make failures easier to identify and automate recovery or reporting. * Use specific exit codes in PVE scripts Replace generic exit 1 with distinct exit codes across tools/pve scripts to provide clearer failure signals for callers. post-pve-install.sh now returns 105 for unsupported Proxmox versions; pve-privilege-converter.sh uses 104 for non-root, 234 when no containers, and 235 for backup/conversion failures; update-apps.sh maps backup failures to 235, missing containers/selections to 234 (and UI cancellations to 0), missing backup storage to 119, and returns the actual container update exit code on failure. These changes improve diagnostics and allow external tooling to react to specific error conditions. * Standardize exit codes and behaviors Adjust exit codes and abort handling across multiple PVE helper scripts to provide clearer outcomes for automation and interactive flows. Changes include: - container-restore-from-backup.sh, core-restore-from-backup.sh: return 235 when no backups found (was 1). - fstrim.sh: treat user cancellation of non-ext4 warning as non-error (exit 0 instead of 1). - kernel-clean.sh: treat no selection or user abort as non-error (exit 0 instead of 1). - lxc-delete.sh: return 234 when no containers are present; treat no selection as non-error (exit 0). - nic-offloading-fix.sh: use specific non-zero codes for root check and tool install failures (exit 104, 237) and 236 when no matching interfaces (was 1). - pbs_microcode.sh, post-pmg-install.sh, post-pbs-install.sh: use distinct exit codes (232 and 105) for detected VM/PVE/unsupported distro conditions instead of generic 1. These modifications make scripts return distinct codes for different failure modes and ensure user-initiated aborts or benign conditions exit with 0 where appropriate. * Use exit 105 for unsupported PVE versions Standardize error handling by replacing generic exit 1 with exit 105 in pve_check() across multiple VM template scripts to indicate unsupported Proxmox VE versions. Also add API exit code 226 message for "Proxmox: VM disk import or post-creation setup failed" in misc/api.func. Affected files include misc/api.func and various vm/*-vm.sh scripts. * Use specific exit codes in VM scripts Replace generic exit 1 with distinct exit codes across vm/*.sh to make failures more actionable for callers. Changes include: use 226 for missing imported-disk references, 237 for pv installation failures, 115 for download/extract/ISO-related failures, 214 for insufficient disk space during FreeBSD decompression, and 119 for missing storage detection. Updated scripts: archlinux-vm.sh, docker-vm.sh, haos-vm.sh, openwrt-vm.sh, opnsense-vm.sh, truenas-vm.sh, umbrel-os-vm.sh.
86 lines
2.4 KiB
Bash
86 lines
2.4 KiB
Bash
#!/usr/bin/env bash
|
|
# Copyright (c) 2021-2026 community-scripts ORG
|
|
# Author: MickLesk
|
|
# License: MIT
|
|
# https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
|
|
|
|
function header_info {
|
|
clear
|
|
cat <<"EOF"
|
|
__ __ __ ________
|
|
/ //_/__ _________ ___ / / / ____/ /__ ____ _____
|
|
/ ,< / _ \/ ___/ __ \/ _ \/ / / / / / _ \/ __ `/ __ \
|
|
/ /| / __/ / / / / / __/ / / /___/ / __/ /_/ / / / /
|
|
/_/ |_\___/_/ /_/ /_/\___/_/ \____/_/\___/\__,_/_/ /_/
|
|
|
|
EOF
|
|
}
|
|
|
|
# Color variables
|
|
YW="\033[33m"
|
|
GN="\033[1;92m"
|
|
RD="\033[01;31m"
|
|
CL="\033[m"
|
|
|
|
# Telemetry
|
|
source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/api.func) 2>/dev/null || true
|
|
declare -f init_tool_telemetry &>/dev/null && init_tool_telemetry "kernel-clean" "pve"
|
|
|
|
# Detect current kernel
|
|
current_kernel=$(uname -r)
|
|
available_kernels=$(dpkg --list | grep 'kernel-.*-pve' | awk '{print $2}' | grep -v "$current_kernel" | sort -V)
|
|
|
|
header_info
|
|
|
|
if [ -z "$available_kernels" ]; then
|
|
echo -e "${GN}No old kernels detected. Current kernel: ${current_kernel}${CL}"
|
|
exit 0
|
|
fi
|
|
|
|
echo -e "${GN}Currently running kernel: ${current_kernel}${CL}"
|
|
echo -e "${YW}Available kernels for removal:${CL}"
|
|
echo "$available_kernels" | nl -w 2 -s '. '
|
|
|
|
echo -e "\n${YW}Select kernels to remove (comma-separated, e.g., 1,2):${CL}"
|
|
read -r selected
|
|
|
|
# Parse selection
|
|
IFS=',' read -r -a selected_indices <<<"$selected"
|
|
kernels_to_remove=()
|
|
|
|
for index in "${selected_indices[@]}"; do
|
|
kernel=$(echo "$available_kernels" | sed -n "${index}p")
|
|
if [ -n "$kernel" ]; then
|
|
kernels_to_remove+=("$kernel")
|
|
fi
|
|
done
|
|
|
|
if [ ${#kernels_to_remove[@]} -eq 0 ]; then
|
|
echo -e "${RD}No valid selection made. Exiting.${CL}"
|
|
exit 0
|
|
fi
|
|
|
|
# Confirm removal
|
|
echo -e "${YW}Kernels to be removed:${CL}"
|
|
printf "%s\n" "${kernels_to_remove[@]}"
|
|
read -rp "Proceed with removal? (y/n): " confirm
|
|
if [[ "$confirm" != "y" ]]; then
|
|
echo -e "${RD}Aborted.${CL}"
|
|
exit 0
|
|
fi
|
|
|
|
# Remove kernels
|
|
for kernel in "${kernels_to_remove[@]}"; do
|
|
echo -e "${YW}Removing $kernel...${CL}"
|
|
if apt-get purge -y "$kernel" >/dev/null 2>&1; then
|
|
echo -e "${GN}Successfully removed: $kernel${CL}"
|
|
else
|
|
echo -e "${RD}Failed to remove: $kernel. Check dependencies.${CL}"
|
|
fi
|
|
done
|
|
|
|
# Clean up and update GRUB
|
|
echo -e "${YW}Cleaning up...${CL}"
|
|
apt-get autoremove -y >/dev/null 2>&1 && update-grub >/dev/null 2>&1
|
|
echo -e "${GN}Cleanup and GRUB update complete.${CL}"
|