mirror of
https://github.com/community-scripts/ProxmoxVE.git
synced 2026-02-25 06:25:56 +01:00
dbdd891a99
* fix(error-handler): prevent silent() from re-enabling error handling during recovery Root cause: silent() (core.func) unconditionally calls set -Eeuo pipefail and trap 'error_handler' ERR after every command. When build_container() intentionally disables error handling for its recovery section, any intermediate call through silent()/ re-enables it. This causes the grep/sed pipeline for missing_cmd extraction to trigger error_handler (grep returns exit code 1 on no match + pipefail = fatal). Fixes: 1. silent(): Save errexit state before disabling, only restore if it was active. Callers that intentionally disabled error handling (e.g. build_container recovery) are no longer silently re-enabled. 2. build.func: Add || true to missing_cmd grep pipeline as defense-in-depth against pipeline failure propagation. 3. build.func: Add explicit set +Eeuo pipefail / trap - ERR after post_update_to_api() call, before error classification grep/sed section. 4. build.func: Remove stale global combined_log variable from variables() that used a different path format (/tmp/install-SESSION-combined.log) than the actual local variable (/tmp/NSAPP-CTID-SESSION.log). The global was never written to and caused confusion when error_handler displayed it. * Update build.func * chore(install): add Github source links to all setup_nodejs scripts 52 install scripts had a project website in '# Source:' but no GitHub link. Merged the GitHub repo URL into the Source header as: # Source: https://website.com/ | Github: https://github.com/OWNER/REPO Repos sourced from fetch_and_deploy_gh_release calls, get_latest_github_release calls, or known project repos for npm/pip installed apps. Two scripts (fumadocs, pve-scripts-local) had no Source line at all — added one. Shinobi skipped (GitLab-only, no GitHub repo). * chore(install): add Github source links to all fetch_and_deploy scripts 77 additional install scripts had fetch_and_deploy_gh_release calls but no GitHub link in the Source header. Merged the primary app repo into the Source header as: # Source: https://website.com/ | Github: https://github.com/OWNER/REPO Where multiple fetch_and_deploy calls existed (app + dependency), the primary app repo was selected: - ersatztv: ErsatzTV/ErsatzTV (not ffmpeg) - firefly: firefly-iii/firefly-iii (not data-importer) - komga: gotson/komga (not kepubify dep) - sabnzbd: sabnzbd/sabnzbd (not par2cmdline-turbo dep) - signoz: SigNoz/signoz (not otel-collector) - tunarr: chrisbenincasa/tunarr (not ffmpeg dep) Also fixed cosmos-install.sh double https:// in Source URL. Skipped: autocaliweb (source already on codeberg, GitHub repos are deps only) * revert: restore misc/build.func and misc/core.func to main state These error-handler fixes belong to fix/error-handler-recovery, not to this sources-only branch. * chore(ct,tools): sync Source headers with install/ and add Github links to addon scripts
90 lines
3.1 KiB
Bash
90 lines
3.1 KiB
Bash
#!/usr/bin/env bash
|
|
source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func)
|
|
# Copyright (c) 2021-2026 community-scripts ORG
|
|
# Author: bvdberg01
|
|
# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
|
|
# Source: https://koillection.github.io/ | Github: https://github.com/benjaminjonard/koillection
|
|
|
|
APP="Koillection"
|
|
var_tags="${var_tags:-network}"
|
|
var_cpu="${var_cpu:-2}"
|
|
var_ram="${var_ram:-1024}"
|
|
var_disk="${var_disk:-8}"
|
|
var_os="${var_os:-debian}"
|
|
var_version="${var_version:-13}"
|
|
var_unprivileged="${var_unprivileged:-1}"
|
|
|
|
header_info "$APP"
|
|
variables
|
|
color
|
|
catch_errors
|
|
|
|
function update_script() {
|
|
header_info
|
|
check_container_storage
|
|
check_container_resources
|
|
if [[ ! -d /opt/koillection ]]; then
|
|
msg_error "No ${APP} Installation Found!"
|
|
exit
|
|
fi
|
|
if check_for_gh_release "koillection" "benjaminjonard/koillection"; then
|
|
msg_info "Stopping Service"
|
|
systemctl stop apache2
|
|
msg_ok "Stopped Service"
|
|
|
|
PHP_VERSION="8.5" PHP_APACHE="YES" setup_php
|
|
setup_composer
|
|
|
|
msg_info "Creating a backup"
|
|
mv /opt/koillection/ /opt/koillection-backup
|
|
msg_ok "Backup created"
|
|
|
|
fetch_and_deploy_gh_release "koillection" "benjaminjonard/koillection" "tarball"
|
|
|
|
msg_info "Updating Koillection"
|
|
cd /opt/koillection
|
|
cp -r /opt/koillection-backup/.env.local /opt/koillection
|
|
cp -r /opt/koillection-backup/public/uploads/. /opt/koillection/public/uploads/
|
|
|
|
# Ensure APP_RUNTIME is in .env.local for CLI commands (upgrades from older versions)
|
|
if ! grep -q "APP_RUNTIME" /opt/koillection/.env.local 2>/dev/null; then
|
|
echo 'APP_RUNTIME="Symfony\Component\Runtime\SymfonyRuntime"' >> /opt/koillection/.env.local
|
|
fi
|
|
|
|
export COMPOSER_ALLOW_SUPERUSER=1
|
|
export APP_RUNTIME='Symfony\Component\Runtime\SymfonyRuntime'
|
|
$STD composer install --no-dev -o --no-interaction --classmap-authoritative
|
|
$STD php bin/console doctrine:migrations:migrate --no-interaction
|
|
$STD php bin/console app:translations:dump
|
|
cd assets/
|
|
$STD yarn install
|
|
$STD yarn build
|
|
mkdir -p /opt/koillection/public/uploads
|
|
mkdir -p /opt/koillection/var/log
|
|
chown -R www-data:www-data /opt/koillection/var/log
|
|
chown -R www-data:www-data /opt/koillection/public/uploads
|
|
rm -r /opt/koillection-backup
|
|
|
|
# Ensure APP_RUNTIME is set in Apache config (for upgrades from older versions)
|
|
if ! grep -q "APP_RUNTIME" /etc/apache2/sites-available/koillection.conf 2>/dev/null; then
|
|
sed -i '/<VirtualHost/a\ SetEnv APP_RUNTIME "Symfony\\Component\\Runtime\\SymfonyRuntime"' /etc/apache2/sites-available/koillection.conf
|
|
fi
|
|
msg_ok "Updated Koillection"
|
|
|
|
msg_info "Starting Service"
|
|
systemctl start apache2
|
|
msg_ok "Started Service"
|
|
msg_ok "Updated successfully!"
|
|
fi
|
|
exit
|
|
}
|
|
|
|
start
|
|
build_container
|
|
description
|
|
|
|
msg_ok "Completed successfully!\n"
|
|
echo -e "${CREATING}${GN}${APP} setup has been successfully initialized!${CL}"
|
|
echo -e "${INFO}${YW} Access it using the following URL:${CL}"
|
|
echo -e "${TAB}${GATEWAY}${BGN}http://${IP}${CL}"
|