mirror of
https://github.com/community-scripts/ProxmoxVE.git
synced 2026-03-06 10:55:56 +01:00
99d8a7eef3
Replace generic exit 1 with distinct exit codes across tools/pve scripts to provide clearer failure signals for callers. post-pve-install.sh now returns 105 for unsupported Proxmox versions; pve-privilege-converter.sh uses 104 for non-root, 234 when no containers, and 235 for backup/conversion failures; update-apps.sh maps backup failures to 235, missing containers/selections to 234 (and UI cancellations to 0), missing backup storage to 119, and returns the actual container update exit code on failure. These changes improve diagnostics and allow external tooling to react to specific error conditions.
476 lines
16 KiB
Bash
476 lines
16 KiB
Bash
#!/usr/bin/env bash
|
|
|
|
# Copyright (c) 2021-2026 community-scripts ORG
|
|
# Author: BvdBerg01 | Co-Author: remz1337
|
|
# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
|
|
|
|
source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/refs/heads/main/misc/core.func)
|
|
source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/api.func) 2>/dev/null || true
|
|
declare -f init_tool_telemetry &>/dev/null && init_tool_telemetry "update-apps" "pve"
|
|
|
|
# =============================================================================
|
|
# CONFIGURATION VARIABLES
|
|
# Set these variables to skip interactive prompts (Whiptail dialogs)
|
|
# =============================================================================
|
|
# var_backup: Enable/disable backup before update
|
|
# Options: "yes" | "no" | "" (empty = interactive prompt)
|
|
var_backup="${var_backup:-}"
|
|
|
|
# var_backup_storage: Storage location for backups (only used if var_backup=yes)
|
|
# Options: Storage name from /etc/pve/storage.cfg (e.g., "local", "nas-backup")
|
|
# Leave empty for interactive selection
|
|
var_backup_storage="${var_backup_storage:-}"
|
|
|
|
# var_container: Which containers to update
|
|
# Options:
|
|
# - "all" : All containers with community-scripts tags
|
|
# - "all_running" : Only running containers with community-scripts tags
|
|
# - "all_stopped" : Only stopped containers with community-scripts tags
|
|
# - "101,102,109" : Comma-separated list of specific container IDs
|
|
# - "" : Interactive selection via Whiptail
|
|
var_container="${var_container:-}"
|
|
|
|
# var_unattended: Run updates without user interaction inside containers
|
|
# Options: "yes" | "no" | "" (empty = interactive prompt)
|
|
var_unattended="${var_unattended:-}"
|
|
|
|
# var_skip_confirm: Skip initial confirmation dialog
|
|
# Options: "yes" | "no" (default: no)
|
|
var_skip_confirm="${var_skip_confirm:-no}"
|
|
|
|
# var_auto_reboot: Automatically reboot containers that require it after update
|
|
# Options: "yes" | "no" | "" (empty = interactive prompt)
|
|
var_auto_reboot="${var_auto_reboot:-}"
|
|
|
|
# var_tags: Optionally override the tags used for auto-detection
|
|
# Options: "community-script|proxmox-helper-scripts" (default)
|
|
var_tags="${var_tags:-community-script|proxmox-helper-scripts}"
|
|
# =============================================================================
|
|
# JSON CONFIG EXPORT
|
|
# Run with --export-config to output current configuration as JSON
|
|
# =============================================================================
|
|
|
|
function export_config_json() {
|
|
cat <<EOF
|
|
{
|
|
"var_backup": "${var_backup}",
|
|
"var_backup_storage": "${var_backup_storage}",
|
|
"var_container": "${var_container}",
|
|
"var_unattended": "${var_unattended}",
|
|
"var_skip_confirm": "${var_skip_confirm}",
|
|
"var_auto_reboot": "${var_auto_reboot}",
|
|
"var_tags": "${var_tags}"
|
|
}
|
|
EOF
|
|
}
|
|
|
|
function print_usage() {
|
|
cat <<EOF
|
|
Usage: $(basename "$0") [OPTIONS]
|
|
|
|
Update LXC containers created with community-scripts.
|
|
|
|
Options:
|
|
--help Show this help message
|
|
--export-config Export current configuration as JSON
|
|
|
|
Environment Variables:
|
|
var_backup Enable backup before update (yes/no)
|
|
var_backup_storage Storage location for backups
|
|
var_container Container selection (all/all_running/all_stopped/101,102,...)
|
|
var_unattended Run updates unattended (yes/no)
|
|
var_skip_confirm Skip initial confirmation (yes/no)
|
|
var_auto_reboot Auto-reboot containers if required (yes/no)
|
|
var_tags Optionally override auto-detection tags ("prod|smb|community-script")
|
|
|
|
Examples:
|
|
# Run interactively
|
|
$(basename "$0")
|
|
|
|
# Update all running containers unattended with backup
|
|
var_backup=yes var_backup_storage=local var_container=all_running var_unattended=yes var_skip_confirm=yes $(basename "$0")
|
|
|
|
# Update specific containers without backup
|
|
var_backup=no var_container=101,102,105 var_unattended=yes var_skip_confirm=yes $(basename "$0")
|
|
|
|
# Export current configuration
|
|
$(basename "$0") --export-config
|
|
EOF
|
|
}
|
|
|
|
# Handle command line arguments
|
|
case "${1:-}" in
|
|
--help | -h)
|
|
print_usage
|
|
exit 0
|
|
;;
|
|
--export-config)
|
|
export_config_json
|
|
exit 0
|
|
;;
|
|
esac
|
|
|
|
# =============================================================================
|
|
|
|
function header_info {
|
|
clear
|
|
cat <<"EOF"
|
|
__ _ ________ __ __ __ __
|
|
/ / | |/ / ____/ / / / /___ ____/ /___ _/ /____
|
|
/ / | / / / / / / __ \/ __ / __ `/ __/ _ \
|
|
/ /___/ / /___ / /_/ / /_/ / /_/ / /_/ / /_/ __/
|
|
/_____/_/|_\____/ \____/ .___/\__,_/\__,_/\__/\___/
|
|
/_/
|
|
EOF
|
|
}
|
|
|
|
function detect_service() {
|
|
pushd $(mktemp -d) >/dev/null
|
|
pct pull "$1" /usr/bin/update update 2>/dev/null
|
|
service=$(cat update | sed 's|.*/ct/||g' | sed 's|\.sh).*||g')
|
|
popd >/dev/null
|
|
}
|
|
|
|
function backup_container() {
|
|
msg_info "Creating backup for container $1"
|
|
vzdump $1 --compress zstd --storage $STORAGE_CHOICE -notes-template "{{guestname}} - community-scripts backup updater" >/dev/null 2>&1
|
|
status=$?
|
|
|
|
if [ $status -eq 0 ]; then
|
|
msg_ok "Backup created"
|
|
else
|
|
msg_error "Backup failed for container $1"
|
|
exit 235
|
|
fi
|
|
}
|
|
|
|
function get_backup_storages() {
|
|
STORAGES=$(awk '
|
|
/^[a-z]+:/ {
|
|
if (name != "") {
|
|
if (has_backup || (!has_content && type == "dir")) print name
|
|
}
|
|
split($0, a, ":")
|
|
type = a[1]
|
|
name = a[2]
|
|
gsub(/^[ \t]+|[ \t]+$/, "", name)
|
|
has_content = 0
|
|
has_backup = 0
|
|
}
|
|
/^[ \t]*content/ {
|
|
has_content = 1
|
|
if ($0 ~ /backup/) has_backup = 1
|
|
}
|
|
END {
|
|
if (name != "") {
|
|
if (has_backup || (!has_content && type == "dir")) print name
|
|
}
|
|
}
|
|
' /etc/pve/storage.cfg)
|
|
}
|
|
|
|
header_info
|
|
|
|
# Skip confirmation if var_skip_confirm is set to yes
|
|
if [[ "$var_skip_confirm" != "yes" ]]; then
|
|
whiptail --backtitle "Proxmox VE Helper Scripts" --title "LXC App Update" --yesno "This will update apps in LXCs installed by Helper-Scripts. Proceed?" 10 58 || exit
|
|
fi
|
|
|
|
tags_formatted="${var_tags//|/, }"
|
|
msg_info "Loading all possible LXC containers from Proxmox VE with tags: ${tags_formatted}. This may take a few seconds..."
|
|
NODE=$(hostname)
|
|
containers=$(pct list | tail -n +2 | awk '{print $0 " " $4}')
|
|
|
|
if [ -z "$containers" ]; then
|
|
whiptail --title "LXC Container Update" --msgbox "No LXC containers available!" 10 60
|
|
exit 234
|
|
fi
|
|
|
|
menu_items=()
|
|
FORMAT="%-10s %-15s %-10s"
|
|
TAGS="${var_tags:-community-script|proxmox-helper-scripts}"
|
|
|
|
while read -r container; do
|
|
container_id=$(echo $container | awk '{print $1}')
|
|
container_name=$(echo $container | awk '{print $2}')
|
|
container_status=$(echo $container | awk '{print $3}')
|
|
formatted_line=$(printf "$FORMAT" "$container_name" "$container_status")
|
|
if pct config "$container_id" | grep -qE "[^-][; ](${TAGS}).*"; then
|
|
menu_items+=("$container_id" "$formatted_line" "OFF")
|
|
fi
|
|
done <<<"$containers"
|
|
msg_ok "Loaded ${#menu_items[@]} containers"
|
|
|
|
# Determine container selection based on var_container
|
|
if [[ -n "$var_container" ]]; then
|
|
case "$var_container" in
|
|
all)
|
|
# Select all containers with matching tags
|
|
CHOICE=""
|
|
for ((i = 0; i < ${#menu_items[@]}; i += 3)); do
|
|
CHOICE="$CHOICE ${menu_items[$i]}"
|
|
done
|
|
CHOICE=$(echo "$CHOICE" | xargs)
|
|
;;
|
|
all_running)
|
|
# Select only running containers with matching tags
|
|
CHOICE=""
|
|
for ((i = 0; i < ${#menu_items[@]}; i += 3)); do
|
|
cid="${menu_items[$i]}"
|
|
if pct status "$cid" 2>/dev/null | grep -q "running"; then
|
|
CHOICE="$CHOICE $cid"
|
|
fi
|
|
done
|
|
CHOICE=$(echo "$CHOICE" | xargs)
|
|
;;
|
|
all_stopped)
|
|
# Select only stopped containers with matching tags
|
|
CHOICE=""
|
|
for ((i = 0; i < ${#menu_items[@]}; i += 3)); do
|
|
cid="${menu_items[$i]}"
|
|
if pct status "$cid" 2>/dev/null | grep -q "stopped"; then
|
|
CHOICE="$CHOICE $cid"
|
|
fi
|
|
done
|
|
CHOICE=$(echo "$CHOICE" | xargs)
|
|
;;
|
|
*)
|
|
# Assume comma-separated list of container IDs
|
|
CHOICE=$(echo "$var_container" | tr ',' ' ')
|
|
;;
|
|
esac
|
|
|
|
if [[ -z "$CHOICE" ]]; then
|
|
msg_error "No containers matched the selection criteria: $var_container ${var_tags:-community-script|proxmox-helper-scripts}"
|
|
exit 234
|
|
fi
|
|
msg_ok "Selected containers: $CHOICE"
|
|
else
|
|
CHOICE=$(whiptail --title "LXC Container Update" \
|
|
--checklist "Select LXC containers to update:" 25 60 13 \
|
|
"${menu_items[@]}" 3>&2 2>&1 1>&3 | tr -d '"')
|
|
|
|
if [ -z "$CHOICE" ]; then
|
|
whiptail --title "LXC Container Update" \
|
|
--msgbox "No containers selected!" 10 60
|
|
exit 0
|
|
fi
|
|
fi
|
|
|
|
header_info
|
|
|
|
# Determine backup choice based on var_backup
|
|
if [[ -n "$var_backup" ]]; then
|
|
BACKUP_CHOICE="$var_backup"
|
|
else
|
|
BACKUP_CHOICE="no"
|
|
if (whiptail --backtitle "Proxmox VE Helper Scripts" --title "LXC Container Update" --yesno "Do you want to backup your containers before update?" 10 58); then
|
|
BACKUP_CHOICE="yes"
|
|
fi
|
|
fi
|
|
|
|
# Determine unattended update based on var_unattended
|
|
if [[ -n "$var_unattended" ]]; then
|
|
UNATTENDED_UPDATE="$var_unattended"
|
|
else
|
|
UNATTENDED_UPDATE="no"
|
|
if (whiptail --backtitle "Proxmox VE Helper Scripts" --title "LXC Container Update" --yesno "Run updates unattended?" 10 58); then
|
|
UNATTENDED_UPDATE="yes"
|
|
fi
|
|
fi
|
|
|
|
if [ "$BACKUP_CHOICE" == "yes" ]; then
|
|
get_backup_storages
|
|
|
|
if [ -z "$STORAGES" ]; then
|
|
msg_error "No storage with 'backup' support found!"
|
|
exit 119
|
|
fi
|
|
|
|
# Determine storage based on var_backup_storage
|
|
if [[ -n "$var_backup_storage" ]]; then
|
|
# Validate that the specified storage exists and supports backups
|
|
if echo "$STORAGES" | grep -qw "$var_backup_storage"; then
|
|
STORAGE_CHOICE="$var_backup_storage"
|
|
msg_ok "Using backup storage: $STORAGE_CHOICE"
|
|
else
|
|
msg_error "Specified backup storage '$var_backup_storage' not found or doesn't support backups!"
|
|
msg_info "Available storages: $(echo $STORAGES | tr '\n' ' ')"
|
|
exit 119
|
|
fi
|
|
else
|
|
MENU_ITEMS=()
|
|
for STORAGE in $STORAGES; do
|
|
MENU_ITEMS+=("$STORAGE" "")
|
|
done
|
|
|
|
STORAGE_CHOICE=$(whiptail --title "Select storage device" --menu "Select a storage device (Only storage devices with 'backup' support are listed):" 15 50 5 "${MENU_ITEMS[@]}" 3>&1 1>&2 2>&3)
|
|
|
|
if [ -z "$STORAGE_CHOICE" ]; then
|
|
msg_error "No storage selected!"
|
|
exit 0
|
|
fi
|
|
fi
|
|
fi
|
|
|
|
UPDATE_CMD="update;"
|
|
if [ "$UNATTENDED_UPDATE" == "yes" ]; then
|
|
UPDATE_CMD="export PHS_SILENT=1;update;"
|
|
fi
|
|
|
|
containers_needing_reboot=()
|
|
for container in $CHOICE; do
|
|
echo -e "${BL}[INFO]${CL} Updating container $container"
|
|
|
|
if [ "$BACKUP_CHOICE" == "yes" ]; then
|
|
backup_container $container
|
|
fi
|
|
|
|
os=$(pct config "$container" | awk '/^ostype/ {print $2}')
|
|
status=$(pct status $container)
|
|
template=$(pct config $container | grep -q "template:" && echo "true" || echo "false")
|
|
if [ "$template" == "false" ] && [ "$status" == "status: stopped" ]; then
|
|
echo -e "${BL}[Info]${GN} Starting${BL} $container ${CL} \n"
|
|
pct start $container
|
|
echo -e "${BL}[Info]${GN} Waiting For${BL} $container${CL}${GN} To Start ${CL} \n"
|
|
sleep 5
|
|
fi
|
|
|
|
#1) Detect service using the service name in the update command
|
|
detect_service $container
|
|
|
|
#1.1) If update script not detected, return
|
|
if [ -z "${service}" ]; then
|
|
echo -e "${YW}[WARN]${CL} Update script not found. Skipping to next container"
|
|
continue
|
|
else
|
|
echo -e "${BL}[INFO]${CL} Detected service: ${GN}${service}${CL}"
|
|
fi
|
|
|
|
#2) Extract service build/update resource requirements from config/installation file
|
|
script=$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/${service}.sh)
|
|
|
|
#2.1) Check if the script downloaded successfully
|
|
if [ $? -ne 0 ]; then
|
|
echo -e "${RD}[ERROR]${CL} Issue while downloading install script."
|
|
echo -e "${YW}[WARN]${CL} Unable to assess build resource requirements. Proceeding with current resources."
|
|
fi
|
|
|
|
config=$(pct config "$container")
|
|
build_cpu=$(echo "$script" | { grep -m 1 "var_cpu" || test $? = 1; } | sed 's|.*=||g' | sed 's|"||g' | sed 's|.*var_cpu:-||g' | sed 's|}||g')
|
|
build_ram=$(echo "$script" | { grep -m 1 "var_ram" || test $? = 1; } | sed 's|.*=||g' | sed 's|"||g' | sed 's|.*var_ram:-||g' | sed 's|}||g')
|
|
run_cpu=$(echo "$script" | { grep -m 1 "pct set \$CTID -cores" || test $? = 1; } | sed 's|.*cores ||g')
|
|
run_ram=$(echo "$script" | { grep -m 1 "pct set \$CTID -memory" || test $? = 1; } | sed 's|.*memory ||g')
|
|
current_cpu=$(echo "$config" | grep -m 1 "cores:" | sed 's|cores: ||g')
|
|
current_ram=$(echo "$config" | grep -m 1 "memory:" | sed 's|memory: ||g')
|
|
|
|
#Test if all values are valid (>0)
|
|
if [ -z "${run_cpu}" ] || [ "$run_cpu" -le 0 ]; then
|
|
#echo "No valid value found for run_cpu. Assuming same as current configuration."
|
|
run_cpu=$current_cpu
|
|
fi
|
|
|
|
if [ -z "${run_ram}" ] || [ "$run_ram" -le 0 ]; then
|
|
#echo "No valid value found for run_ram. Assuming same as current configuration."
|
|
run_ram=$current_ram
|
|
fi
|
|
|
|
if [ -z "${build_cpu}" ] || [ "$build_cpu" -le 0 ]; then
|
|
#echo "No valid value found for build_cpu. Assuming same as current configuration."
|
|
build_cpu=$current_cpu
|
|
fi
|
|
|
|
if [ -z "${build_ram}" ] || [ "$build_ram" -le 0 ]; then
|
|
#echo "No valid value found for build_ram. Assuming same as current configuration."
|
|
build_ram=$current_ram
|
|
fi
|
|
|
|
UPDATE_BUILD_RESOURCES=0
|
|
if [ "$build_cpu" -gt "$run_cpu" ] || [ "$build_ram" -gt "$run_ram" ]; then
|
|
UPDATE_BUILD_RESOURCES=1
|
|
fi
|
|
|
|
#3) if build resources are different than run resources, then:
|
|
if [ "$UPDATE_BUILD_RESOURCES" -eq "1" ]; then
|
|
pct set "$container" --cores "$build_cpu" --memory "$build_ram"
|
|
fi
|
|
|
|
#4) Update service, using the update command
|
|
case "$os" in
|
|
alpine) pct exec "$container" -- ash -c "$UPDATE_CMD" ;;
|
|
archlinux) pct exec "$container" -- bash -c "$UPDATE_CMD" ;;
|
|
fedora | rocky | centos | alma) pct exec "$container" -- bash -c "$UPDATE_CMD" ;;
|
|
ubuntu | debian | devuan) pct exec "$container" -- bash -c "$UPDATE_CMD" ;;
|
|
opensuse) pct exec "$container" -- bash -c "$UPDATE_CMD" ;;
|
|
esac
|
|
exit_code=$?
|
|
|
|
if [ "$template" == "false" ] && [ "$status" == "status: stopped" ]; then
|
|
echo -e "${BL}[Info]${GN} Shutting down${BL} $container ${CL} \n"
|
|
pct shutdown $container &
|
|
fi
|
|
|
|
#5) if build resources are different than run resources, then:
|
|
if [ "$UPDATE_BUILD_RESOURCES" -eq "1" ]; then
|
|
pct set "$container" --cores "$run_cpu" --memory "$run_ram"
|
|
fi
|
|
|
|
if pct exec "$container" -- [ -e "/var/run/reboot-required" ]; then
|
|
# Get the container's hostname and add it to the list
|
|
container_hostname=$(pct exec "$container" hostname)
|
|
containers_needing_reboot+=("$container ($container_hostname)")
|
|
fi
|
|
|
|
if [ $exit_code -eq 0 ]; then
|
|
msg_ok "Updated container $container"
|
|
elif [ $exit_code -eq 75 ]; then
|
|
echo -e "${YW}[WARN]${CL} Container $container skipped (requires interactive mode)"
|
|
elif [ "$BACKUP_CHOICE" == "yes" ]; then
|
|
msg_info "Restoring LXC from backup"
|
|
pct stop $container
|
|
LXC_STORAGE=$(pct config $container | awk -F '[:,]' '/rootfs/ {print $2}')
|
|
pct restore $container /var/lib/vz/dump/vzdump-lxc-${container}-*.tar.zst --storage $LXC_STORAGE --force >/dev/null 2>&1
|
|
pct start $container
|
|
restorestatus=$?
|
|
if [ $restorestatus -eq 0 ]; then
|
|
msg_ok "Restored LXC from backup"
|
|
else
|
|
msg_error "Restored LXC from backup failed"
|
|
exit 235
|
|
fi
|
|
else
|
|
msg_error "Update failed for container $container. Exiting"
|
|
exit "$exit_code"
|
|
fi
|
|
done
|
|
|
|
wait
|
|
header_info
|
|
echo -e "${GN}The process is complete, and the containers have been successfully updated.${CL}\n"
|
|
if [ "${#containers_needing_reboot[@]}" -gt 0 ]; then
|
|
echo -e "${RD}The following containers require a reboot:${CL}"
|
|
for container_name in "${containers_needing_reboot[@]}"; do
|
|
echo "$container_name"
|
|
done
|
|
|
|
# Determine reboot choice based on var_auto_reboot
|
|
REBOOT_CHOICE="no"
|
|
if [[ -n "$var_auto_reboot" ]]; then
|
|
REBOOT_CHOICE="$var_auto_reboot"
|
|
else
|
|
echo -ne "${INFO} Do you wish to reboot these containers? <yes/No> "
|
|
read -r prompt
|
|
if [[ ${prompt,,} =~ ^(yes)$ ]]; then
|
|
REBOOT_CHOICE="yes"
|
|
fi
|
|
fi
|
|
|
|
if [[ "$REBOOT_CHOICE" == "yes" ]]; then
|
|
echo -e "${CROSS}${HOLD} ${YWB}Rebooting containers.${CL}"
|
|
for container_name in "${containers_needing_reboot[@]}"; do
|
|
container=$(echo $container_name | cut -d " " -f 1)
|
|
pct reboot ${container}
|
|
done
|
|
fi
|
|
fi
|