mirror of
https://github.com/community-scripts/ProxmoxVE.git
synced 2026-02-19 11:35:55 +01:00
b439960222
* fix: send telemetry BEFORE log collection in signal handlers - Swap ensure_log_on_host/post_update_to_api order in on_interrupt, on_terminate, api_exit_script, and inline SIGHUP/SIGINT/SIGTERM traps - For signal exits (>128): send telemetry immediately, then best-effort log collection - Add 2>/dev/null || true to all I/O in signal handlers to prevent SIGPIPE - Fix on_exit: exit_code=0 now reports 'done' instead of 'failed 1' - Root cause: pct pull hangs on dying containers blocked telemetry updates, leaving 595+ records stuck in 'installing' daily * feat: add execution_id to all telemetry payloads - Generate EXECUTION_ID from RANDOM_UUID in variables() - Export EXECUTION_ID to container environment - Add execution_id field to all 8 API payloads in api.func - Add execution_id to post_progress_to_api in install.func and alpine-install.func - Fallback to RANDOM_UUID when EXECUTION_ID not set (backward compat) * fix: correct telemetry type values for PVE and addon scripts - PVE scripts (tools/pve/*): change type 'tool' -> 'pve' - Addon scripts (tools/addon/*): fix 4 scripts that wrongly used 'tool' -> 'addon' (netdata, add-tailscale-lxc, add-netbird-lxc, all-templates) - api.func: post_tool_to_api sends type='pve', default fallback 'pve' - Aligns with PocketBase categories: lxc, vm, pve, addon * fix: persist diagnostics opt-in inside containers for addon telemetry - install.func + alpine-install.func: create /usr/local/community-scripts/diagnostics inside the container when DIAGNOSTICS=yes (from build.func export) - Enables addon scripts running later inside containers to find the opt-in - Update init_tool_telemetry default type from 'tool' to 'pve' * refactor: clean up diagnostics/telemetry opt-in system - diagnostics_check(): deduplicate heredoc (was 2x 22 lines), improve whiptail text with clear what/what-not collected, add telemetry + privacy links - diagnostics_menu(): better UX with current status, clear enable/disable buttons, note about existing containers - variables(): change DIAGNOSTICS default from 'yes' to 'no' (safe: no telemetry before user consents via diagnostics_check) - install.func + alpine-install.func: persist BOTH yes AND no in container so opt-out is explicit (not just missing file = no) - Fix typo 'menue' -> 'menu' in config file comments * fix: no pre-selection in telemetry dialog, link to telemetry-service README - Add --defaultno so 'No, opt out' is focused by default (user must Tab to Yes) - Change privacy link from discussions/1836 to telemetry-service#privacy--compliance * fix: use radiolist for telemetry dialog (no pre-selection) - Replace --yesno with --radiolist: user must actively SPACE-select an option - Both options start as OFF (no pre-selection) - Cancel/Exit defaults to 'no' (opt-out) * simplify: inline telemetry dialog text like other whiptail dialogs * improve: telemetry dialog with more detail, link to PRIVACY.md - Add what we collect / don't collect sections back to dialog - Link to telemetry-service/docs/PRIVACY.md instead of README anchor - Update config file comment with same link
93 lines
3.3 KiB
Bash
93 lines
3.3 KiB
Bash
#!/usr/bin/env bash
|
|
|
|
# Copyright (c) 2021-2026 community-scripts ORG
|
|
# Author: jeroenzwart
|
|
# License: MIT
|
|
# https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
|
|
|
|
function header_info() {
|
|
clear
|
|
cat <<"EOF"
|
|
______ __ __ _ ________
|
|
/ ____/ _____ _______ __/ /____ / / | |/ / ____/
|
|
/ __/ | |/_/ _ \/ ___/ / / / __/ _ \ / / | / /
|
|
/ /____> </ __/ /__/ /_/ / /_/ __/ / /___/ / /___
|
|
/_____/_/|_|\___/\___/\__,_/\__/\___/ /_____/_/|_\____/
|
|
|
|
EOF
|
|
}
|
|
set -eEuo pipefail
|
|
BL=$(echo "\033[36m")
|
|
RD=$(echo "\033[01;31m")
|
|
CM='\xE2\x9C\x94\033'
|
|
GN=$(echo "\033[1;92m")
|
|
CL=$(echo "\033[m")
|
|
|
|
# Telemetry
|
|
source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/api.func) 2>/dev/null || true
|
|
declare -f init_tool_telemetry &>/dev/null && init_tool_telemetry "execute-lxcs" "pve"
|
|
|
|
header_info
|
|
echo "Loading..."
|
|
whiptail --backtitle "Proxmox VE Helper Scripts" --title "Proxmox VE LXC Execute" --yesno "This will execute a command inside selected LXC Containers. Proceed?" 10 58
|
|
NODE=$(hostname)
|
|
EXCLUDE_MENU=()
|
|
MSG_MAX_LENGTH=0
|
|
while read -r TAG ITEM; do
|
|
OFFSET=2
|
|
((${#ITEM} + OFFSET > MSG_MAX_LENGTH)) && MSG_MAX_LENGTH=${#ITEM}+OFFSET
|
|
EXCLUDE_MENU+=("$TAG" "$ITEM " "OFF")
|
|
done < <(pct list | awk 'NR>1')
|
|
excluded_containers=$(whiptail --backtitle "Proxmox VE Helper Scripts" --title "Containers on $NODE" --checklist "\nSelect containers to skip from executing:\n" \
|
|
16 $((MSG_MAX_LENGTH + 23)) 6 "${EXCLUDE_MENU[@]}" 3>&1 1>&2 2>&3 | tr -d '"')
|
|
|
|
if [ $? -ne 0 ]; then
|
|
exit
|
|
fi
|
|
|
|
read -r -p "Enter here command for inside the containers: " custom_command
|
|
|
|
header_info
|
|
echo "One moment please...\n"
|
|
|
|
function execute_in() {
|
|
container=$1
|
|
name=$(pct exec "$container" hostname)
|
|
echo -e "${BL}[Info]${GN} Execute inside${BL} ${name}${GN} with output: ${CL}"
|
|
if ! pct exec "$container" -- bash -c "command ${custom_command} >/dev/null 2>&1"; then
|
|
echo -e "${BL}[Info]${GN} Skipping ${name} ${RD}$container has no command: ${custom_command}"
|
|
else
|
|
pct exec "$container" -- bash -c "${custom_command}" | tee
|
|
fi
|
|
}
|
|
|
|
for container in $(pct list | awk '{if(NR>1) print $1}'); do
|
|
if [[ " ${excluded_containers[@]} " =~ " $container " ]]; then
|
|
echo -e "${BL}[Info]${GN} Skipping ${BL}$container${CL}"
|
|
else
|
|
os=$(pct config "$container" | awk '/^ostype/ {print $2}')
|
|
if [ "$os" != "debian" ] && [ "$os" != "ubuntu" ]; then
|
|
echo -e "${BL}[Info]${GN} Skipping ${name} ${RD}$container is not Debian or Ubuntu ${CL}"
|
|
continue
|
|
fi
|
|
|
|
status=$(pct status "$container")
|
|
template=$(pct config "$container" | grep -q "template:" && echo "true" || echo "false")
|
|
if [ "$template" == "false" ] && [ "$status" == "status: stopped" ]; then
|
|
echo -e "${BL}[Info]${GN} Starting${BL} $container ${CL}"
|
|
pct start "$container"
|
|
echo -e "${BL}[Info]${GN} Waiting For${BL} $container${CL}${GN} To Start ${CL}"
|
|
sleep 5
|
|
execute_in "$container"
|
|
echo -e "${BL}[Info]${GN} Shutting down${BL} $container ${CL}"
|
|
pct shutdown "$container" &
|
|
elif [ "$status" == "status: running" ]; then
|
|
execute_in "$container"
|
|
fi
|
|
fi
|
|
done
|
|
|
|
wait
|
|
|
|
echo -e "${GN} Finished, execute command inside selected containers. ${CL} \n"
|