style(tools): unify all function declarations to name() { style

Remove 'function' keyword from 30 declarations to match the project convention used in core.func, error_handler.func, and all other .func files (POSIX-compatible name() { syntax)
fix(tools): consolidate OS detection, add error hints, sort setup functions
2026-05-26 10:19:36 +02:00 · 2026-05-25 21:07:37 +02:00 · 2026-05-25 21:07:37 +02:00 · 2026-05-25 21:07:37 +02:00
11 changed files with 19 additions and 52 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -467,37 +467,6 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit

 </details>

-## 2026-05-26
-
-### 🚀 Updated Scripts
-
-  - #### 🐞 Bug Fixes
-
-    - profilarr: Fix ARCH assignment in profilarr.sh to support Profilarr build usage [@mpeleshenko](https://github.com/mpeleshenko) ([#14709](https://github.com/community-scripts/ProxmoxVE/pull/14709))
-    - Jackett: Remove quotes in Service File [@michelroegl-brunner](https://github.com/michelroegl-brunner) ([#14729](https://github.com/community-scripts/ProxmoxVE/pull/14729))
-    - Open-archiver: approve pnpm build scripts and run build:oss without subshell [@MickLesk](https://github.com/MickLesk) ([#14711](https://github.com/community-scripts/ProxmoxVE/pull/14711))
-    - Docuseal: read Ruby version from Gemfile, upgrade on update if needed [@MickLesk](https://github.com/MickLesk) ([#14715](https://github.com/community-scripts/ProxmoxVE/pull/14715))
-
-  - #### ✨ New Features
-
-    - Birdnet-GO: install libonnxruntime.so from release tarball [@MickLesk](https://github.com/MickLesk) ([#14716](https://github.com/community-scripts/ProxmoxVE/pull/14716))
-
-### 💾 Core
-
-  - #### ✨ New Features
-
-    - tools.func: better error diagnostics, consistent OS detection, setup function ordering [@MickLesk](https://github.com/MickLesk) ([#14692](https://github.com/community-scripts/ProxmoxVE/pull/14692))
-
-### 🧰 Tools
-
-  - #### 🐞 Bug Fixes
-
-    - IPTag-Tool: use qm set for VM tags to handle snapshot sections crrectly [@MickLesk](https://github.com/MickLesk) ([#14713](https://github.com/community-scripts/ProxmoxVE/pull/14713))
-
-  - #### ✨ New Features
-
-    - Netdata: extend PVE version support to 9.x [@MickLesk](https://github.com/MickLesk) ([#14714](https://github.com/community-scripts/ProxmoxVE/pull/14714))
-
 ## 2026-05-25

 ### 🚀 Updated Scripts
--- a/ct/birdnet-go.sh
+++ b/ct/birdnet-go.sh
@@ -43,7 +43,6 @@ function update_script() {
    cp /opt/birdnet/birdnet-go /usr/local/bin/birdnet-go
    chmod +x /usr/local/bin/birdnet-go
    cp -r /opt/birdnet/libtensorflowlite_c.so /usr/local/lib/ || true
-    cp -r /opt/birdnet/libonnxruntime.so /usr/local/lib/ || true
    ldconfig
    msg_ok "Deployed Binary"

--- a/ct/docuseal.sh
+++ b/ct/docuseal.sh
@@ -42,13 +42,6 @@ function update_script() {

    CLEAN_INSTALL=1 fetch_and_deploy_gh_release "docuseal" "docusealco/docuseal" "tarball"

-    local required_ruby current_ruby
-    required_ruby=$(grep -m1 '^ruby ' /opt/docuseal/Gemfile | grep -oP '[0-9]+\.[0-9]+\.[0-9]+')
-    current_ruby=$(PATH="/root/.rbenv/bin:/root/.rbenv/shims:${PATH}" rbenv global 2>/dev/null || true)
-    if [[ -n "$required_ruby" && "$required_ruby" != "$current_ruby" ]]; then
-      RUBY_VERSION="${required_ruby}" RUBY_INSTALL_RAILS="false" HOME=/root setup_ruby
-    fi
-
    msg_info "Restoring Data"
    mv /opt/docuseal.env.bak /opt/docuseal/.env
    [[ -d /opt/docuseal_data.bak ]] && mv /opt/docuseal_data.bak /opt/docuseal/data
--- a/ct/open-archiver.sh
+++ b/ct/open-archiver.sh
@@ -43,7 +43,6 @@ function update_script() {
    msg_info "Updating Open Archiver"
    cd /opt/openarchiver
    $STD pnpm install --shamefully-hoist --frozen-lockfile --prod=false
-    $STD pnpm approve-builds --yes
    $STD pnpm run build:oss
    $STD pnpm db:migrate
    msg_ok "Updated Open Archiver"
--- a/ct/profilarr.sh
+++ b/ct/profilarr.sh
@@ -37,9 +37,8 @@ function update_script() {
    exit
  fi

-  ARCH=$(uname -m)
-
  if check_for_gh_release "deno" "denoland/deno" "v2.7.5" "Deno is pinned to 2.7.5 because the known WouldBlock: Resource temporarily unavailable (os error 11) Issue"; then
+    ARCH=$(uname -m)
    fetch_and_deploy_gh_release "deno" "denoland/deno" "v2.7.5" "latest" "/usr/local/bin" "deno-${ARCH}-unknown-linux-gnu.zip"
  fi

--- a/install/birdnet-go-install.sh
+++ b/install/birdnet-go-install.sh
@@ -27,7 +27,6 @@ msg_info "Setting up BirdNET-Go"
 cp /opt/birdnet/birdnet-go /usr/local/bin/birdnet-go
 chmod +x /usr/local/bin/birdnet-go
 cp -r /opt/birdnet/libtensorflowlite_c.so /usr/local/lib/ || true
-cp -r /opt/birdnet/libonnxruntime.so /usr/local/lib/ || true
 ldconfig
 mkdir -p /opt/birdnet/data/clips
 msg_ok "Set up BirdNET-Go"
--- a/install/docuseal-install.sh
+++ b/install/docuseal-install.sh
@@ -31,6 +31,7 @@ $STD apt install -y \
 msg_ok "Installed Dependencies"

 NODE_VERSION="22" NODE_MODULE="yarn" setup_nodejs
+RUBY_VERSION="4.0.1" RUBY_INSTALL_RAILS="false" HOME=/root setup_ruby
 PG_VERSION="17" setup_postgresql
 PG_DB_NAME="docuseal" PG_DB_USER="docuseal" setup_postgresql_db

@@ -55,9 +56,6 @@ msg_ok "Downloaded Fonts and PDFium"

 fetch_and_deploy_gh_release "docuseal" "docusealco/docuseal" "tarball"

-RUBY_VERSION=$(grep -m1 '^ruby ' /opt/docuseal/Gemfile | grep -oP '[0-9]+\.[0-9]+\.[0-9]+')
-RUBY_VERSION="${RUBY_VERSION}" RUBY_INSTALL_RAILS="false" HOME=/root setup_ruby
-
 msg_info "Downloading Field Detection Model"
 mkdir -p /opt/docuseal/tmp
 curl -fsSL -o /opt/docuseal/tmp/model.onnx \
--- a/install/jackett-install.sh
+++ b/install/jackett-install.sh
@@ -29,7 +29,7 @@ Type=simple
 WorkingDirectory=/opt/Jackett
 ExecStart=/bin/sh /opt/Jackett/jackett_launcher.sh
 TimeoutStopSec=30
-EnvironmentFile=/opt/.env
+EnvironmentFile="/opt/.env"

 [Install]
 WantedBy=multi-user.target
--- a/install/open-archiver-install.sh
+++ b/install/open-archiver-install.sh
@@ -46,7 +46,6 @@ sed -i "s|^ENCRYPTION_KEY=.*|ENCRYPTION_KEY=$SECRET_KEY|g" /opt/openarchiver/.en
 sed -i "s|^TIKA_URL=.*|TIKA_URL=|g" /opt/openarchiver/.env
 sed -i "s|^ORIGIN=.*|ORIGIN=http://$LOCAL_IP:3000|g" /opt/openarchiver/.env
 $STD pnpm install --shamefully-hoist --frozen-lockfile --prod=false
-$STD pnpm approve-builds --yes
 $STD pnpm run build:oss
 $STD pnpm db:migrate
 msg_ok "Setup Open Archiver"
--- a/tools/addon/netdata.sh
+++ b/tools/addon/netdata.sh
@@ -47,7 +47,7 @@ function msg_ok() {
 function msg_error() { echo -e "${RD}✗ $1${CL}"; }

 # This function checks the version of Proxmox Virtual Environment (PVE) and exits if the version is not supported.
-# Supported: Proxmox VE 8.0.x – 8.9.x and 9.0–9.x
+# Supported: Proxmox VE 8.0.x – 8.9.x and 9.0–9.1.x
 pve_check() {
  local PVE_VER
  PVE_VER="$(pveversion | awk -F'/' '{print $2}' | awk -F'-' '{print $1}')"
@@ -63,14 +63,20 @@ pve_check() {
    return 0
  fi

-  # Check for Proxmox VE 9.x: allow 9.0–9.x
+  # Check for Proxmox VE 9.x: allow 9.0–9.1.x
  if [[ "$PVE_VER" =~ ^9\.([0-9]+) ]]; then
+    local MINOR="${BASH_REMATCH[1]}"
+    if ((MINOR < 0 || MINOR > 1)); then
+      msg_error "This version of Proxmox VE is not yet supported."
+      msg_error "Supported: Proxmox VE version 9.0–9.1.x"
+      exit 105
+    fi
    return 0
  fi

  # All other unsupported versions
  msg_error "This version of Proxmox VE is not supported."
-  msg_error "Supported versions: Proxmox VE 8.0 – 8.9 or 9.0–9.x"
+  msg_error "Supported versions: Proxmox VE 8.0 – 8.9 or 9.0–9.1.x"
  exit 105
 }

--- a/tools/pve/add-iptag.sh
+++ b/tools/pve/add-iptag.sh
@@ -811,7 +811,13 @@ update_tags() {
        if [[ "$type" == "lxc" ]]; then
            pct set "${vmid}" -tags "$(IFS=';'; echo "${next_tags[*]}")" &>/dev/null
        else
-            qm set "${vmid}" --tags "$(IFS=';'; echo "${next_tags[*]}")" &>/dev/null
+            local vm_config="/etc/pve/qemu-server/${vmid}.conf"
+            if [[ -f "$vm_config" ]]; then
+                sed -i '/^tags:/d' "$vm_config"
+                if [[ ${#next_tags[@]} -gt 0 ]]; then
+                    echo "tags: $(IFS=';'; echo "${next_tags[*]}")" >> "$vm_config"
+                fi
+            fi
        fi
    else
        # Tags unchanged