Refactor bootstrap error handling with helper

Extract repeated fatal-error logic into a `_bootstrap_die` helper across alpine-install.func, build.func, and install.func. The helper uses `msg_error` when available, falling back to stderr, then exits with code 115. Inline error blocks are replaced with cleaner one-liner `|| _bootstrap_die` calls.

CHANGELOG.md

@@ -508,6 +508,8 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit
 
 </details>
 
+## 2026-07-29
+
 ## 2026-07-28
 
 ### 🚀 Updated Scripts

ct/bichon.sh

@@ -34,27 +34,30 @@ function update_script() {
     CURRENT_VERSION=$(cat /root/.bichon)
   fi
 
-  if [[ $CURRENT_VERSION != 1.* && $CURRENT_VERSION != 2.* ]]; then
-    msg_error "Installed ${APP} version (${CURRENT_VERSION}) is too old for an automatic update to v2.x."
-    msg_error "Please create a new ${APP} container and migrate your data manually."
-    msg_error "Guide: https://github.com/rustmailer/bichon/wiki/Bichon-v2.x-Migration-Guide"
-    exit
-  fi
-
-  MIGRATE_V2=0
-  if [[ $CURRENT_VERSION == 1.* ]]; then
-    MIGRATE_V2=1
-    STORAGE_KB=$(du -sk /opt/bichon-data/bichon-storage 2>/dev/null | awk '{print $1}')
-    FREE_KB=$(df -Pk /opt/bichon-data | awk 'NR==2 {print $4}')
-    if [[ -n "$STORAGE_KB" && -n "$FREE_KB" && "$FREE_KB" -lt "$STORAGE_KB" ]]; then
-      echo -e "\n${RD}Warning: migration needs about $((STORAGE_KB / 1024))MB, only $((FREE_KB / 1024))MB free.${CL}"
-      echo -e "${RD}The new bichon-blob store is written alongside the existing fjall data.${CL}"
+  MIGRATE_V1=0
+  if [[ $CURRENT_VERSION == 0.* ]]; then
+    MIGRATE_V1=1
+    DISK_USAGE=$(df / | awk 'NR==2 {print $5}' | sed 's/%//')
+    if [ "$DISK_USAGE" -gt 50 ]; then
+      echo -e "\n${RD}Warning: Less than 50% free storage remaining on the root disk.${CL}"
+      echo -e "${RD}Bichon v1 data migration temporarily duplicates data and requires free space for it.${CL}"
       read -r -p "Are you sure you want to proceed with the update? (y/N): " proceed
       if [[ ! $proceed =~ ^[Yy]$ ]]; then
         msg_error "Update cancelled by user."
         exit
       fi
     fi
+
+    RAM_TOTAL=$(free -m | awk '/^Mem:/{print $2}')
+    if [ "$RAM_TOTAL" -lt 2000 ]; then
+      echo -e "\n${RD}Warning: LXC has less than 2GB of RAM allocated (${RAM_TOTAL}MB).${CL}"
+      echo -e "${RD}Bichon v1 data migration consumes significant memory and may crash if insufficient.${CL}"
+      read -r -p "Are you sure you want to proceed with the update? (y/N): " proceed_ram
+      if [[ ! $proceed_ram =~ ^[Yy]$ ]]; then
+        msg_error "Update cancelled by user."
+        exit
+      fi
+    fi
   fi
 
   if check_for_gh_release "bichon" "rustmailer/bichon"; then
@@ -64,44 +67,55 @@ function update_script() {
 
     create_backup /opt/bichon/bichon.env
 
+    if [ "$MIGRATE_V1" -eq 1 ] && [ "$CURRENT_VERSION" != "0.3.7" ]; then
+      msg_info "Updating to intermediate version v0.3.7"
+      CLEAN_INSTALL=1 fetch_and_deploy_gh_release "bichon" "rustmailer/bichon" "prebuild" "v0.3.7" "/opt/bichon" "bichon-*-$(arch_resolve "x86_64" "aarch64")-unknown-linux-gnu.tar.gz"
+      restore_backup
+      systemctl start bichon
+      sleep 30
+      systemctl stop bichon
+      msg_ok "Intermediate update completed"
+    fi
+
     CLEAN_INSTALL=1 fetch_and_deploy_gh_release "bichon" "rustmailer/bichon" "prebuild" "latest" "/opt/bichon" "bichon-*-$(arch_resolve "x86_64" "aarch64")-unknown-linux-gnu.tar.gz"
     restore_backup
 
-    if [ "$MIGRATE_V2" -eq 1 ]; then
-      msg_info "Migrating storage from fjall to bichon-blob (patience)"
+    if [ "$MIGRATE_V1" -eq 1 ]; then
+      msg_info "Running Bichon v1 Data Migration (patience)"
       $STD apt install -y expect
-      # Menu: 0 Reset Password, 1 Migrate v0.3.7, 2 Migrate v1.x, 3 Exit
       $STD expect <<'EOF'
 set timeout -1
 spawn /opt/bichon/bichon-admin
 expect "*Select an operation*"
-send "\033\[B\033\[B\r"
+send "\033\[B\r"
 expect "*--bichon-root-dir*"
 send "/opt/bichon-data\r"
+expect "*--bichon-index-dir*"
+send "\r"
 expect "*--bichon-data-dir*"
 send "\r"
-expect "*batch size*"
+expect "*Ready to migrate?*"
+send "y"
+expect "*Enter batch size*"
 send "1000\r"
 expect eof
 catch wait
 EOF
       $STD apt remove --purge expect -y
       $STD apt autoremove -y
+      msg_ok "Migration completed"
 
-      if [[ ! -d /opt/bichon-data/bichon-storage/blobs ]] ||
-        [[ "$(cat /opt/bichon-data/STORAGE_VERSION 2>/dev/null)" != "2" ]]; then
-        msg_error "Storage migration did not complete - service left stopped, legacy data untouched."
-        msg_error "Run /opt/bichon/bichon-admin manually and select 'Migrate v1.x Storage to v2.x'."
-        exit
-      fi
-      msg_ok "Migrated storage to bichon-blob"
+      msg_info "Cleaning up legacy Bichon v0.x storage files"
+      rm -rf /opt/bichon-data/envelope
+      rm -rf /opt/bichon-data/eml
+      rm -f /opt/bichon-data/mailbox.db
+      rm -f /opt/bichon-data/meta.db
+      msg_ok "Cleanup completed"
 
-      msg_info "Removing legacy fjall files"
-      rm -rf /opt/bichon-data/bichon-storage/keyspaces
-      rm -f /opt/bichon-data/bichon-storage/0.jnl
-      rm -f /opt/bichon-data/bichon-storage/lock
-      rm -f /opt/bichon-data/bichon-storage/version
-      msg_ok "Removed legacy fjall files"
+      msg_info "Updating Bichon service for v1"
+      sed -i 's|ExecStart=/opt/bichon/bichon|ExecStart=/opt/bichon/bichon-server|g; s|RestartSec=5|RestartSec=5\n\nLimitNOFILE=65536|g' /etc/systemd/system/bichon.service
+      systemctl daemon-reload
+      msg_ok "Service updated"
     fi
 
     msg_info "Starting service"

install/bichon-install.sh

@@ -60,7 +60,7 @@ LimitNOFILE=65536
 WantedBy=multi-user.target
 EOF
 systemctl enable -q --now bichon
-msg_ok "Created Service"
+msg_info "Created Service"
 
 motd_ssh
 customize

misc/alpine-install.func

@@ -10,8 +10,29 @@ fi
 # must write local failure artifacts instead of talking to the telemetry API
 # (the host is the single telemetry reporter).
 export TELEMETRY_CONTEXT="container"
-source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/core.func)
-source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/error_handler.func)
+# A freshly booted container may not have DNS up yet. `source <(curl ...)` hides
+# curl's exit code, so a failed download would silently source an empty stream.
+_bootstrap_die() {
+  if declare -f msg_error >/dev/null 2>&1; then
+    msg_error "$1"
+  else
+    echo "FATAL: $1" >&2
+  fi
+  exit 115
+}
+
+_bootstrap_source() {
+  local url="$1" probe="$2" content
+  content=$(curl -fsSL --connect-timeout 10 --retry 5 --retry-connrefused --retry-delay 2 "$url") ||
+    _bootstrap_die "Failed to download ${url##*/}"
+  source /dev/stdin <<<"$content"
+  declare -f "$probe" >/dev/null 2>&1 ||
+    _bootstrap_die "${url##*/} loaded but incomplete (missing ${probe})"
+}
+
+_FUNC_BASE="https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc"
+_bootstrap_source "$_FUNC_BASE/core.func" load_functions
+_bootstrap_source "$_FUNC_BASE/error_handler.func" catch_errors
 load_functions
 catch_errors
 

misc/build.func

@@ -88,19 +88,38 @@ variables() {
   fi
 }
 
-source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/api.func)
-
-if command -v curl >/dev/null 2>&1; then
-  source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/core.func)
-  source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/error_handler.func)
-  load_functions
-  catch_errors
-elif command -v wget >/dev/null 2>&1; then
-  source <(wget -qO- https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/core.func)
-  source <(wget -qO- https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/error_handler.func)
-  load_functions
-  catch_errors
+# `source <(curl ...)` hides the download exit code, so a failed fetch would
+# silently source an empty stream and leave the helpers undefined.
+_bootstrap_die() {
+  if declare -f msg_error >/dev/null 2>&1; then
+    msg_error "$1"
+  else
+    echo "FATAL: $1" >&2
   fi
+  exit 115
+}
+
+_bootstrap_source() {
+  local url="$1" probe="$2" content=""
+  if command -v curl >/dev/null 2>&1; then
+    content=$(curl -fsSL --connect-timeout 10 --retry 5 --retry-connrefused --retry-delay 2 "$url") || content=""
+  elif command -v wget >/dev/null 2>&1; then
+    content=$(wget -qO- --tries=5 --timeout=10 "$url") || content=""
+  else
+    _bootstrap_die "Neither curl nor wget available"
+  fi
+  [[ -n "$content" ]] || _bootstrap_die "Failed to download ${url##*/}"
+  source /dev/stdin <<<"$content"
+  declare -f "$probe" >/dev/null 2>&1 ||
+    _bootstrap_die "${url##*/} loaded but incomplete (missing ${probe})"
+}
+
+_FUNC_BASE="https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc"
+_bootstrap_source "$_FUNC_BASE/api.func" post_to_api
+_bootstrap_source "$_FUNC_BASE/core.func" load_functions
+_bootstrap_source "$_FUNC_BASE/error_handler.func" catch_errors
+load_functions
+catch_errors
 
 # ==============================================================================
 # SECTION 2: PRE-FLIGHT CHECKS & SYSTEM VALIDATION

misc/install.func

@@ -37,8 +37,29 @@ fi
 # (the host is the single telemetry reporter).
 export TELEMETRY_CONTEXT="container"
 
-source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/core.func)
-source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/error_handler.func)
+# A freshly booted container may not have DNS up yet. `source <(curl ...)` hides
+# curl's exit code, so a failed download would silently source an empty stream.
+_bootstrap_die() {
+  if declare -f msg_error >/dev/null 2>&1; then
+    msg_error "$1"
+  else
+    echo "FATAL: $1" >&2
+  fi
+  exit 115
+}
+
+_bootstrap_source() {
+  local url="$1" probe="$2" content
+  content=$(curl -fsSL --connect-timeout 10 --retry 5 --retry-connrefused --retry-delay 2 "$url") ||
+    _bootstrap_die "Failed to download ${url##*/}"
+  source /dev/stdin <<<"$content"
+  declare -f "$probe" >/dev/null 2>&1 ||
+    _bootstrap_die "${url##*/} loaded but incomplete (missing ${probe})"
+}
+
+_FUNC_BASE="https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc"
+_bootstrap_source "$_FUNC_BASE/core.func" load_functions
+_bootstrap_source "$_FUNC_BASE/error_handler.func" catch_errors
 load_functions
 catch_errors