Improve Zabbix agent service detection

Use systemctl cat to reliably detect zabbix-agent2 or zabbix-agent units, add fallback when no agent is present, and warn instead of failing. Guard stop/start calls so they only run when an agent service was found, and use [[ ]] for safer string comparisons. Adjust package upgrade logic to handle both agent2 and agent cases accordingly.

CHANGELOG.md

@@ -406,6 +406,12 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit
 
 ## 2026-02-16
 
+### 🚀 Updated Scripts
+
+  - #### 🐞 Bug Fixes
+
+    - jellyseerr/overseerr: Migrate update script to Seerr; prompt rerun [@MickLesk](https://github.com/MickLesk) ([#11965](https://github.com/community-scripts/ProxmoxVE/pull/11965))
+
 ## 2026-02-15
 
 ### 🆕 New Scripts

ct/jellyseerr.sh

@@ -45,16 +45,18 @@ function update_script() {
     fi
 
     msg_info "Switching update script to Seerr"
-    cat <<EOF >/usr/bin/update
+    cat <<'EOF' >/usr/bin/update
+#!/usr/bin/env bash
 bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/seerr.sh)"
 EOF
     chmod +x /usr/bin/update
-    msg_ok "Switched update script to Seerr. Running update..."
-    exec /usr/bin/update
+    msg_ok "Switched update script to Seerr"
+    msg_warn "Please type 'update' again to complete the migration"
+    exit
   fi
 
   msg_info "Updating Jellyseerr"
-  cd /opt/jellyseerr 
+  cd /opt/jellyseerr
   systemctl stop jellyseerr
   output=$(git pull --no-rebase)
   pnpm_desired=$(grep -Po '"pnpm":\s*"\K[^"]+' /opt/jellyseerr/package.json)
@@ -65,7 +67,7 @@ EOF
   fi
   rm -rf dist .next node_modules
   export CYPRESS_INSTALL_BINARY=0
-  cd /opt/jellyseerr 
+  cd /opt/jellyseerr
   $STD pnpm install --frozen-lockfile
   export NODE_OPTIONS="--max-old-space-size=3072"
   $STD pnpm build

ct/overseerr.sh

@@ -44,12 +44,14 @@ function update_script() {
     fi
 
     msg_info "Switching update script to Seerr"
-    cat <<EOF >/usr/bin/update
+    cat <<'EOF' >/usr/bin/update
+#!/usr/bin/env bash
 bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/seerr.sh)"
 EOF
     chmod +x /usr/bin/update
-    msg_ok "Switched update script to Seerr. Running update..."
-    exec /usr/bin/update
+    msg_ok "Switched update script to Seerr"
+    msg_warn "Please type 'update' again to complete the migration"
+    exit 0
   fi
 
   if check_for_gh_release "overseerr" "sct/overseerr"; then

ct/zabbix.sh

@@ -35,15 +35,18 @@ function update_script() {
     exit
   fi
 
-  if systemctl list-unit-files | grep -q zabbix-agent2.service; then
+  if systemctl cat zabbix-agent2.service &>/dev/null; then
     AGENT_SERVICE="zabbix-agent2"
-  else
+  elif systemctl cat zabbix-agent.service &>/dev/null; then
     AGENT_SERVICE="zabbix-agent"
+  else
+    AGENT_SERVICE=""
+    msg_warn "No Zabbix Agent service found, skipping agent actions"
   fi
 
   msg_info "Stopping Services"
   systemctl stop zabbix-server
-  systemctl stop "$AGENT_SERVICE"
+  [[ -n "$AGENT_SERVICE" ]] && systemctl stop "$AGENT_SERVICE"
   msg_ok "Stopped Services"
 
   read -rp "Choose Zabbix version [1] 7.0 LTS  [2] 7.4 (Latest Stable)  [3] Latest available (default: 2): " ZABBIX_CHOICE
@@ -83,13 +86,13 @@ function update_script() {
 
   $STD apt install --only-upgrade zabbix-server-pgsql zabbix-frontend-php php8.4-pgsql
 
-  if [ "$AGENT_SERVICE" = "zabbix-agent2" ]; then
+  if [[ "$AGENT_SERVICE" == "zabbix-agent2" ]]; then
     $STD apt install --only-upgrade zabbix-agent2 zabbix-agent2-plugin-postgresql
     if [ -f /etc/zabbix/zabbix_agent2.d/plugins.d/nvidia.conf ]; then
       sed -i 's|^Plugins.NVIDIA.System.Path=.*|# Plugins.NVIDIA.System.Path=/usr/libexec/zabbix/zabbix-agent2-plugin-nvidia-gpu|' \
         /etc/zabbix/zabbix_agent2.d/plugins.d/nvidia.conf
     fi
-  else
+  elif [[ "$AGENT_SERVICE" == "zabbix-agent" ]]; then
     $STD apt install --only-upgrade zabbix-agent
   fi
 
@@ -105,7 +108,7 @@ function update_script() {
 
   msg_info "Starting Services"
   systemctl start zabbix-server
-  systemctl start "$AGENT_SERVICE"
+  [[ -n "$AGENT_SERVICE" ]] && systemctl start "$AGENT_SERVICE"
   systemctl restart apache2
   msg_ok "Started Services"
   msg_ok "Updated successfully!"