fix(build): close upgrade helper function in create_lxc_container

CHANGELOG.md

@@ -488,24 +488,10 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit
 
 ## 2026-06-23
 
-### 🚀 Updated Scripts
-
-  - #### 🐞 Bug Fixes
-
-    - LibreNMS: run daily.sh as librenms user with git available [@MickLesk](https://github.com/MickLesk) ([#15314](https://github.com/community-scripts/ProxmoxVE/pull/15314))
-
-  - #### ✨ New Features
-
-    - termix - patch tmp nginx behaviour to match the install script [@xyzulu](https://github.com/xyzulu) ([#15283](https://github.com/community-scripts/ProxmoxVE/pull/15283))
-
 ### 💾 Core
 
   - Fix syntax error in build function [@l0caldadmin](https://github.com/l0caldadmin) ([#15337](https://github.com/community-scripts/ProxmoxVE/pull/15337))
 
-  - #### 🐞 Bug Fixes
-
-    - fix: close lxc build function [@ServerBP](https://github.com/ServerBP) ([#15343](https://github.com/community-scripts/ProxmoxVE/pull/15343))
-
 ### ❔ Uncategorized
 
   - fix(build.func): remove duplicate if statement causing syntax error on container creation [@Copilot](https://github.com/Copilot) ([#15338](https://github.com/community-scripts/ProxmoxVE/pull/15338))

ct/crafty-controller.sh

@@ -46,12 +46,6 @@ function update_script() {
 
     restore_backup
 
-    msg_info "Updating TemurinJDK"
-    setup_java
-    $STD apt install -y temurin-{8,11,17,21,25}-jre
-    $STD update-alternatives --set java /usr/lib/jvm/temurin-25-jre-$(arch_resolve)/bin/java
-    msg_ok "Updated TemurinJDK"
-
     msg_info "Updating Python dependencies"
     chown -R crafty:crafty /opt/crafty-controller
     cd /opt/crafty-controller/crafty/crafty-4

ct/librenms.sh

@@ -29,21 +29,10 @@ function update_script() {
     exit
   fi
   setup_mariadb
-  ensure_dependencies git
-  if [[ ! -d /opt/librenms/.git ]]; then
-    msg_info "Initializing LibreNMS git metadata"
-    LIBRENMS_VERSION=$(cat ~/.librenms 2>/dev/null)
-    cd /opt/librenms
-    git init -q
-    git remote add origin https://github.com/librenms/librenms.git
-    git fetch --depth 1 origin "refs/tags/v${LIBRENMS_VERSION}" 2>/dev/null ||
-      git fetch --depth 1 origin "refs/tags/${LIBRENMS_VERSION}" 2>/dev/null || true
-    git checkout -qf FETCH_HEAD 2>/dev/null || true
-    chown -R librenms:librenms .git
-    msg_ok "Initialized LibreNMS git metadata"
-  fi
   msg_info "Updating LibreNMS"
-  $STD su - librenms -s /bin/bash -c 'cd /opt/librenms && ./daily.sh'
+  su librenms
+  cd /opt/librenms
+  ./daily.sh
   msg_ok "Updated LibreNMS"
   exit
 }

ct/termix.sh

@@ -206,25 +206,9 @@ EOF
       sed -i 's|/app/html|/opt/termix/html|g' /etc/nginx/nginx.conf
       sed -i 's|/app/nginx|/opt/termix/nginx|g' /etc/nginx/nginx.conf
       sed -i 's|listen ${PORT};|listen 80;|g' /etc/nginx/nginx.conf
+
       rm -f /etc/systemd/system/nginx.service.d/pidfile.conf
       rm -f /etc/tmpfiles.d/nginx-termix.conf
-      
-      if [ ! -d /tmp/nginx ]; then
-        mkdir -p /tmp/nginx
-      fi
-
-      if [ ! -f /etc/tmpfiles.d/nginx-termix.conf ]; then
-        echo "d /tmp/nginx 0755 nobody nogroup -" >/etc/tmpfiles.d/nginx-termix.conf
-      fi
-
-      if [ ! -f /etc/systemd/system/nginx.service.d/pidfile.conf ]; then
-        mkdir -p /etc/systemd/system/nginx.service.d/
-        cat <<'EOF' >/etc/systemd/system/nginx.service.d/pidfile.conf
-[Service]
-PIDFile=/tmp/nginx/nginx.pid
-EOF
-      fi
-      
       systemctl daemon-reload
       nginx -t && systemctl restart nginx
       msg_ok "Updated Nginx Configuration"

install/librenms-install.sh

@@ -17,7 +17,6 @@ msg_info "Installing Dependencies"
 $STD apt install -y \
   acl \
   fping \
-  git \
   graphviz \
   imagemagick \
   mtr-tiny \
@@ -65,16 +64,6 @@ EOF
 chown -R librenms:librenms /opt/librenms
 chmod 771 /opt/librenms
 chmod -R ug=rwX /opt/librenms/bootstrap/cache /opt/librenms/storage /opt/librenms/logs /opt/librenms/rrd
-if [[ ! -d /opt/librenms/.git ]]; then
-  LIBRENMS_VERSION=$(cat ~/.librenms 2>/dev/null)
-  cd /opt/librenms
-  git init -q
-  git remote add origin https://github.com/librenms/librenms.git
-  git fetch --depth 1 origin "refs/tags/v${LIBRENMS_VERSION}" 2>/dev/null ||
-    git fetch --depth 1 origin "refs/tags/${LIBRENMS_VERSION}" 2>/dev/null || true
-  git checkout -qf FETCH_HEAD 2>/dev/null || true
-  chown -R librenms:librenms .git
-fi
 msg_ok "Configured LibreNMS"
 
 msg_info "Configure MariaDB"