fix: unify RELEASE variable for check_for_gh_release and fetch_and_deploy_gh_release

- Simplify pinned version check: query exact tag directly instead of candidate loop
- Use same RELEASE variable in both check and deploy calls
- immich: use RELEASE='v2.5.6' consistently (remove RELEASE_TAG indirection)
- nocodb/patchmon/plant-it: extract shared RELEASE variable for both functions

CHANGELOG.md

@@ -429,16 +429,10 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit
 
   - #### 🐞 Bug Fixes
 
-    - Wishlist: use --frozen-lockfile for pnpm install [@MickLesk](https://github.com/MickLesk) ([#12892](https://github.com/community-scripts/ProxmoxVE/pull/12892))
     - SparkyFitness: use --legacy-peer-deps for npm install [@MickLesk](https://github.com/MickLesk) ([#12888](https://github.com/community-scripts/ProxmoxVE/pull/12888))
+    - Wishlist: use --frozen-lockfile for pnpm install [@MickLesk](https://github.com/MickLesk) ([#12892](https://github.com/community-scripts/ProxmoxVE/pull/12892))
     - Frigate: add fallback for OpenVino labelmap file [@MickLesk](https://github.com/MickLesk) ([#12889](https://github.com/community-scripts/ProxmoxVE/pull/12889))
 
-  - #### 🔧 Refactor
-
-    - Refactor: ITSM-NG [@MickLesk](https://github.com/MickLesk) ([#12918](https://github.com/community-scripts/ProxmoxVE/pull/12918))
-    - core: unify RELEASE variable for check_for_gh_release and fetch_and_deploy [@MickLesk](https://github.com/MickLesk) ([#12917](https://github.com/community-scripts/ProxmoxVE/pull/12917))
-    - Standardize NSAPP names across VM scripts [@MickLesk](https://github.com/MickLesk) ([#12924](https://github.com/community-scripts/ProxmoxVE/pull/12924))
-
 ### 💾 Core
 
   - #### ✨ New Features

ct/itsm-ng.sh

@@ -30,14 +30,9 @@ function update_script() {
   fi
   setup_mariadb
 
-  msg_info "Updating ITSM-NG"
+  msg_info "Updating LXC"
   $STD apt update
   $STD apt -y upgrade
-  chown -R www-data:www-data /var/lib/itsm-ng
-  mkdir -p /usr/share/itsm-ng/css/palettes
-  chown -R www-data:www-data /usr/share/itsm-ng/css
-  chown -R www-data:www-data /usr/share/itsm-ng/css_compiled
-  chown www-data:www-data /etc/itsm-ng/config_db.php
   msg_ok "Updated successfully!"
   exit
 }

ct/sparkyfitness.sh

@@ -62,27 +62,6 @@ function update_script() {
     cp -a /opt/sparkyfitness/SparkyFitnessFrontend/dist/. /var/www/sparkyfitness/
     msg_ok "Updated Sparky Fitness Frontend"
 
-    msg_info "Refreshing SparkyFitness Service"
-    cat <<EOF >/etc/systemd/system/sparkyfitness-server.service
-  [Unit]
-  Description=SparkyFitness Backend Service
-  After=network.target postgresql.service
-  Requires=postgresql.service
-
-  [Service]
-  Type=simple
-  WorkingDirectory=/opt/sparkyfitness/SparkyFitnessServer
-  EnvironmentFile=/etc/sparkyfitness/.env
-  ExecStart=/opt/sparkyfitness/SparkyFitnessServer/node_modules/.bin/tsx SparkyFitnessServer.js
-  Restart=always
-  RestartSec=5
-
-  [Install]
-  WantedBy=multi-user.target
-EOF
-    systemctl daemon-reload
-    msg_ok "Refreshed SparkyFitness Service"
-
     msg_info "Restoring data"
     cp -r /opt/sparkyfitness_backup/. /opt/sparkyfitness/SparkyFitnessServer/
     rm -rf /opt/sparkyfitness_backup

install/go2rtc-install.sh

@@ -14,10 +14,6 @@ network_check
 update_os
 setup_hwaccel
 
-msg_info "Installing Dependencies"
-$STD apt install -y ffmpeg
-msg_ok "Installed Dependencies"
-
 USE_ORIGINAL_FILENAME="true" fetch_and_deploy_gh_release "go2rtc" "AlexxIT/go2rtc" "singlefile" "latest" "/opt/go2rtc" "go2rtc_linux_amd64"
 
 msg_info "Creating Service"

install/itsm-ng-install.sh

@@ -14,32 +14,40 @@ network_check
 update_os
 
 setup_mariadb
-msg_info "Loading timezone data"
-mariadb-tzinfo-to-sql /usr/share/zoneinfo | mariadb mysql
-msg_ok "Loaded timezone data"
-MARIADB_DB_NAME="itsmng_db" MARIADB_DB_USER="itsmng" MARIADB_DB_EXTRA_GRANTS="GRANT SELECT ON \`mysql\`.\`time_zone_name\`" setup_mariadb_db
 
-msg_info "Installing ITSM-NG"
+msg_info "Setting up database"
+DB_NAME=itsmng_db
+DB_USER=itsmng
+DB_PASS=$(openssl rand -base64 18 | tr -dc 'a-zA-Z0-9' | head -c13)
+mariadb-tzinfo-to-sql /usr/share/zoneinfo | mariadb mysql
+mariadb -u root -e "CREATE DATABASE $DB_NAME;"
+mariadb -u root -e "CREATE USER '$DB_USER'@'localhost' IDENTIFIED BY '$DB_PASS';"
+mariadb -u root -e "GRANT ALL PRIVILEGES ON $DB_NAME.* TO '$DB_USER'@'localhost';"
+mariadb -u root -e "GRANT SELECT ON \`mysql\`.\`time_zone_name\` TO '$DB_USER'@'localhost'; FLUSH PRIVILEGES;"
+{
+  echo "ITSM-NG Database Credentials"
+  echo "Database: $DB_NAME"
+  echo "Username: $DB_USER"
+  echo "Password: $DB_PASS"
+} >>~/itsmng_db.creds
+msg_ok "Set up database"
+
+msg_info "Setup ITSM-NG Repository"
 setup_deb822_repo \
   "itsm-ng" \
   "http://deb.itsm-ng.org/pubkey.gpg" \
   "http://deb.itsm-ng.org/$(get_os_info id)/" \
   "$(get_os_info codename)"
+msg_ok "Setup ITSM-NG Repository"
+
+msg_info "Installing ITSM-NG"
 $STD apt install -y itsm-ng
 cd /usr/share/itsm-ng
-$STD php bin/console db:install --db-name="$MARIADB_DB_NAME" --db-user="$MARIADB_DB_USER" --db-password="$MARIADB_DB_PASS" --no-interaction
+$STD php bin/console db:install --db-name=$DB_NAME --db-user=$DB_USER --db-password=$DB_PASS --no-interaction
 $STD a2dissite 000-default.conf
-echo "* * * * * www-data php /usr/share/itsm-ng/front/cron.php" | crontab -
+echo "* * * * * php /usr/share/itsm-ng/front/cron.php" | crontab -
 msg_ok "Installed ITSM-NG"
 
-msg_info "Setting permissions"
-chown -R www-data:www-data /var/lib/itsm-ng
-mkdir -p /usr/share/itsm-ng/css/palettes
-chown -R www-data:www-data /usr/share/itsm-ng/css
-chown -R www-data:www-data /usr/share/itsm-ng/css_compiled
-chown www-data:www-data /etc/itsm-ng/config_db.php
-msg_ok "Set permissions"
-
 msg_info "Configuring PHP"
 PHP_VERSION=$(ls /etc/php/ | grep -E '^[0-9]+\.[0-9]+$' | head -n 1)
 PHP_INI="/etc/php/$PHP_VERSION/apache2/php.ini"

install/sparkyfitness-install.sh

@@ -69,7 +69,7 @@ Requires=postgresql.service
 Type=simple
 WorkingDirectory=/opt/sparkyfitness/SparkyFitnessServer
 EnvironmentFile=/etc/sparkyfitness/.env
-ExecStart=/opt/sparkyfitness/SparkyFitnessServer/node_modules/.bin/tsx SparkyFitnessServer.js
+ExecStart=/usr/bin/node SparkyFitnessServer.js
 Restart=always
 RestartSec=5
 

vm/archlinux-vm.sh

@@ -22,7 +22,7 @@ echo -e "\n Loading..."
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
-NSAPP="archlinux-vm"
+NSAPP="arch-linux-vm"
 var_os="arch-linux"
 var_version="n.d."
 

vm/debian-13-vm.sh

@@ -22,7 +22,7 @@ echo -e "\n Loading..."
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
-NSAPP="debian-13-vm"
+NSAPP="debian13vm"
 var_os="debian"
 var_version="13"
 

vm/debian-vm.sh

@@ -22,7 +22,7 @@ echo -e "\n Loading..."
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
-NSAPP="debian-vm"
+NSAPP="debian12vm"
 var_os="debian"
 var_version="12"
 

vm/haos-vm.sh

@@ -23,7 +23,7 @@ GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 VERSIONS=(stable beta dev)
 METHOD=""
-NSAPP="haos-vm"
+NSAPP="homeassistant-os"
 var_os="homeassistant"
 DISK_SIZE="32G"
 

vm/mikrotik-routeros.sh

@@ -23,7 +23,7 @@ echo -e "Loading..."
 GEN_MAC=$(echo '00 60 2f'$(od -An -N3 -t xC /dev/urandom) | sed -e 's/ /:/g' | tr '[:lower:]' '[:upper:]')
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
-NSAPP="mikrotik-routeros"
+NSAPP="mikrotik-router-os"
 var_os="mikrotik"
 var_version=" "
 DISK_SIZE="1G"

vm/nextcloud-vm.sh

@@ -22,7 +22,7 @@ echo -e "\n Loading..."
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
-NSAPP="nextcloud-vm"
+NSAPP="turnkey-nextcloud"
 var_os="turnkey-nextcloud"
 var_version="n.d."
 

vm/owncloud-vm.sh

@@ -22,7 +22,7 @@ echo -e "\n Loading..."
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
-NSAPP="owncloud-vm"
+NSAPP="turnkey-owncloud-vm"
 var_os="owncloud"
 var_version="18.0"
 APP="TurnKey ownCloud VM"

vm/truenas-vm.sh

@@ -23,7 +23,6 @@ echo -e "\n Loading..."
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
-NSAPP="truenas-vm"
 
 YW=$(echo "\033[33m")
 BL=$(echo "\033[36m")

vm/ubuntu2204-vm.sh

@@ -22,7 +22,7 @@ echo -e "\n Loading..."
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
-NSAPP="ubuntu2204-vm"
+NSAPP="ubuntu-2204-vm"
 var_os="ubuntu"
 var_version="2204"
 

vm/ubuntu2404-vm.sh

@@ -23,7 +23,7 @@ echo -e "\n Loading..."
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
-NSAPP="ubuntu2404-vm"
+NSAPP="ubuntu-2404-vm"
 var_os="ubuntu"
 var_version="2404"
 

vm/ubuntu2504-vm.sh

@@ -22,7 +22,7 @@ echo -e "\n Loading..."
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
-NSAPP="ubuntu2504-vm"
+NSAPP="ubuntu-2504-vm"
 var_os="ubuntu"
 var_version="2504"