Standardize NSAPP names across VM scripts

Normalize the NSAPP variable values in multiple vm/*.sh scripts for consistent naming (archlinux-vm, debian-13-vm, debian-vm, haos-vm, mikrotik-routeros, nextcloud-vm, owncloud-vm, ubuntu2204-vm, ubuntu2404-vm, ubuntu2504-vm) and add the missing NSAPP entry for truenas-vm. These changes are purely renames to standardize identifiers used by tooling or downstream logic and do not alter other behavior.

CHANGELOG.md

@@ -429,16 +429,10 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit
 
   - #### 🐞 Bug Fixes
 
-    - Wishlist: use --frozen-lockfile for pnpm install [@MickLesk](https://github.com/MickLesk) ([#12892](https://github.com/community-scripts/ProxmoxVE/pull/12892))
     - SparkyFitness: use --legacy-peer-deps for npm install [@MickLesk](https://github.com/MickLesk) ([#12888](https://github.com/community-scripts/ProxmoxVE/pull/12888))
+    - Wishlist: use --frozen-lockfile for pnpm install [@MickLesk](https://github.com/MickLesk) ([#12892](https://github.com/community-scripts/ProxmoxVE/pull/12892))
     - Frigate: add fallback for OpenVino labelmap file [@MickLesk](https://github.com/MickLesk) ([#12889](https://github.com/community-scripts/ProxmoxVE/pull/12889))
 
-  - #### 🔧 Refactor
-
-    - Refactor: ITSM-NG [@MickLesk](https://github.com/MickLesk) ([#12918](https://github.com/community-scripts/ProxmoxVE/pull/12918))
-    - core: unify RELEASE variable for check_for_gh_release and fetch_and_deploy [@MickLesk](https://github.com/MickLesk) ([#12917](https://github.com/community-scripts/ProxmoxVE/pull/12917))
-    - Standardize NSAPP names across VM scripts [@MickLesk](https://github.com/MickLesk) ([#12924](https://github.com/community-scripts/ProxmoxVE/pull/12924))
-
 ### 💾 Core
 
   - #### ✨ New Features

ct/immich.sh

@@ -109,7 +109,7 @@ EOF
     msg_ok "Image-processing libraries up to date"
   fi
 
-  RELEASE="v2.5.6"
+  RELEASE="2.5.6"
   if check_for_gh_release "Immich" "immich-app/immich" "${RELEASE}"; then
     if [[ $(cat ~/.immich) > "2.5.1" ]]; then
       msg_info "Enabling Maintenance Mode"
@@ -165,7 +165,7 @@ EOF
     )
 
     setup_uv
-    CLEAN_INSTALL=1 fetch_and_deploy_gh_release "Immich" "immich-app/immich" "tarball" "${RELEASE}" "$SRC_DIR"
+    CLEAN_INSTALL=1 fetch_and_deploy_gh_release "Immich" "immich-app/immich" "tarball" "v${RELEASE}" "$SRC_DIR"
     PNPM_VERSION="$(jq -r '.packageManager | split("@")[1]' ${SRC_DIR}/package.json)"
     NODE_VERSION="24" NODE_MODULE="pnpm@${PNPM_VERSION}" setup_nodejs
 

ct/itsm-ng.sh

@@ -30,14 +30,9 @@ function update_script() {
   fi
   setup_mariadb
 
-  msg_info "Updating ITSM-NG"
+  msg_info "Updating LXC"
   $STD apt update
   $STD apt -y upgrade
-  chown -R www-data:www-data /var/lib/itsm-ng
-  mkdir -p /usr/share/itsm-ng/css/palettes
-  chown -R www-data:www-data /usr/share/itsm-ng/css
-  chown -R www-data:www-data /usr/share/itsm-ng/css_compiled
-  chown www-data:www-data /etc/itsm-ng/config_db.php
   msg_ok "Updated successfully!"
   exit
 }

ct/nocodb.sh

@@ -23,17 +23,16 @@ function update_script() {
   header_info
   check_container_storage
   check_container_resources
-  RELEASE="0.301.1"
   if [[ ! -f /etc/systemd/system/nocodb.service ]]; then
     msg_error "No ${APP} Installation Found!"
     exit
   fi
-  if check_for_gh_release "nocodb" "nocodb/nocodb" "${RELEASE}"; then
+  if check_for_gh_release "nocodb" "nocodb/nocodb" "0.301.1"; then
     msg_info "Stopping Service"
     systemctl stop nocodb
     msg_ok "Stopped Service"
 
-    fetch_and_deploy_gh_release "nocodb" "nocodb/nocodb" "singlefile" "${RELEASE}" "/opt/nocodb/" "Noco-linux-x64"
+    fetch_and_deploy_gh_release "nocodb" "nocodb/nocodb" "singlefile" "0.301.1" "/opt/nocodb/" "Noco-linux-x64"
 
     msg_info "Starting Service"
     systemctl start nocodb

ct/patchmon.sh

@@ -36,9 +36,8 @@ function update_script() {
     read -r
   fi
 
-  RELEASE="v1.4.2"
   NODE_VERSION="24" setup_nodejs
-  if check_for_gh_release "PatchMon" "PatchMon/PatchMon" "${RELEASE}"; then
+  if check_for_gh_release "PatchMon" "PatchMon/PatchMon" "1.4.2"; then
     msg_info "Stopping Service"
     systemctl stop patchmon-server
     msg_ok "Stopped Service"
@@ -48,7 +47,7 @@ function update_script() {
     cp /opt/patchmon/frontend/.env /opt/frontend.env
     msg_ok "Backup Created"
 
-    CLEAN_INSTALL=1 fetch_and_deploy_gh_release "PatchMon" "PatchMon/PatchMon" "tarball" "${RELEASE}" "/opt/patchmon"
+    CLEAN_INSTALL=1 fetch_and_deploy_gh_release "PatchMon" "PatchMon/PatchMon" "tarball" "v1.4.2" "/opt/patchmon"
 
     msg_info "Updating PatchMon"
     VERSION=$(get_latest_github_release "PatchMon/PatchMon")

ct/plant-it.sh

@@ -23,19 +23,18 @@ function update_script() {
   header_info
   check_container_storage
   check_container_resources
-  RELEASE="0.10.0"
   if [[ ! -d /opt/plant-it ]]; then
     msg_error "No ${APP} Installation Found!"
     exit
   fi
   setup_mariadb
-  if check_for_gh_release "plant-it" "MDeLuise/plant-it" "${RELEASE}"; then
+  if check_for_gh_release "plant-it" "MDeLuise/plant-it"; then
     msg_info "Stopping Service"
     systemctl stop plant-it
     msg_info "Stopped Service"
 
-    USE_ORIGINAL_FILENAME="true" fetch_and_deploy_gh_release "plant-it" "MDeLuise/plant-it" "singlefile" "${RELEASE}" "/opt/plant-it/backend" "server.jar"
-    fetch_and_deploy_gh_release "plant-it-front" "MDeLuise/plant-it" "prebuild" "${RELEASE}" "/opt/plant-it/frontend" "client.tar.gz"
+    USE_ORIGINAL_FILENAME="true" fetch_and_deploy_gh_release "plant-it" "MDeLuise/plant-it" "singlefile" "0.10.0" "/opt/plant-it/backend" "server.jar"
+    fetch_and_deploy_gh_release "plant-it-front" "MDeLuise/plant-it" "prebuild" "0.10.0" "/opt/plant-it/frontend" "client.tar.gz"
     msg_warn "Application is updated to latest Web version (v0.10.0). There will be no more updates available."
     msg_warn "Please read: https://github.com/MDeLuise/plant-it/releases/tag/1.0.0"
 

ct/sparkyfitness.sh

@@ -62,27 +62,6 @@ function update_script() {
     cp -a /opt/sparkyfitness/SparkyFitnessFrontend/dist/. /var/www/sparkyfitness/
     msg_ok "Updated Sparky Fitness Frontend"
 
-    msg_info "Refreshing SparkyFitness Service"
-    cat <<EOF >/etc/systemd/system/sparkyfitness-server.service
-  [Unit]
-  Description=SparkyFitness Backend Service
-  After=network.target postgresql.service
-  Requires=postgresql.service
-
-  [Service]
-  Type=simple
-  WorkingDirectory=/opt/sparkyfitness/SparkyFitnessServer
-  EnvironmentFile=/etc/sparkyfitness/.env
-  ExecStart=/opt/sparkyfitness/SparkyFitnessServer/node_modules/.bin/tsx SparkyFitnessServer.js
-  Restart=always
-  RestartSec=5
-
-  [Install]
-  WantedBy=multi-user.target
-EOF
-    systemctl daemon-reload
-    msg_ok "Refreshed SparkyFitness Service"
-
     msg_info "Restoring data"
     cp -r /opt/sparkyfitness_backup/. /opt/sparkyfitness/SparkyFitnessServer/
     rm -rf /opt/sparkyfitness_backup

install/go2rtc-install.sh

@@ -14,10 +14,6 @@ network_check
 update_os
 setup_hwaccel
 
-msg_info "Installing Dependencies"
-$STD apt install -y ffmpeg
-msg_ok "Installed Dependencies"
-
 USE_ORIGINAL_FILENAME="true" fetch_and_deploy_gh_release "go2rtc" "AlexxIT/go2rtc" "singlefile" "latest" "/opt/go2rtc" "go2rtc_linux_amd64"
 
 msg_info "Creating Service"

install/itsm-ng-install.sh

@@ -14,32 +14,40 @@ network_check
 update_os
 
 setup_mariadb
-msg_info "Loading timezone data"
-mariadb-tzinfo-to-sql /usr/share/zoneinfo | mariadb mysql
-msg_ok "Loaded timezone data"
-MARIADB_DB_NAME="itsmng_db" MARIADB_DB_USER="itsmng" MARIADB_DB_EXTRA_GRANTS="GRANT SELECT ON \`mysql\`.\`time_zone_name\`" setup_mariadb_db
 
-msg_info "Installing ITSM-NG"
+msg_info "Setting up database"
+DB_NAME=itsmng_db
+DB_USER=itsmng
+DB_PASS=$(openssl rand -base64 18 | tr -dc 'a-zA-Z0-9' | head -c13)
+mariadb-tzinfo-to-sql /usr/share/zoneinfo | mariadb mysql
+mariadb -u root -e "CREATE DATABASE $DB_NAME;"
+mariadb -u root -e "CREATE USER '$DB_USER'@'localhost' IDENTIFIED BY '$DB_PASS';"
+mariadb -u root -e "GRANT ALL PRIVILEGES ON $DB_NAME.* TO '$DB_USER'@'localhost';"
+mariadb -u root -e "GRANT SELECT ON \`mysql\`.\`time_zone_name\` TO '$DB_USER'@'localhost'; FLUSH PRIVILEGES;"
+{
+  echo "ITSM-NG Database Credentials"
+  echo "Database: $DB_NAME"
+  echo "Username: $DB_USER"
+  echo "Password: $DB_PASS"
+} >>~/itsmng_db.creds
+msg_ok "Set up database"
+
+msg_info "Setup ITSM-NG Repository"
 setup_deb822_repo \
   "itsm-ng" \
   "http://deb.itsm-ng.org/pubkey.gpg" \
   "http://deb.itsm-ng.org/$(get_os_info id)/" \
   "$(get_os_info codename)"
+msg_ok "Setup ITSM-NG Repository"
+
+msg_info "Installing ITSM-NG"
 $STD apt install -y itsm-ng
 cd /usr/share/itsm-ng
-$STD php bin/console db:install --db-name="$MARIADB_DB_NAME" --db-user="$MARIADB_DB_USER" --db-password="$MARIADB_DB_PASS" --no-interaction
+$STD php bin/console db:install --db-name=$DB_NAME --db-user=$DB_USER --db-password=$DB_PASS --no-interaction
 $STD a2dissite 000-default.conf
-echo "* * * * * www-data php /usr/share/itsm-ng/front/cron.php" | crontab -
+echo "* * * * * php /usr/share/itsm-ng/front/cron.php" | crontab -
 msg_ok "Installed ITSM-NG"
 
-msg_info "Setting permissions"
-chown -R www-data:www-data /var/lib/itsm-ng
-mkdir -p /usr/share/itsm-ng/css/palettes
-chown -R www-data:www-data /usr/share/itsm-ng/css
-chown -R www-data:www-data /usr/share/itsm-ng/css_compiled
-chown www-data:www-data /etc/itsm-ng/config_db.php
-msg_ok "Set permissions"
-
 msg_info "Configuring PHP"
 PHP_VERSION=$(ls /etc/php/ | grep -E '^[0-9]+\.[0-9]+$' | head -n 1)
 PHP_INI="/etc/php/$PHP_VERSION/apache2/php.ini"

install/sparkyfitness-install.sh

@@ -69,7 +69,7 @@ Requires=postgresql.service
 Type=simple
 WorkingDirectory=/opt/sparkyfitness/SparkyFitnessServer
 EnvironmentFile=/etc/sparkyfitness/.env
-ExecStart=/opt/sparkyfitness/SparkyFitnessServer/node_modules/.bin/tsx SparkyFitnessServer.js
+ExecStart=/usr/bin/node SparkyFitnessServer.js
 Restart=always
 RestartSec=5
 

misc/tools.func

@@ -2223,35 +2223,6 @@ check_for_gh_release() {
   # Try /latest endpoint for non-pinned versions (most efficient)
   local releases_json="" http_code=""
 
-  # For pinned versions, query the specific release tag directly
-  if [[ -n "$pinned_version_in" ]]; then
-    http_code=$(curl -sSL --max-time 20 -w "%{http_code}" -o /tmp/gh_check.json \
-      -H 'Accept: application/vnd.github+json' \
-      -H 'X-GitHub-Api-Version: 2022-11-28' \
-      "${header_args[@]}" \
-      "https://api.github.com/repos/${source}/releases/tags/${pinned_version_in}" 2>/dev/null) || true
-
-    if [[ "$http_code" == "200" ]] && [[ -s /tmp/gh_check.json ]]; then
-      releases_json="[$(</tmp/gh_check.json)]"
-    elif [[ "$http_code" == "401" ]]; then
-      msg_error "GitHub API authentication failed (HTTP 401)."
-      if [[ -n "${GITHUB_TOKEN:-}" ]]; then
-        msg_error "Your GITHUB_TOKEN appears to be invalid or expired."
-      else
-        msg_error "The repository may require authentication. Try: export GITHUB_TOKEN=\"ghp_your_token\""
-      fi
-      rm -f /tmp/gh_check.json
-      return 1
-    elif [[ "$http_code" == "403" ]]; then
-      msg_error "GitHub API rate limit exceeded (HTTP 403)."
-      msg_error "To increase the limit, export a GitHub token before running the script:"
-      msg_error "  export GITHUB_TOKEN=\"ghp_your_token_here\""
-      rm -f /tmp/gh_check.json
-      return 1
-    fi
-    rm -f /tmp/gh_check.json
-  fi
-
   if [[ -z "$pinned_version_in" ]]; then
     http_code=$(curl -sSL --max-time 20 -w "%{http_code}" -o /tmp/gh_check.json \
       -H 'Accept: application/vnd.github+json' \
@@ -2781,7 +2752,7 @@ function fetch_and_deploy_codeberg_release() {
     resp=$(curl --connect-timeout 10 --max-time "${api_timeouts[$attempt]}" -fsSL -w "%{http_code}" -o /tmp/codeberg_rel.json "$api_url") && success=true && break
     ((attempt++))
     if ((attempt < ${#api_timeouts[@]})); then
-      msg_warn "API request timed out after ${api_timeouts[$((attempt - 1))]}s, retrying... (attempt $((attempt + 1))/${#api_timeouts[@]})"
+      msg_warn "API request timed out after ${api_timeouts[$((attempt-1))]}s, retrying... (attempt $((attempt + 1))/${#api_timeouts[@]})"
     fi
   done
 
@@ -3263,7 +3234,7 @@ function fetch_and_deploy_gh_release() {
   local max_retries=${#api_timeouts[@]} retry_delay=2 attempt=1 success=false http_code
 
   while ((attempt <= max_retries)); do
-    http_code=$(curl --connect-timeout 10 --max-time "${api_timeouts[$((attempt - 1))]:-240}" -sSL -w "%{http_code}" -o /tmp/gh_rel.json "${header[@]}" "$api_url" 2>/dev/null) || true
+    http_code=$(curl --connect-timeout 10 --max-time "${api_timeouts[$((attempt-1))]:-240}" -sSL -w "%{http_code}" -o /tmp/gh_rel.json "${header[@]}" "$api_url" 2>/dev/null) || true
     if [[ "$http_code" == "200" ]]; then
       success=true
       break