* fix(iptag): Fix syntax error in VM config file parsing
The array assignment was using an invalid pipe construct inside the loop:
vmids+=("${conf##*/}" | sed 's/\.conf$//')
This caused a bash syntax error:
syntax error near unexpected token '2'
Fixed by using:
- shopt -s nullglob to handle empty directories gracefully
- Parameter expansion ${filename%.conf} instead of sed pipe
Fixes#10595
* fix(iptag): Fix syntax error in VM config file parsing
The array assignment was using an invalid pipe construct inside the loop:
vmids+=("${conf##*/}" | sed 's/\.conf$//')
This caused a bash syntax error:
syntax error near unexpected token '2'
Fixed by using parameter expansion ${basename%.conf} instead of sed pipe.
Fixes#10595
Corrected references from 'ProxmoxVED' to 'ProxmoxVE' in sourced URLs across livebook.sh, glances.sh, and pve-privilege-converter.sh to ensure scripts use the correct repository.
* Update host-backup.sh
added an "all" button to include all folders instead of clicking every folder by itself
* Update host-backup.sh
added a timestamp in the filename incase the user wants to make several backups on the same time.
Otherweise the newest backup will overwrite the earlier one.
- **Interactive Configuration**: Added setup wizard for `TAG_FORMAT` (last_two_octets/last_octet/full) and `LOOP_INTERVAL` (30-7200 seconds) during installation/update
- **Unified Installation Menu**: Replaced conditional service detection with unified menu offering install-with-service, install-command-only, and update options
- **Post-Installation Guidance**: Added comprehensive information display about configuration file location (`/opt/iptag/iptag.conf`) and required CIDR_LIST setup
- **Improved VM IP Detection**: Enhanced IP discovery with QM guest agent priority, ARP table validation via ping, and automatic removal of stale ARP entries
- **Visual Indicators**: Replaced emoji symbols with standard ASCII characters (✓/✗) with proper colors for better terminal compatibility
- **Simplified Update Process**: Removed complex service detection logic and provided direct update option in main menu
These changes address user feedback about complex installation requirements, VM IP detection issues, and provide clearer guidance for network subnet configuration.
* Fix: exclude all thin-pools dynamically instead of only 'data'
* Fix: dynamically exclude all thin pools (not just 'data') from orphan check
* Fix: dynamically exclude all thin pools (not just 'data') from orphan check
✅ Summary of Changes from the Initial Version
🧩 1. Tag-Based Filtering (Core Feature)
New feature: Only restart instances (VMs or containers) that have the mon-restart tag.
This makes monitoring and auto-restart controllable directly from the Proxmox Web UI, without editing scripts or services.
Set via GUI: VM → Options → Tags → mon-restart
Set via CLI: qm set <vmid> -tags mon-restart or pct set <ctid> -tags mon-restart
This is the primary new control mechanism, making the script safer, more flexible, and user-friendly.
🧰 2. Backward-Compatible Exclusion Mechanism
The original feature that lets you exclude instances via CLI arguments is preserved:
bash
Copy
Edit
./ping-instances.sh 101 300
These IDs will always be skipped regardless of tag.
🧠 3. Intelligent Responsiveness Checks
For VMs:
Uses qm guest cmd <id> ping to check responsiveness via the QEMU guest agent.
No longer relies on network-level ping, which can be misleading or blocked.
For containers (CTs):
Uses traditional ping to IP addresses obtained from pct exec, since CTs don’t support QEMU agent.
⛔ 4. Instance Skipping Improvements
Instances are now skipped if:
They are explicitly excluded via CLI.
They are templates.
They are configured with onboot: 0 or missing.
They lack the mon-restart tag, regardless of other status.
🪵 5. Same Logging Behavior
All output continues to go to /var/log/ping-instances.log for persistent tracking.
Verbose messages were added for traceability (e.g., why a VM or CT was skipped).
🎯 Why This Matters
With tag-based control, admins can now manage restart behavior dynamically from the Proxmox Web UI, making the script:
More secure (no accidental restarts).
More maintainable (no script edits needed).
More user-friendly (integrated with the UI workflow).
Shell option missing, needed to be able to NO/CANCEL the whiptail dialog box. Without it, the script the NO/CANCEL is without funktion and the script will proceed
This shell option is used in the other scripts, but here it is missing.
