From decda83256fede2addaf8390374db3b891c14cbd Mon Sep 17 00:00:00 2001
From: Tim Moore <1232390+angusmaul@users.noreply.github.com>
Date: Thu, 20 Aug 2026 05:41:41 +1000
Subject: [PATCH] VictoriaMetrics: use github_api_call for release lookups so
 GITHUB_TOKEN is honored (#16607)

The release-tag resolution used raw unauthenticated curl calls, which
ignore GITHUB_TOKEN and fail with curl exit 22 on the shared 60/hr
unauthenticated rate limit - after the container is already created.
Resolve via the existing github_api_call helper (auth + retries +
rate-limit diagnosis), matching proxmox-backup-server-install.sh.
Also collapses the two identical VictoriaLogs /releases/latest calls
into one.

Fixes community-scripts/ProxmoxVE#16606

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
---
 install/victoriametrics-install.sh | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/install/victoriametrics-install.sh b/install/victoriametrics-install.sh
index 6768211bc..fefe732ca 100644
--- a/install/victoriametrics-install.sh
+++ b/install/victoriametrics-install.sh
@@ -15,9 +15,11 @@ update_os
 
 msg_info "Getting latest version of VictoriaMetrics"
 
-victoriametrics_release=$(curl -fsSL "https://api.github.com/repos/VictoriaMetrics/VictoriaMetrics/releases" |
-  jq -r --arg a "$(arch_resolve)" '.[] | select(.assets[].name | match("^victoria-metrics-linux-" + $a + "-v[0-9.]+.tar.gz$")) | .tag_name' |
+vm_releases_json="$(mktemp)"
+github_api_call "https://api.github.com/repos/VictoriaMetrics/VictoriaMetrics/releases" "$vm_releases_json"
+victoriametrics_release=$(jq -r --arg a "$(arch_resolve)" '.[] | select(.assets[].name | match("^victoria-metrics-linux-" + $a + "-v[0-9.]+.tar.gz$")) | .tag_name' "$vm_releases_json" |
   head -n 1)
+rm -f "$vm_releases_json"
 victoriametrics_filename="victoria-metrics-linux-$(arch_resolve)-${victoriametrics_release}.tar.gz"
 vmutils_filename="vmutils-linux-$(arch_resolve)-${victoriametrics_release}.tar.gz"
 msg_ok "Got version $victoriametrics_release of VictoriaMetrics"
@@ -28,12 +30,13 @@ fetch_and_deploy_gh_release "vmutils" "VictoriaMetrics/VictoriaMetrics" "prebuil
 read -r -p "${TAB3}Would you like to add VictoriaLogs? <y/N> " prompt
 
 if [[ ${prompt,,} =~ ^(y|yes)$ ]]; then
-  vmlogs_filename=$(curl -fsSL "https://api.github.com/repos/VictoriaMetrics/VictoriaLogs/releases/latest" |
-    jq -r '.assets[].name' |
+  vl_release_json="$(mktemp)"
+  github_api_call "https://api.github.com/repos/VictoriaMetrics/VictoriaLogs/releases/latest" "$vl_release_json"
+  vmlogs_filename=$(jq -r '.assets[].name' "$vl_release_json" |
     grep -E "^victoria-logs-linux-$(arch_resolve)-v[0-9.]+\.tar\.gz$")
-  vlutils_filename=$(curl -fsSL "https://api.github.com/repos/VictoriaMetrics/VictoriaLogs/releases/latest" |
-    jq -r '.assets[].name' |
+  vlutils_filename=$(jq -r '.assets[].name' "$vl_release_json" |
     grep -E "^vlutils-linux-$(arch_resolve)-v[0-9.]+\.tar\.gz$")
+  rm -f "$vl_release_json"
   fetch_and_deploy_gh_release "victorialogs" "VictoriaMetrics/VictoriaLogs" "prebuild" "latest" "/opt/victoriametrics" "$vmlogs_filename"
   fetch_and_deploy_gh_release "vlutils" "VictoriaMetrics/VictoriaLogs" "prebuild" "latest" "/opt/victoriametrics" "$vlutils_filename"
 fi