From c8c1c454ce140498acf966e05515433c5252a926 Mon Sep 17 00:00:00 2001
From: "CanbiZ (MickLesk)" <47820557+MickLesk@users.noreply.github.com>
Date: Mon, 19 Jan 2026 21:45:59 +0100
Subject: [PATCH] fix(firefly): prevent nested storage directories during
 update (#10967) (#10972)

- Remove existing backup directory before creating new backup
- Clean up temporary files after successful update
---
 ct/firefly.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ct/firefly.sh b/ct/firefly.sh
index f59c2179f..1d1ea1203 100644
--- a/ct/firefly.sh
+++ b/ct/firefly.sh
@@ -32,6 +32,7 @@ function update_script() {
   if check_for_gh_release "firefly" "firefly-iii/firefly-iii"; then
     systemctl stop apache2
     cp /opt/firefly/.env /opt/.env
+    rm -rf /opt/storage
     cp -r /opt/firefly/storage /opt/storage
 
     if [[ -d /opt/firefly/dataimporter ]]; then
@@ -82,6 +83,7 @@ function update_script() {
       chown -R www-data:www-data /opt/firefly/dataimporter
       msg_ok "Updated Firefly Importer"
     fi
+    rm -rf /opt/storage /opt/.env /opt/dataimporter.env
     systemctl start apache2
     msg_ok "Updated successfully!"
   fi