From c780fd7dfa9f285c782ef2f49200976d0aaf9b9f Mon Sep 17 00:00:00 2001 From: MickLesk Date: Tue, 21 Jul 2026 23:08:01 +0200 Subject: [PATCH] Actually pin the branch nextcloudpi's install.sh clones internally install.sh is only a thin bootstrapper: it clones BRANCH (default "master") of the nextcloudpi repo itself and runs the real installer from that fresh checkout, including the distro-support check. Fetching install.sh from a pinned tag alone left BRANCH defaulting to "master", so the internally-cloned code was unaffected and still failed with "distro not supported" - confirmed by testing the previous fix. Pass BRANCH explicitly so the internal clone also targets the pinned tag. --- install/nextcloudpi-install.sh | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/install/nextcloudpi-install.sh b/install/nextcloudpi-install.sh index a083fd623..2fba5f49f 100644 --- a/install/nextcloudpi-install.sh +++ b/install/nextcloudpi-install.sh @@ -27,11 +27,7 @@ if [[ ! "$CONFIRM" =~ ^([yY][eE][sS]|[yY])$ ]]; then fi msg_info "Installing NextCloudPi (Patience)" -# Pinned to the last known-good stable release instead of the floating "master" -# branch: master has repeatedly broken distro detection on our default Debian -# base out from under this script (e.g. #15944), since it's third-party code -# not audited or version-locked by us. -$STD bash <(curl -fsSL "https://raw.githubusercontent.com/nextcloud/nextcloudpi/${NCP_INSTALLER_REF}/install.sh") +BRANCH="${NCP_INSTALLER_REF}" $STD bash <(curl -fsSL "https://raw.githubusercontent.com/nextcloud/nextcloudpi/${NCP_INSTALLER_REF}/install.sh") msg_ok "Installed NextCloudPi" motd_ssh