From bd3fbb399967b80397dbffed6af605cef273b7a9 Mon Sep 17 00:00:00 2001
From: "CanbiZ (MickLesk)" <47820557+MickLesk@users.noreply.github.com>
Date: Mon, 20 Apr 2026 13:22:44 +0200
Subject: [PATCH] Several Scripts: Bump NodeJS to align Node.js versions with
 upstream for 5 scripts (#13875)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* fix(node): align Node.js versions with upstream for 5 scripts

Update scripts where upstream requires a newer Node.js version:
- iobroker: 22 → 24 (upstream .nvmrc)
- kima-hub: 20 → 22 (upstream Dockerfile)
- myip: 22 → 24 (upstream Dockerfile)
- outline: 22 → 24 (upstream Dockerfile)
- shelfmark: 22 → 24 (upstream Dockerfile)

Skipped 15 scripts where our version is already newer than upstream.

Ref: community-scripts/ProxmoxVE#13870

* fix(node): add setup_nodejs to update scripts for iobroker, kima-hub, myip

These three scripts had NODE_VERSION in install but not in update,
so running an update would not upgrade Node.js to the correct version.

- iobroker: add NODE_VERSION=24
- kima-hub: add NODE_VERSION=22
- myip: add NODE_VERSION=24
---
 ct/iobroker.sh               | 3 +++
 ct/kima-hub.sh               | 2 ++
 ct/myip.sh                   | 2 ++
 ct/outline.sh                | 2 +-
 ct/shelfmark.sh              | 2 +-
 install/iobroker-install.sh  | 2 +-
 install/kima-hub-install.sh  | 2 +-
 install/myip-install.sh      | 2 +-
 install/outline-install.sh   | 2 +-
 install/shelfmark-install.sh | 2 +-
 10 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/ct/iobroker.sh b/ct/iobroker.sh
index 3856ff335..77d06babb 100644
--- a/ct/iobroker.sh
+++ b/ct/iobroker.sh
@@ -27,6 +27,9 @@ function update_script() {
     msg_error "No ${APP} Installation Found!"
     exit
   fi
+
+  NODE_VERSION="24" setup_nodejs
+
   msg_info "Updating ${APP} LXC"
   $STD apt update
   $STD apt -y upgrade
diff --git a/ct/kima-hub.sh b/ct/kima-hub.sh
index a1f3da652..d93375e42 100644
--- a/ct/kima-hub.sh
+++ b/ct/kima-hub.sh
@@ -29,6 +29,8 @@ function update_script() {
     exit
   fi
 
+  NODE_VERSION="22" setup_nodejs
+
   if check_for_gh_release "kima-hub" "Chevron7Locked/kima-hub"; then
     msg_info "Stopping Services"
     systemctl stop kima-frontend kima-backend kima-analyzer kima-analyzer-clap
diff --git a/ct/myip.sh b/ct/myip.sh
index b648f5f4c..c092a3289 100644
--- a/ct/myip.sh
+++ b/ct/myip.sh
@@ -28,6 +28,8 @@ function update_script() {
     exit
   fi
 
+  NODE_VERSION="24" setup_nodejs
+
   if check_for_gh_release "myip" "jason5ng32/MyIP"; then
     msg_info "Stopping Services"
     systemctl stop myip
diff --git a/ct/outline.sh b/ct/outline.sh
index 9e1a45b6b..6f98fb938 100644
--- a/ct/outline.sh
+++ b/ct/outline.sh
@@ -28,7 +28,7 @@ function update_script() {
     exit
   fi
 
-  NODE_VERSION="22" setup_nodejs
+  NODE_VERSION="24" setup_nodejs
 
   if check_for_gh_release "outline" "outline/outline"; then
     msg_info "Stopping Services"
diff --git a/ct/shelfmark.sh b/ct/shelfmark.sh
index 04a4fa4bd..4a0756373 100644
--- a/ct/shelfmark.sh
+++ b/ct/shelfmark.sh
@@ -29,7 +29,7 @@ function update_script() {
     exit
   fi
 
-  NODE_VERSION="22" setup_nodejs
+  NODE_VERSION="24" setup_nodejs
   PYTHON_VERSION="3.12" setup_uv
 
   if check_for_gh_release "shelfmark" "calibrain/shelfmark"; then
diff --git a/install/iobroker-install.sh b/install/iobroker-install.sh
index ec74dceb4..b9f48b713 100644
--- a/install/iobroker-install.sh
+++ b/install/iobroker-install.sh
@@ -28,7 +28,7 @@ if [[ ! "$CONFIRM" =~ ^([yY][eE][sS]|[yY])$ ]]; then
   exit 10
 fi
 
-NODE_VERSION="22" setup_nodejs
+NODE_VERSION="24" setup_nodejs
 
 msg_info "Installing ioBroker (Patience)"
 $STD bash <(curl -fsSL https://iobroker.net/install.sh)
diff --git a/install/kima-hub-install.sh b/install/kima-hub-install.sh
index 54cad2b88..850da5a36 100644
--- a/install/kima-hub-install.sh
+++ b/install/kima-hub-install.sh
@@ -28,7 +28,7 @@ msg_ok "Installed Dependencies"
 
 PG_VERSION="16" PG_MODULES="pgvector" setup_postgresql
 PG_DB_NAME="kima" PG_DB_USER="kima" PG_DB_GRANT_SUPERUSER="true" setup_postgresql_db
-NODE_VERSION="20" setup_nodejs
+NODE_VERSION="22" setup_nodejs
 
 msg_info "Configuring Redis"
 systemctl enable -q --now redis-server
diff --git a/install/myip-install.sh b/install/myip-install.sh
index f70847cbb..be8bcb203 100644
--- a/install/myip-install.sh
+++ b/install/myip-install.sh
@@ -13,7 +13,7 @@ setting_up_container
 network_check
 update_os
 
-NODE_VERSION="22" setup_nodejs
+NODE_VERSION="24" setup_nodejs
 fetch_and_deploy_gh_release "myip" "jason5ng32/MyIP" "tarball"
 
 msg_info "Configuring MyIP"
diff --git a/install/outline-install.sh b/install/outline-install.sh
index 0c30cac1d..9bacffe8f 100644
--- a/install/outline-install.sh
+++ b/install/outline-install.sh
@@ -20,7 +20,7 @@ $STD apt install -y \
   redis
 msg_ok "Installed Dependencies"
 
-NODE_VERSION="22" setup_nodejs
+NODE_VERSION="24" setup_nodejs
 PG_VERSION="16" setup_postgresql
 PG_DB_NAME="outline" PG_DB_USER="outline" setup_postgresql_db
 
diff --git a/install/shelfmark-install.sh b/install/shelfmark-install.sh
index 961a7e1c2..b6195a08b 100644
--- a/install/shelfmark-install.sh
+++ b/install/shelfmark-install.sh
@@ -115,7 +115,7 @@ else
   msg_ok "Installed internal bypasser dependencies"
 fi
 
-NODE_VERSION="22" setup_nodejs
+NODE_VERSION="24" setup_nodejs
 PYTHON_VERSION="3.12" setup_uv
 
 fetch_and_deploy_gh_release "shelfmark" "calibrain/shelfmark" "tarball" "latest" "/opt/shelfmark"