From b3550b99e0241de080b81fa67a1427cc0bd97ac5 Mon Sep 17 00:00:00 2001
From: MickLesk <mickey.leskowitz@gmail.com>
Date: Mon, 3 Aug 2026 10:28:52 +0200
Subject: [PATCH] correct exit codes

---
 tools/addon/all-templates.sh     | 10 +++++-----
 tools/addon/coder-code-server.sh |  2 +-
 tools/addon/homebrew.sh          |  2 +-
 tools/addon/komodo.sh            |  2 +-
 tools/addon/netdata.sh           |  2 +-
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/tools/addon/all-templates.sh b/tools/addon/all-templates.sh
index c93681251..481b28c33 100644
--- a/tools/addon/all-templates.sh
+++ b/tools/addon/all-templates.sh
@@ -134,7 +134,7 @@ function select_storage() {
     ;;
   *)
     msg_error "Invalid storage class."
-    exit 1
+    exit 112
     ;;
   esac
 
@@ -156,7 +156,7 @@ function select_storage() {
   if [ $((${#MENU[@]} / 3)) -eq 0 ]; then
     msg_warn "'$CONTENT_LABEL' needs to be selected for at least one storage location."
     msg_error "Unable to detect valid storage location."
-    exit 1
+    if [[ "$CONTENT" == "rootdir" ]]; then exit 119; else exit 120; fi
   elif [ $((${#MENU[@]} / 3)) -eq 1 ]; then
     printf ${MENU[0]}
   else
@@ -167,7 +167,7 @@ function select_storage() {
         16 $(($MSG_MAX_LENGTH + 23)) 6 \
         "${MENU[@]}" 3>&1 1>&2 2>&3) || {
         msg_error "Menu aborted."
-        exit 1
+        exit 254
       }
     done
     printf $STORAGE
@@ -186,7 +186,7 @@ msg_info "Using '$CONTAINER_STORAGE' for container storage."
 msg_info "Downloading LXC template (Patience)"
 pveam download $TEMPLATE_STORAGE $TEMPLATE >/dev/null || {
   msg_error "A problem occured while downloading the LXC template."
-  exit 1
+  exit 222
 }
 msg_ok "Downloaded LXC template"
 
@@ -198,7 +198,7 @@ PCT_OPTIONS=(${PCT_OPTIONS[@]:-${DEFAULT_PCT_OPTIONS[@]}})
 msg_info "Creating LXC container"
 pct create $CTID ${TEMPLATE_STORAGE}:vztmpl/${TEMPLATE} "${PCT_OPTIONS[@]}" >/dev/null || {
   msg_error "A problem occured while trying to create container."
-  exit 1
+  exit 209
 }
 msg_ok "Created LXC container"
 
diff --git a/tools/addon/coder-code-server.sh b/tools/addon/coder-code-server.sh
index 549440b30..b75bc36a4 100644
--- a/tools/addon/coder-code-server.sh
+++ b/tools/addon/coder-code-server.sh
@@ -96,7 +96,7 @@ EOF
   systemctl restart code-server@"$USER"
   if ! systemctl is-active --quiet code-server@"$USER"; then
     msg_error "code-server service failed to start."
-    exit 1
+    exit 150
   fi
   msg_ok "Installed ${APP}"
 
diff --git a/tools/addon/homebrew.sh b/tools/addon/homebrew.sh
index f06299b3b..77e1f134f 100644
--- a/tools/addon/homebrew.sh
+++ b/tools/addon/homebrew.sh
@@ -75,7 +75,7 @@ function install() {
       msg_ok "Created user 'brew'"
     else
       msg_error "Cannot install Homebrew without a non-root user. Exiting."
-      exit 1
+      exit 254
     fi
   fi
   msg_ok "Detected User: $BREW_USER"
diff --git a/tools/addon/komodo.sh b/tools/addon/komodo.sh
index f48fe1d00..69765ddf6 100644
--- a/tools/addon/komodo.sh
+++ b/tools/addon/komodo.sh
@@ -150,7 +150,7 @@ function ensure_openssl() {
     $STD apt-get install -y openssl
   else
     msg_error "openssl is required but could not be installed automatically."
-    exit 10
+    exit 237
   fi
   msg_ok "Installed openssl"
 }
diff --git a/tools/addon/netdata.sh b/tools/addon/netdata.sh
index fb8e903a0..7e04ff0b9 100644
--- a/tools/addon/netdata.sh
+++ b/tools/addon/netdata.sh
@@ -40,7 +40,7 @@ detect_codename() {
   CODENAME="${VERSION_CODENAME:-}"
   if [[ -z "$CODENAME" ]]; then
     msg_error "Could not detect Debian codename."
-    exit 71
+    exit 238
   fi
   echo "$CODENAME"
 }