Refactor: harmonize tools/addon and move boilerplate into core.func (#16202)

tools/addon/crowdsec.sh

@@ -5,89 +5,61 @@
 # License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
 # Source: https://www.crowdsec.net/ | Github: https://github.com/crowdsecurity/crowdsec
 
-YW=$(echo "\033[33m")
-BL=$(echo "\033[36m")
-RD=$(echo "\033[01;31m")
-BGN=$(echo "\033[4;92m")
-GN=$(echo "\033[1;92m")
-DGN=$(echo "\033[32m")
-CL=$(echo "\033[m")
-BFR="\\r\\033[K"
-HOLD="-"
-CM="${GN}✓${CL}"
 APP="CrowdSec"
-hostname="$(hostname)"
+APP_TYPE="addon"
 
-# Telemetry
+if ! command -v curl &>/dev/null; then
+  printf "\r\e[2K%b" '\033[93m Setup Source \033[m' >&2
+  if [[ -f /etc/alpine-release ]]; then
+    apk update >/dev/null 2>&1
+    apk add --no-cache curl >/dev/null 2>&1
+  else
+    apt-get update >/dev/null 2>&1
+    apt-get install -y curl >/dev/null 2>&1
+  fi
+fi
+source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/core.func)
+source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/tools.func)
+source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/error_handler.func)
 source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/api.func) 2>/dev/null || true
 declare -f init_tool_telemetry &>/dev/null && init_tool_telemetry "crowdsec" "addon"
 
-set -o errexit
-set -o errtrace
-set -o nounset
-set -o pipefail
-shopt -s expand_aliases
-alias die='EXIT=$? LINE=$LINENO error_exit'
-trap die ERR
+# Enable error handling
+set -Eeuo pipefail
+trap 'error_handler' ERR
+
+# Initialize all core functions (colors, formatting, icons, STD mode)
+load_functions
+require_debian_like
+
+header_info
+confirm_not_pve_host
 
-function error_exit() {
-  trap - ERR
-  local reason="Unknown failure occured."
-  local msg="${1:-$reason}"
-  local flag="${RD}‼ ERROR ${CL}$EXIT@$LINE"
-  echo -e "$flag $msg" 1>&2
-  exit "$EXIT"
-}
-if command -v pveversion >/dev/null 2>&1; then
-  echo -e "⚠️  Can't Install on Proxmox "
-  exit
-fi
 while true; do
-  read -p "This will Install ${APP} on $hostname. Proceed(y/n)?" yn
+  echo -n "${TAB}This will Install ${APP}. Proceed (y/n)? "
+  read -r yn
   case $yn in
   [Yy]*) break ;;
   [Nn]*) exit ;;
   *) echo "Please answer yes or no." ;;
   esac
 done
-clear
-function header_info() {
-  echo -e "${BL}
-   _____                      _  _____           
-  / ____|                    | |/ ____|          
- | |     _ __ _____      ____| | (___   ___  ___ 
- | |    |  __/ _ \ \ /\ / / _  |\___ \ / _ \/ __|
- | |____| | | (_) \ V  V / (_| |____) |  __/ (__ 
-  \_____|_|  \___/ \_/\_/ \__ _|_____/ \___|\___|
-${CL}"
-}
-
-header_info
-
-function msg_info() {
-  local msg="$1"
-  echo -ne " ${HOLD} ${YW}${msg}..."
-}
-
-function msg_ok() {
-  local msg="$1"
-  echo -e "${BFR} ${CM} ${GN}${msg}${CL}"
-}
 
 msg_info "Setting up ${APP} Repository"
-apt-get update &>/dev/null
-apt-get install -y curl &>/dev/null
-apt-get install -y gnupg &>/dev/null
-curl -fsSL "https://install.crowdsec.net" | bash &>/dev/null
+$STD apt update
+$STD apt install -y \
+  curl \
+  gnupg
+$STD bash -c "curl -fsSL https://install.crowdsec.net | bash"
 msg_ok "Setup ${APP} Repository"
 
 msg_info "Installing ${APP}"
-apt-get update &>/dev/null
-apt-get install -y crowdsec &>/dev/null
-msg_ok "Installed ${APP} on $hostname"
+$STD apt update
+$STD apt install -y crowdsec
+msg_ok "Installed ${APP}"
 
 msg_info "Installing ${APP} Common Bouncer"
-apt-get install -y crowdsec-firewall-bouncer-iptables &>/dev/null
+$STD apt install -y crowdsec-firewall-bouncer-iptables
 msg_ok "Installed ${APP} Common Bouncer"
 
 msg_ok "Completed successfully!\n"