Refactor/core qol adoption (#17655)

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-10-08 12:01:01 +02:00

* Scripts: close every msg_info block with msg_ok

Past-tense msg_info calls that should have been msg_ok, notices that opened a block before a prompt, and blocks without a closing msg_ok. These already left a stale spinner; with core's block stack they would resume it after every later msg_ok.

* Generate passwords with random_password

openssl rand -base64 | tr -dc | head -c returned fewer characters than asked for, and the unfiltered | cut variants put / and + into passwords that end up in DSNs and sed expressions. Secrets an app decodes as base64 are unchanged. Requires community-scripts/core#61.

* Keep data directories through CLEAN_INSTALL instead of copying them

create_backup copied uploads, storage and similar directories twice per update and needed their size again in free space. CLEAN_INSTALL_KEEP moves them aside instead. Only directories the upstream release does not ship, in scripts that restored right after the fetch. Requires community-scripts/core#61.

* Drop the 300s uv timeout overrides

setup_uv exports UV_HTTP_TIMEOUT=600 now; the scripts' 300 only lowered it. Requires community-scripts/core#61.

This commit is contained in:

CanbiZ (MickLesk)

2026-10-03 08:19:10 +02:00

committed by

GitHub

parent 45599d63ec

commit 7f57d0998c

169 changed files with 224 additions and 275 deletions

									
										install/immich-install.sh
									
		-1
	
												View File
												
				@@ -430,7 +430,6 @@ chown immich:immich "$INSTALL_DIR"

				find "$INSTALL_DIR" -maxdepth 1 -mindepth 1 ! -name upload -exec chown -R immich:immich {} +

				chown immich:immich "$UPLOAD_DIR" 2>/dev/null || true

				export VIRTUAL_ENV="${ML_DIR}/ml-venv"

				export UV_HTTP_TIMEOUT=300

				if [[ -f ~/.openvino ]]; then

				  ML_PYTHON="python3.13"

				  msg_info "Pre-installing Python ${ML_PYTHON} for machine-learning"