refactor: harmonize architecture detection and improve installation scripts for addons

tools/addon/netdata.sh

@@ -5,6 +5,22 @@
 # License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
 # Source: https://www.netdata.cloud/ | Github: https://github.com/netdata/netdata
 
+APP="Netdata"
+APP_TYPE="addon"
+
+source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/core.func)
+source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/tools.func)
+source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/error_handler.func)
+source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/api.func) 2>/dev/null || true
+declare -f init_tool_telemetry &>/dev/null && init_tool_telemetry "netdata" "addon"
+
+# Enable error handling
+set -Eeuo pipefail
+trap 'error_handler' ERR
+
+# Initialize all core functions (colors, formatting, icons, STD mode)
+load_functions
+
 function header_info {
   clear
   cat <<"EOF"
@@ -17,63 +33,6 @@ function header_info {
 EOF
 }
 
-YW=$(echo "\033[33m")
-BL=$(echo "\033[36m")
-RD=$(echo "\033[01;31m")
-GN=$(echo "\033[1;92m")
-CL=$(echo "\033[m")
-BFR="\\r\\033[K"
-HOLD="-"
-CM="${GN}✓${CL}"
-silent() { "$@" >/dev/null 2>&1; }
-
-# Telemetry
-source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/api.func) 2>/dev/null || true
-declare -f init_tool_telemetry &>/dev/null && init_tool_telemetry "netdata" "addon"
-
-set -e
-header_info
-echo "Loading..."
-function msg_info() {
-  local msg="$1"
-  echo -ne " ${HOLD} ${YW}${msg}..."
-}
-
-function msg_ok() {
-  local msg="$1"
-  echo -e "${BFR} ${CM} ${GN}${msg}${CL}"
-}
-
-function msg_error() { echo -e "${RD}✗ $1${CL}"; }
-
-# This function checks the version of Proxmox Virtual Environment (PVE) and exits if the version is not supported.
-# Supported: Proxmox VE 8.0.x – 8.9.x and 9.0–9.x
-pve_check() {
-  local PVE_VER
-  PVE_VER="$(pveversion | awk -F'/' '{print $2}' | awk -F'-' '{print $1}')"
-
-  # Check for Proxmox VE 8.x: allow 8.0–8.9
-  if [[ "$PVE_VER" =~ ^8\.([0-9]+) ]]; then
-    local MINOR="${BASH_REMATCH[1]}"
-    if ((MINOR < 0 || MINOR > 9)); then
-      msg_error "This version of Proxmox VE is not supported."
-      msg_error "Supported: Proxmox VE version 8.0 – 8.9"
-      exit 105
-    fi
-    return 0
-  fi
-
-  # Check for Proxmox VE 9.x: allow 9.0–9.x
-  if [[ "$PVE_VER" =~ ^9\.([0-9]+) ]]; then
-    return 0
-  fi
-
-  # All other unsupported versions
-  msg_error "This version of Proxmox VE is not supported."
-  msg_error "Supported versions: Proxmox VE 8.0 – 8.9 or 9.0–9.x"
-  exit 105
-}
-
 detect_codename() {
   source /etc/os-release
   if [[ "$ID" != "debian" ]]; then
@@ -99,7 +58,7 @@ get_latest_repo_pkg() {
 install() {
   header_info
   while true; do
-    read -p "Are you sure you want to install NetData on Proxmox VE host. Proceed(y/n)? " yn
+    read -r -p "Are you sure you want to install ${APP} on Proxmox VE host. Proceed(y/n)? " yn
     case $yn in
     [Yy]*) break ;;
     [Nn]*) exit ;;
@@ -107,56 +66,52 @@ install() {
     esac
   done
 
-  read -r -p "Verbose mode? <y/N> " prompt
-  [[ ${prompt,,} =~ ^(y|yes)$ ]] && STD="" || STD="silent"
-
   CODENAME=$(detect_codename)
   REPO_URL="https://repo.netdata.cloud/repos/repoconfig/debian/${CODENAME}/"
 
   msg_info "Setting up repository"
-  $STD apt-get install -y debian-keyring
+  $STD apt install -y debian-keyring
   PKG=$(get_latest_repo_pkg "$REPO_URL")
   if [[ -z "$PKG" ]]; then
     msg_error "Could not find netdata-repo package for Debian $CODENAME"
     exit 237
   fi
-  curl -fsSL "${REPO_URL}${PKG}" -o "$PKG"
-  $STD dpkg -i "$PKG"
-  rm -f "$PKG"
+  TMP_DEB=$(mktemp --suffix=.deb)
+  curl -fsSL "${REPO_URL}${PKG}" -o "$TMP_DEB"
+  $STD dpkg -i "$TMP_DEB"
+  rm -f "$TMP_DEB"
   msg_ok "Set up repository"
 
-  msg_info "Installing Netdata"
-  $STD apt-get update
-  $STD apt-get install -y netdata
-  msg_ok "Installed Netdata"
+  msg_info "Installing ${APP}"
+  $STD apt update
+  $STD apt install -y netdata
+  msg_ok "Installed ${APP}"
   msg_ok "Completed successfully!\n"
-  echo -e "\n Netdata should be reachable at${BL} http://$(hostname -I | awk '{print $1}'):19999 ${CL}\n"
+  echo -e "\n${APP} should be reachable at${BL} http://$(hostname -I | awk '{print $1}'):19999 ${CL}\n"
 }
 
 uninstall() {
   header_info
-  read -r -p "Verbose mode? <y/N> " prompt
-  [[ ${prompt,,} =~ ^(y|yes)$ ]] && STD="" || STD="silent"
 
-  msg_info "Uninstalling Netdata"
+  msg_info "Uninstalling ${APP}"
   systemctl stop netdata || true
   rm -rf /var/log/netdata /var/lib/netdata /var/cache/netdata /etc/netdata/go.d
   rm -rf /etc/apt/trusted.gpg.d/netdata-archive-keyring.gpg /etc/apt/sources.list.d/netdata.list
-  $STD apt-get remove --purge -y netdata netdata-repo
+  $STD apt remove --purge -y netdata netdata-repo
   systemctl daemon-reload
   $STD apt autoremove -y
   $STD userdel netdata || true
-  msg_ok "Uninstalled Netdata"
+  msg_ok "Uninstalled ${APP}"
   msg_ok "Completed successfully!\n"
 }
 
 header_info
 pve_check
 
-OPTIONS=(Install "Install NetData on Proxmox VE"
-  Uninstall "Uninstall NetData from Proxmox VE")
+OPTIONS=(Install "Install ${APP} on Proxmox VE"
+  Uninstall "Uninstall ${APP} from Proxmox VE")
 
-CHOICE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --title "NetData" \
+CHOICE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --title "${APP}" \
   --menu "Select an option:" 10 58 2 "${OPTIONS[@]}" 3>&1 1>&2 2>&3)
 
 case $CHOICE in