diff --git a/vm/archlinux-vm.sh b/vm/archlinux-vm.sh index 03a56d194..80a6f9927 100644 --- a/vm/archlinux-vm.sh +++ b/vm/archlinux-vm.sh @@ -93,20 +93,20 @@ function get_valid_nextid() { } function cleanup_vmid() { - if qm status "$VMID" &>/dev/null; then - qm stop "$VMID" &>/dev/null - qm destroy "$VMID" &>/dev/null + if qm status $VMID &>/dev/null; then + qm stop $VMID &>/dev/null + qm destroy $VMID &>/dev/null fi } function cleanup() { popd >/dev/null post_update_to_api "done" "none" - rm -rf "$TEMP_DIR" + rm -rf $TEMP_DIR } TEMP_DIR=$(mktemp -d) -pushd "$TEMP_DIR" >/dev/null +pushd $TEMP_DIR >/dev/null if whiptail --backtitle "Proxmox VE Helper Scripts" --title "Arch Linux VM" --yesno "This will create a New Arch Linux VM. Proceed?" 10 58; then : else @@ -494,14 +494,14 @@ for i in {0,1}; do done msg_info "Creating a Arch Linux VM" -qm create "$VMID" -agent 1"${MACHINE}" -tablet 0 -localtime 1 -bios ovmf"${CPU_TYPE}" -cores "$CORE_COUNT" -memory "$RAM_SIZE" \ - -name "$HN" -tags community-script -net0 virtio,bridge="$BRG",macaddr="$MAC"$VLAN"$MTU" -onboot 1 -ostype l26 -scsihw virtio-scsi-pci -pvesm alloc "$STORAGE" "$VMID" "$DISK0" 4M 1>&/dev/null -qm importdisk "$VMID" "${FILE}" "$STORAGE" "${DISK_IMPORT:-}" 1>&/dev/null -qm set "$VMID" \ - -efidisk0 "${DISK0_REF}"${FORMAT} \ - -scsi0 "${DISK1_REF}",${DISK_CACHE}${THIN}size="${DISK_SIZE}" \ - -ide2 "${STORAGE}":cloudinit \ +qm create $VMID -agent 1${MACHINE} -tablet 0 -localtime 1 -bios ovmf${CPU_TYPE} -cores $CORE_COUNT -memory $RAM_SIZE \ + -name $HN -tags community-script -net0 virtio,bridge=$BRG,macaddr=$MAC$VLAN$MTU -onboot 1 -ostype l26 -scsihw virtio-scsi-pci +pvesm alloc $STORAGE $VMID $DISK0 4M 1>&/dev/null +qm importdisk $VMID ${FILE} $STORAGE ${DISK_IMPORT:-} 1>&/dev/null +qm set $VMID \ + -efidisk0 ${DISK0_REF}${FORMAT} \ + -scsi0 ${DISK1_REF},${DISK_CACHE}${THIN}size=${DISK_SIZE} \ + -ide2 ${STORAGE}:cloudinit \ -boot order=scsi0 \ -serial0 socket >/dev/null DESCRIPTION=$( @@ -534,19 +534,19 @@ DESCRIPTION=$( EOF ) -qm set "$VMID" -description "$DESCRIPTION" >/dev/null +qm set $VMID -description "$DESCRIPTION" >/dev/null if [ -n "$DISK_SIZE" ]; then msg_info "Resizing disk to $DISK_SIZE GB" - qm resize "$VMID" scsi0 "${DISK_SIZE}" >/dev/null + qm resize $VMID scsi0 ${DISK_SIZE} >/dev/null else msg_info "Using default disk size of $DEFAULT_DISK_SIZE GB" - qm resize "$VMID" scsi0 "${DEFAULT_DISK_SIZE}" >/dev/null + qm resize $VMID scsi0 ${DEFAULT_DISK_SIZE} >/dev/null fi msg_ok "Created a Arch Linux VM ${CL}${BL}(${HN})" if [ "$START_VM" == "yes" ]; then msg_info "Starting Arch Linux VM" - qm start "$VMID" + qm start $VMID msg_ok "Started Arch Linux VM" fi post_update_to_api "done" "none" diff --git a/vm/debian-13-vm.sh b/vm/debian-13-vm.sh index 13d3185ee..6082e89a1 100644 --- a/vm/debian-13-vm.sh +++ b/vm/debian-13-vm.sh @@ -93,20 +93,20 @@ function get_valid_nextid() { } function cleanup_vmid() { - if qm status "$VMID" &>/dev/null; then - qm stop "$VMID" &>/dev/null - qm destroy "$VMID" &>/dev/null + if qm status $VMID &>/dev/null; then + qm stop $VMID &>/dev/null + qm destroy $VMID &>/dev/null fi } function cleanup() { popd >/dev/null post_update_to_api "done" "none" - rm -rf "$TEMP_DIR" + rm -rf $TEMP_DIR } TEMP_DIR=$(mktemp -d) -pushd "$TEMP_DIR" >/dev/null +pushd $TEMP_DIR >/dev/null if whiptail --backtitle "Proxmox VE Helper Scripts" --title "Debian 13 VM" --yesno "This will create a New Debian 13 VM. Proceed?" 10 58; then : else @@ -509,21 +509,21 @@ for i in {0,1}; do done msg_info "Creating a Debian 13 VM" -qm create "$VMID" -agent 1"${MACHINE}" -tablet 0 -localtime 1 -bios ovmf"${CPU_TYPE}" -cores "$CORE_COUNT" -memory "$RAM_SIZE" \ - -name "$HN" -tags community-script -net0 virtio,bridge="$BRG",macaddr="$MAC"$VLAN"$MTU" -onboot 1 -ostype l26 -scsihw virtio-scsi-pci -pvesm alloc "$STORAGE" "$VMID" "$DISK0" 4M 1>&/dev/null -qm importdisk "$VMID" "${FILE}" "$STORAGE" "${DISK_IMPORT:-}" 1>&/dev/null +qm create $VMID -agent 1${MACHINE} -tablet 0 -localtime 1 -bios ovmf${CPU_TYPE} -cores $CORE_COUNT -memory $RAM_SIZE \ + -name $HN -tags community-script -net0 virtio,bridge=$BRG,macaddr=$MAC$VLAN$MTU -onboot 1 -ostype l26 -scsihw virtio-scsi-pci +pvesm alloc $STORAGE $VMID $DISK0 4M 1>&/dev/null +qm importdisk $VMID ${FILE} $STORAGE ${DISK_IMPORT:-} 1>&/dev/null if [ "$CLOUD_INIT" == "yes" ]; then - qm set "$VMID" \ - -efidisk0 "${DISK0_REF}"${FORMAT} \ - -scsi0 "${DISK1_REF}",${DISK_CACHE}${THIN}size="${DISK_SIZE}" \ - -scsi1 "${STORAGE}":cloudinit \ + qm set $VMID \ + -efidisk0 ${DISK0_REF}${FORMAT} \ + -scsi0 ${DISK1_REF},${DISK_CACHE}${THIN}size=${DISK_SIZE} \ + -scsi1 ${STORAGE}:cloudinit \ -boot order=scsi0 \ -serial0 socket >/dev/null else - qm set "$VMID" \ - -efidisk0 "${DISK0_REF}"${FORMAT} \ - -scsi0 "${DISK1_REF}",${DISK_CACHE}${THIN}size="${DISK_SIZE}" \ + qm set $VMID \ + -efidisk0 ${DISK0_REF}${FORMAT} \ + -scsi0 ${DISK1_REF},${DISK_CACHE}${THIN}size=${DISK_SIZE} \ -boot order=scsi0 \ -serial0 socket >/dev/null fi @@ -557,19 +557,19 @@ DESCRIPTION=$( EOF ) -qm set "$VMID" -description "$DESCRIPTION" >/dev/null +qm set $VMID -description "$DESCRIPTION" >/dev/null if [ -n "$DISK_SIZE" ]; then msg_info "Resizing disk to $DISK_SIZE GB" - qm resize "$VMID" scsi0 "${DISK_SIZE}" >/dev/null + qm resize $VMID scsi0 ${DISK_SIZE} >/dev/null else msg_info "Using default disk size of $DEFAULT_DISK_SIZE GB" - qm resize "$VMID" scsi0 "${DEFAULT_DISK_SIZE}" >/dev/null + qm resize $VMID scsi0 ${DEFAULT_DISK_SIZE} >/dev/null fi msg_ok "Created a Debian 13 VM ${CL}${BL}(${HN})" if [ "$START_VM" == "yes" ]; then msg_info "Starting Debian 13 VM" - qm start "$VMID" + qm start $VMID msg_ok "Started Debian 13 VM" fi diff --git a/vm/debian-vm.sh b/vm/debian-vm.sh index f7319efb4..7692b8c3d 100644 --- a/vm/debian-vm.sh +++ b/vm/debian-vm.sh @@ -1,6 +1,6 @@ #!/usr/bin/env bash -# Copyright (c) 2021-2026 community-scripts ORG +# Copyright (c) 2021-2025 community-scripts ORG # Author: MickLesk (CanbiZ) # License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE @@ -93,20 +93,20 @@ function get_valid_nextid() { } function cleanup_vmid() { - if qm status "$VMID" &>/dev/null; then - qm stop "$VMID" &>/dev/null - qm destroy "$VMID" &>/dev/null + if qm status $VMID &>/dev/null; then + qm stop $VMID &>/dev/null + qm destroy $VMID &>/dev/null fi } function cleanup() { popd >/dev/null post_update_to_api "done" "none" - rm -rf "$TEMP_DIR" + rm -rf $TEMP_DIR } TEMP_DIR=$(mktemp -d) -pushd "$TEMP_DIR" >/dev/null +pushd $TEMP_DIR >/dev/null if whiptail --backtitle "Proxmox VE Helper Scripts" --title "Debian 12 VM" --yesno "This will create a New Debian 12 VM. Proceed?" 10 58; then : else @@ -239,7 +239,7 @@ function advanced_settings() { METHOD="advanced" [ -z "${VMID:-}" ] && VMID=$(get_valid_nextid) while true; do - if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 "$VMID" --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then + if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $VMID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then if [ -z "$VMID" ]; then VMID=$(get_valid_nextid) fi @@ -259,7 +259,7 @@ function advanced_settings() { "i440fx" "Machine i440fx" ON \ "q35" "Machine q35" OFF \ 3>&1 1>&2 2>&3); then - if [ "$MACH" = q35 ]; then + if [ $MACH = q35 ]; then echo -e "${CONTAINERTYPE}${BOLD}${DGN}Machine Type: ${BGN}$MACH${CL}" FORMAT="" MACHINE=" -machine q35" @@ -291,7 +291,7 @@ function advanced_settings() { "0" "None (Default)" ON \ "1" "Write Through" OFF \ 3>&1 1>&2 2>&3); then - if [ "$DISK_CACHE" = "1" ]; then + if [ $DISK_CACHE = "1" ]; then echo -e "${DISKSIZE}${BOLD}${DGN}Disk Cache: ${BGN}Write Through${CL}" DISK_CACHE="cache=writethrough," else @@ -303,11 +303,11 @@ function advanced_settings() { fi if VM_NAME=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Hostname" 8 58 debian --title "HOSTNAME" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then - if [ -z "$VM_NAME" ]; then + if [ -z $VM_NAME ]; then HN="debian" echo -e "${HOSTNAME}${BOLD}${DGN}Hostname: ${BGN}$HN${CL}" else - HN=$(echo "${VM_NAME,,}" | tr -d ' ') + HN=$(echo ${VM_NAME,,} | tr -d ' ') echo -e "${HOSTNAME}${BOLD}${DGN}Hostname: ${BGN}$HN${CL}" fi else @@ -318,7 +318,7 @@ function advanced_settings() { "0" "KVM64 (Default)" ON \ "1" "Host" OFF \ 3>&1 1>&2 2>&3); then - if [ "$CPU_TYPE1" = "1" ]; then + if [ $CPU_TYPE1 = "1" ]; then echo -e "${OS}${BOLD}${DGN}CPU Model: ${BGN}Host${CL}" CPU_TYPE=" -cpu host" else @@ -330,7 +330,7 @@ function advanced_settings() { fi if CORE_COUNT=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Allocate CPU Cores" 8 58 2 --title "CORE COUNT" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then - if [ -z "$CORE_COUNT" ]; then + if [ -z $CORE_COUNT ]; then CORE_COUNT="2" echo -e "${CPUCORE}${BOLD}${DGN}CPU Cores: ${BGN}$CORE_COUNT${CL}" else @@ -341,7 +341,7 @@ function advanced_settings() { fi if RAM_SIZE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Allocate RAM in MiB" 8 58 2048 --title "RAM" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then - if [ -z "$RAM_SIZE" ]; then + if [ -z $RAM_SIZE ]; then RAM_SIZE="2048" echo -e "${RAMSIZE}${BOLD}${DGN}RAM Size: ${BGN}$RAM_SIZE${CL}" else @@ -352,7 +352,7 @@ function advanced_settings() { fi if BRG=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set a Bridge" 8 58 vmbr0 --title "BRIDGE" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then - if [ -z "$BRG" ]; then + if [ -z $BRG ]; then BRG="vmbr0" echo -e "${BRIDGE}${BOLD}${DGN}Bridge: ${BGN}$BRG${CL}" else @@ -362,8 +362,8 @@ function advanced_settings() { exit-script fi - if MAC1=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set a MAC Address" 8 58 "$GEN_MAC" --title "MAC ADDRESS" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then - if [ -z "$MAC1" ]; then + if MAC1=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set a MAC Address" 8 58 $GEN_MAC --title "MAC ADDRESS" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then + if [ -z $MAC1 ]; then MAC="$GEN_MAC" echo -e "${MACADDRESS}${BOLD}${DGN}MAC Address: ${BGN}$MAC${CL}" else @@ -375,7 +375,7 @@ function advanced_settings() { fi if VLAN1=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set a Vlan(leave blank for default)" 8 58 --title "VLAN" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then - if [ -z "$VLAN1" ]; then + if [ -z $VLAN1 ]; then VLAN1="Default" VLAN="" echo -e "${VLANTAG}${BOLD}${DGN}VLAN: ${BGN}$VLAN1${CL}" @@ -388,7 +388,7 @@ function advanced_settings() { fi if MTU1=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Interface MTU Size (leave blank for default)" 8 58 --title "MTU SIZE" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then - if [ -z "$MTU1" ]; then + if [ -z $MTU1 ]; then MTU1="Default" MTU="" echo -e "${DEFAULT}${BOLD}${DGN}Interface MTU Size: ${BGN}$MTU1${CL}" @@ -447,9 +447,9 @@ post_to_api_vm msg_info "Validating Storage" while read -r line; do - TAG=$(echo "$line" | awk '{print $1}') - TYPE=$(echo "$line" | awk '{printf "%-10s", $2}') - FREE=$(echo "$line" | numfmt --field 4-6 --from-unit=K --to=iec --format %.2f | awk '{printf( "%9sB", $6)}') + TAG=$(echo $line | awk '{print $1}') + TYPE=$(echo $line | awk '{printf "%-10s", $2}') + FREE=$(echo $line | numfmt --field 4-6 --from-unit=K --to=iec --format %.2f | awk '{printf( "%9sB", $6)}') ITEM=" Type: $TYPE Free: $FREE " OFFSET=2 if [[ $((${#ITEM} + $OFFSET)) -gt ${MSG_MAX_LENGTH:-} ]]; then @@ -486,7 +486,7 @@ echo -en "\e[1A\e[0K" FILE=$(basename $URL) msg_ok "Downloaded ${CL}${BL}${FILE}${CL}" -STORAGE_TYPE=$(pvesm status -storage "$STORAGE" | awk 'NR>1 {print $2}') +STORAGE_TYPE=$(pvesm status -storage $STORAGE | awk 'NR>1 {print $2}') case $STORAGE_TYPE in nfs | dir) DISK_EXT=".qcow2" @@ -504,26 +504,26 @@ btrfs) esac for i in {0,1}; do disk="DISK$i" - eval DISK"${i}"=vm-"${VMID}"-disk-"${i}"${DISK_EXT:-} - eval DISK"${i}"_REF="${STORAGE}":"${DISK_REF:-}"${!disk} + eval DISK${i}=vm-${VMID}-disk-${i}${DISK_EXT:-} + eval DISK${i}_REF=${STORAGE}:${DISK_REF:-}${!disk} done msg_info "Creating a Debian 12 VM" -qm create "$VMID" -agent 1"${MACHINE}" -tablet 0 -localtime 1 -bios ovmf"${CPU_TYPE}" -cores "$CORE_COUNT" -memory "$RAM_SIZE" \ - -name "$HN" -tags community-script -net0 virtio,bridge="$BRG",macaddr="$MAC"$VLAN"$MTU" -onboot 1 -ostype l26 -scsihw virtio-scsi-pci -pvesm alloc "$STORAGE" "$VMID" "$DISK0" 4M 1>&/dev/null -qm importdisk "$VMID" "${FILE}" "$STORAGE" "${DISK_IMPORT:-}" 1>&/dev/null +qm create $VMID -agent 1${MACHINE} -tablet 0 -localtime 1 -bios ovmf${CPU_TYPE} -cores $CORE_COUNT -memory $RAM_SIZE \ + -name $HN -tags community-script -net0 virtio,bridge=$BRG,macaddr=$MAC$VLAN$MTU -onboot 1 -ostype l26 -scsihw virtio-scsi-pci +pvesm alloc $STORAGE $VMID $DISK0 4M 1>&/dev/null +qm importdisk $VMID ${FILE} $STORAGE ${DISK_IMPORT:-} 1>&/dev/null if [ "$CLOUD_INIT" == "yes" ]; then - qm set "$VMID" \ - -efidisk0 "${DISK0_REF}"${FORMAT} \ - -scsi0 "${DISK1_REF}",${DISK_CACHE}${THIN}size="${DISK_SIZE}" \ - -scsi1 "${STORAGE}":cloudinit \ + qm set $VMID \ + -efidisk0 ${DISK0_REF}${FORMAT} \ + -scsi0 ${DISK1_REF},${DISK_CACHE}${THIN}size=${DISK_SIZE} \ + -scsi1 ${STORAGE}:cloudinit \ -boot order=scsi0 \ -serial0 socket >/dev/null else - qm set "$VMID" \ - -efidisk0 "${DISK0_REF}"${FORMAT} \ - -scsi0 "${DISK1_REF}",${DISK_CACHE}${THIN}size="${DISK_SIZE}" \ + qm set $VMID \ + -efidisk0 ${DISK0_REF}${FORMAT} \ + -scsi0 ${DISK1_REF},${DISK_CACHE}${THIN}size=${DISK_SIZE} \ -boot order=scsi0 \ -serial0 socket >/dev/null fi @@ -560,16 +560,16 @@ EOF qm set "$VMID" -description "$DESCRIPTION" >/dev/null if [ -n "$DISK_SIZE" ]; then msg_info "Resizing disk to $DISK_SIZE GB" - qm resize "$VMID" scsi0 "${DISK_SIZE}" >/dev/null + qm resize $VMID scsi0 ${DISK_SIZE} >/dev/null else msg_info "Using default disk size of $DEFAULT_DISK_SIZE GB" - qm resize "$VMID" scsi0 "${DEFAULT_DISK_SIZE}" >/dev/null + qm resize $VMID scsi0 ${DEFAULT_DISK_SIZE} >/dev/null fi msg_ok "Created a Debian 12 VM ${CL}${BL}(${HN})" if [ "$START_VM" == "yes" ]; then msg_info "Starting Debian 12 VM" - qm start "$VMID" + qm start $VMID msg_ok "Started Debian 12 VM" fi diff --git a/vm/docker-vm.sh b/vm/docker-vm.sh index e57531451..0e845e47a 100644 --- a/vm/docker-vm.sh +++ b/vm/docker-vm.sh @@ -561,7 +561,7 @@ DESCRIPTION=$( EOF ) -qm set "$VMID" -description "$DESCRIPTION" >/dev/null +qm set $VMID -description "$DESCRIPTION" >/dev/null msg_ok "Created a Docker VM ${CL}${BL}(${HN})" if [ "$START_VM" == "yes" ]; then diff --git a/vm/haos-vm.sh b/vm/haos-vm.sh index 4896143e1..f82b5940a 100644 --- a/vm/haos-vm.sh +++ b/vm/haos-vm.sh @@ -564,7 +564,7 @@ msg_ok "${CL}${BL}${URL}${CL}" download_and_validate_xz "$URL" "$CACHE_FILE" msg_info "Creating Home Assistant OS VM shell" -qm create "$VMID" -machine q35 -bios ovmf -agent 1 -tablet 0 -localtime 1 ${CPU_TYPE} \ +qm create $VMID -machine q35 -bios ovmf -agent 1 -tablet 0 -localtime 1 ${CPU_TYPE} \ -cores "$CORE_COUNT" -memory "$RAM_SIZE" -name "$HN" -tags community-script \ -net0 "virtio,bridge=$BRG,macaddr=$MAC$VLAN$MTU" -onboot 1 -ostype l26 -scsihw virtio-scsi-pci >/dev/null msg_ok "Created VM shell" @@ -590,16 +590,16 @@ msg_ok "Imported disk (${CL}${BL}${DISK_REF}${CL})" rm -f "$FILE_IMG" msg_info "Attaching EFI and root disk" -qm set "$VMID" \ - --efidisk0 "${STORAGE}:0,efitype=4m" \ - --scsi0 "${DISK_REF},ssd=1,discard=on" \ +qm set $VMID \ + --efidisk0 ${STORAGE}:0,efitype=4m \ + --scsi0 ${DISK_REF},ssd=1,discard=on \ --boot order=scsi0 \ --serial0 socket >/dev/null -qm set "$VMID" --agent enabled=1 >/dev/null +qm set $VMID --agent enabled=1 >/dev/null msg_ok "Attached EFI and root disk" msg_info "Resizing disk to $DISK_SIZE" -qm resize "$VMID" scsi0 "${DISK_SIZE}" >/dev/null +qm resize $VMID scsi0 ${DISK_SIZE} >/dev/null msg_ok "Resized disk" DESCRIPTION=$( @@ -632,7 +632,7 @@ DESCRIPTION=$( EOF ) -qm set "$VMID" -description "$DESCRIPTION" >/dev/null +qm set $VMID -description "$DESCRIPTION" >/dev/null msg_ok "Created Homeassistant OS VM ${CL}${BL}(${HN})" if whiptail --backtitle "Proxmox VE Helper Scripts" --title "Image Cache" \ diff --git a/vm/mikrotik-routeros.sh b/vm/mikrotik-routeros.sh index d2ab26900..0f000a84c 100644 --- a/vm/mikrotik-routeros.sh +++ b/vm/mikrotik-routeros.sh @@ -274,11 +274,11 @@ function get_mikrotik_version() { if [[ "$start_line" =~ ^[0-9]+$ ]]; then local line line=$(echo "$html" | tail -n +"$start_line" | grep -m 1 -E "c-(stable|longTerm|testing|development)-v|RouterOS [0-9]+\.[0-9]+" 2>/dev/null) - + local version version=$(echo "$line" | sed -n 's/.*c-[^"]*-v\([0-9_.a-zA-Z-]\+\).*/\1/p' | tr '_' '.' 2>/dev/null) [ -z "$version" ] && version=$(echo "$line" | grep -oP 'RouterOS \K[0-9]+\.[0-9]+(\.[0-9]+)?' 2>/dev/null) - + if [[ "$version" =~ ^[0-9]+\.[0-9]+ ]]; then echo "$version" return 0 @@ -611,7 +611,7 @@ DESCRIPTION=$( EOF ) -qm set "$VMID" -description "$DESCRIPTION" >/dev/null +qm set $VMID -description "$DESCRIPTION" >/dev/null if [ -n "$DISK_SIZE" ]; then msg_info "Resizing disk to $DISK_SIZE GB" qm resize $VMID scsi0 ${DISK_SIZE} >/dev/null diff --git a/vm/nextcloud-vm.sh b/vm/nextcloud-vm.sh index 57b250846..130b8148f 100644 --- a/vm/nextcloud-vm.sh +++ b/vm/nextcloud-vm.sh @@ -535,7 +535,7 @@ DESCRIPTION=$( EOF ) -qm set "$VMID" -description "$DESCRIPTION" >/dev/null +qm set $VMID -description "$DESCRIPTION" >/dev/null if [ -n "$DISK_SIZE" ]; then msg_info "Resizing disk to $DISK_SIZE GB" qm resize $VMID scsi0 ${DISK_SIZE} >/dev/null diff --git a/vm/openwrt-vm.sh b/vm/openwrt-vm.sh index 50c08a597..71320d5c6 100644 --- a/vm/openwrt-vm.sh +++ b/vm/openwrt-vm.sh @@ -528,16 +528,16 @@ FILE="${FILE%.*}" msg_ok "Extracted OpenWrt Disk Image ${CL}${BL}$FILE${CL}" msg_info "Creating OpenWrt VM" -qm create "$VMID" -cores "$CORE_COUNT" -memory "$RAM_SIZE" -name "$HN" \ +qm create $VMID -cores $CORE_COUNT -memory $RAM_SIZE -name $HN \ -onboot 1 -ostype l26 -scsihw virtio-scsi-pci --tablet 0 if [[ "$(pvesm status | awk -v s=$STORAGE '$1==s {print $2}')" == "dir" ]]; then - qm set "$VMID" -efidisk0 "${STORAGE}:0,efitype=4m,size=4M" + qm set $VMID -efidisk0 ${STORAGE}:0,efitype=4m,size=4M else - pvesm alloc "$STORAGE" "$VMID" "vm-$VMID-disk-0" 4M >/dev/null - qm set "$VMID" -efidisk0 "${STORAGE}:vm-$VMID-disk-0,efitype=4m,size=4M" + pvesm alloc $STORAGE $VMID vm-$VMID-disk-0 4M >/dev/null + qm set $VMID -efidisk0 ${STORAGE}:vm-$VMID-disk-0,efitype=4m,size=4M fi -IMPORT_OUT="$(qm importdisk "$VMID" "$FILE" "$STORAGE" --format raw 2>&1 || true)" +IMPORT_OUT="$(qm importdisk $VMID $FILE $STORAGE --format raw 2>&1 || true)" DISK_REF="$(printf '%s\n' "$IMPORT_OUT" | sed -n "s/.*successfully imported disk '\([^']\+\)'.*/\1/p")" if [[ -z "$DISK_REF" ]]; then @@ -550,9 +550,9 @@ if [[ -z "$DISK_REF" ]]; then exit 1 fi -qm set "$VMID" \ - -efidisk0 "${STORAGE}:0,efitype=4m,size=4M" \ - -scsi0 "${DISK_REF}" \ +qm set $VMID \ + -efidisk0 ${STORAGE}:0,efitype=4m,size=4M \ + -scsi0 ${DISK_REF} \ -boot order=scsi0 \ -tags community-script >/dev/null msg_ok "Attached disk" @@ -591,7 +591,7 @@ DESCRIPTION=$( EOF ) -qm set "$VMID" -description "$DESCRIPTION" >/dev/null +qm set $VMID -description "$DESCRIPTION" >/dev/null msg_ok "Created OpenWrt VM ${CL}${BL}(${HN})" msg_info "OpenWrt is being started in order to configure the network interfaces." @@ -636,14 +636,14 @@ done msg_ok "OpenWrt has shut down" msg_info "Adding bridge interfaces on Proxmox side" -qm set "$VMID" \ - -net0 virtio,bridge="${LAN_BRG}",macaddr="${LAN_MAC}${LAN_VLAN}${MTU}" \ - -net1 virtio,bridge="${BRG}",macaddr="${MAC}${VLAN}${MTU}" >/dev/null +qm set $VMID \ + -net0 virtio,bridge=${LAN_BRG},macaddr=${LAN_MAC}${LAN_VLAN}${MTU} \ + -net1 virtio,bridge=${BRG},macaddr=${MAC}${VLAN}${MTU} >/dev/null msg_ok "Bridge interfaces added" if [ "$START_VM" = "yes" ]; then msg_info "Starting OpenWrt VM" - qm start "$VMID" + qm start $VMID msg_ok "Started OpenWrt VM" fi diff --git a/vm/opnsense-vm.sh b/vm/opnsense-vm.sh index 2555c4beb..bc5acbf2d 100644 --- a/vm/opnsense-vm.sh +++ b/vm/opnsense-vm.sh @@ -579,10 +579,10 @@ msg_ok "Using ${CL}${BL}$STORAGE${CL} ${GN}for Storage Location." msg_ok "Virtual Machine ID is ${CL}${BL}$VMID${CL}." msg_info "Retrieving the URL for the OPNsense Qcow2 Disk Image" # Use latest stable FreeBSD amd64 qcow2 VM image (generic, not UFS/ZFS) -RELEASE_LIST="$(curl -s https://download.freebsd.org/releases/VM-IMAGES/ \ - | grep -Eo '[0-9]+\.[0-9]+-RELEASE' \ - | sort -Vr \ - | uniq)" +RELEASE_LIST="$(curl -s https://download.freebsd.org/releases/VM-IMAGES/ | + grep -Eo '[0-9]+\.[0-9]+-RELEASE' | + sort -Vr | + uniq)" URL="" FREEBSD_VER="" for ver in $RELEASE_LIST; do @@ -668,7 +668,7 @@ DESCRIPTION=$( EOF ) -qm set "$VMID" -description "$DESCRIPTION" >/dev/null +qm set $VMID -description "$DESCRIPTION" >/dev/null msg_info "Bridge interfaces are being added." qm set $VMID \ @@ -686,7 +686,7 @@ if [ -n "$WAN_BRG" ]; then qm set $VMID \ -net1 virtio,bridge=${WAN_BRG},macaddr=${WAN_MAC} &>/dev/null msg_ok "WAN interface added" - sleep 5 # Brief pause after adding network interface + sleep 5 # Brief pause after adding network interface fi send_line_to_vm "sh ./opnsense-bootstrap.sh.in -y -f -r 25.7" msg_ok "OPNsense VM is being installed, do not close the terminal, or the installation will fail." diff --git a/vm/owncloud-vm.sh b/vm/owncloud-vm.sh index c802843a3..bff0d7f88 100644 --- a/vm/owncloud-vm.sh +++ b/vm/owncloud-vm.sh @@ -549,7 +549,7 @@ DESCRIPTION=$( EOF ) -qm set "$VMID" -description "$DESCRIPTION" >/dev/null +qm set $VMID -description "$DESCRIPTION" >/dev/null if [ -n "$DISK_SIZE" ]; then msg_info "Resizing disk to $DISK_SIZE GB" qm resize $VMID scsi0 ${DISK_SIZE} >/dev/null diff --git a/vm/pimox-haos-vm.sh b/vm/pimox-haos-vm.sh index 3e36bc099..07e1740a1 100644 --- a/vm/pimox-haos-vm.sh +++ b/vm/pimox-haos-vm.sh @@ -450,7 +450,7 @@ DESCRIPTION=$( EOF ) -qm set "$VMID" -description "$DESCRIPTION" >/dev/null +qm set $VMID -description "$DESCRIPTION" >/dev/null if [ -n "$DISK_SIZE" ]; then msg_info "Resizing disk to $DISK_SIZE GB" qm resize $VMID scsi0 ${DISK_SIZE} >/dev/null diff --git a/vm/ubuntu2204-vm.sh b/vm/ubuntu2204-vm.sh index a446a8158..55a4dee7d 100644 --- a/vm/ubuntu2204-vm.sh +++ b/vm/ubuntu2204-vm.sh @@ -530,7 +530,7 @@ DESCRIPTION=$( EOF ) -qm set "$VMID" -description "$DESCRIPTION" >/dev/null +qm set $VMID -description "$DESCRIPTION" >/dev/null if [ -n "$DISK_SIZE" ]; then msg_info "Resizing disk to $DISK_SIZE GB" qm resize $VMID scsi0 ${DISK_SIZE} >/dev/null diff --git a/vm/ubuntu2404-vm.sh b/vm/ubuntu2404-vm.sh index 944deec28..565718d88 100644 --- a/vm/ubuntu2404-vm.sh +++ b/vm/ubuntu2404-vm.sh @@ -532,7 +532,7 @@ DESCRIPTION=$( EOF ) -qm set "$VMID" -description "$DESCRIPTION" >/dev/null +qm set $VMID -description "$DESCRIPTION" >/dev/null if [ -n "$DISK_SIZE" ]; then msg_info "Resizing disk to $DISK_SIZE GB" qm resize $VMID scsi0 ${DISK_SIZE} >/dev/null diff --git a/vm/ubuntu2504-vm.sh b/vm/ubuntu2504-vm.sh index e5e14f477..daad9713c 100644 --- a/vm/ubuntu2504-vm.sh +++ b/vm/ubuntu2504-vm.sh @@ -531,7 +531,7 @@ DESCRIPTION=$( EOF ) -qm set "$VMID" -description "$DESCRIPTION" >/dev/null +qm set $VMID -description "$DESCRIPTION" >/dev/null if [ -n "$DISK_SIZE" ]; then msg_info "Resizing disk to $DISK_SIZE GB" qm resize $VMID scsi0 ${DISK_SIZE} >/dev/null diff --git a/vm/umbrel-os-vm.sh b/vm/umbrel-os-vm.sh index 7f5908884..02a5bb439 100644 --- a/vm/umbrel-os-vm.sh +++ b/vm/umbrel-os-vm.sh @@ -530,7 +530,7 @@ mkdir -p "$CACHE_DIR" "$(dirname "$FILE_IMG")" download_and_validate_xz "$URL" "$CACHE_FILE" -qm create "$VMID" -machine q35 -bios ovmf -agent 1 -tablet 0 -localtime 1 ${CPU_TYPE} \ +qm create $VMID -machine q35 -bios ovmf -agent 1 -tablet 0 -localtime 1 ${CPU_TYPE} \ -cores "$CORE_COUNT" -memory "$RAM_SIZE" -name "$HN" -tags community-script \ -net0 "virtio,bridge=$BRG,macaddr=$MAC$VLAN$MTU" -onboot 1 -ostype l26 -scsihw virtio-scsi-pci >/dev/null @@ -545,13 +545,13 @@ IMPORT_OUT="$("${IMPORT_CMD[@]}" "$VMID" "$FILE_IMG" "$STORAGE" --format raw 2>& DISK_REF="$(printf '%s\n' "$IMPORT_OUT" | sed -n "s/.*imported disk '\([^']\+\)'.*/\1/p" | tr -d "\r\"'")" [[ -z "$DISK_REF" ]] && DISK_REF="$(pvesm list "$STORAGE" | awk -v id="$VMID" '$5 ~ ("vm-"id"-disk-") {print $1":"$5}' | sort | tail -n1)" -qm set "$VMID" \ - --efidisk0 "${STORAGE}:0,efitype=4m" \ - --scsi0 "${DISK_REF},ssd=1,discard=on" \ +qm set $VMID \ + --efidisk0 ${STORAGE}:0,efitype=4m \ + --scsi0 ${DISK_REF},ssd=1,discard=on \ --boot order=scsi0 \ --serial0 socket >/dev/null -qm set "$VMID" --agent enabled=1 >/dev/null -qm resize "$VMID" scsi0 "${DISK_SIZE}" >/dev/null +qm set $VMID --agent enabled=1 >/dev/null +qm resize $VMID scsi0 ${DISK_SIZE} >/dev/null DESCRIPTION=$( cat < EOF ) -qm set "$VMID" -description "$DESCRIPTION" >/dev/null +qm set $VMID -description "$DESCRIPTION" >/dev/null if whiptail --backtitle "Proxmox VE Helper Scripts" --title "Image Cache" \ --yesno "Keep downloaded Umbrel OS image for future VMs?\n\nFile: $CACHE_FILE" 10 70; then